Inspection of "Added some changes on validationErrors" - anetwork/respond - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e7cddf...c87dd8 )

unknown

created 2016-10-02 12:15 UTC

Status

Spacing +63 added lines, -63 removed lines patch added patch discarded remove patch

@@ -14,11 +14,11 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function succeed( $data ) {
+	public function succeed($data) {
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithResult( $data );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithResult($data);
 
 	}
 
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteSucceeded( $message = null ) {
+	public function deleteSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'delete' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -49,14 +49,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateSucceeded( $message = null ) {
+	public function updateSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'update' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -68,14 +68,14 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertSucceeded( $message = null ) {
+	public function insertSucceeded($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'success' ][ 'insert' ];
 
-		return $this->setStatusCode( 200 )
-					->setStatusText( 'success' )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(200)
+					->setStatusText('success')
+					->respondWithMessage($message);
 
 	}
 
@@ -87,15 +87,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function deleteFaild( $message = null ) {
+	public function deleteFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'delete' ];
 
-		return $this->setStatusCode( 447 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5447 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(447)
+					->setStatusText('fail')
+					->setErrorCode(5447)
+					->respondWithMessage($message);
 
 	}
 
@@ -107,15 +107,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function updateFaild( $message = null ) {
+	public function updateFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'update' ];
 
-		return $this->setStatusCode( 449 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5449 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(449)
+					->setStatusText('fail')
+					->setErrorCode(5449)
+					->respondWithMessage($message);
 
 	}
 
@@ -127,15 +127,15 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function insertFaild( $message = null ) {
+	public function insertFaild($message = null) {
 
-		if ( is_null( $message ) )
+		if (is_null($message))
 			$message = $this->config[ 'fail' ][ 'insert' ];
 
-		return $this->setStatusCode( 448 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5448 )
-					->respondWithMessage( $message );
+		return $this->setStatusCode(448)
+					->setStatusText('fail')
+					->setErrorCode(5448)
+					->respondWithMessage($message);
 
 	}
 
@@ -149,9 +149,9 @@  discard block
 block discarded – undo
 	 */
 	public function connectionRefused() {
 
-		return $this->setStatusCode( 445 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5445 )
+		return $this->setStatusCode(445)
+					->setStatusText('fail')
+					->setErrorCode(5445)
 					->respondWithMessage();
 
 	}
@@ -166,9 +166,9 @@  discard block
 block discarded – undo
 	 */
 	public function notFound() {
 
-		return $this->setStatusCode( 404 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5404 )
+		return $this->setStatusCode(404)
+					->setStatusText('fail')
+					->setErrorCode(5404)
 					->respondWithMessage();
 
 	}
@@ -183,9 +183,9 @@  discard block
 block discarded – undo
 	 */
 	public function wrongParameters() {
 
-		return $this->setStatusCode( 406 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5406 )
+		return $this->setStatusCode(406)
+					->setStatusText('fail')
+					->setErrorCode(5406)
 					->respondWithMessage();
 
 	}
@@ -200,9 +200,9 @@  discard block
 block discarded – undo
 	 */
 	public function methodNotAllowed() {
 
-		return $this->setStatusCode( 405 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5405 )
+		return $this->setStatusCode(405)
+					->setStatusText('fail')
+					->setErrorCode(5405)
 					->respondWithMessage();
 
 	}
@@ -215,12 +215,12 @@  discard block
 block discarded – undo
 	 * @uses
 	 * @see
 	 */
-	public function validationErrors( $message = null ) {
+	public function validationErrors($message = null) {
 
-		return $this->setStatusCode( 420 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 5420 )
-					->respondWithResult( $message );
+		return $this->setStatusCode(420)
+					->setStatusText('fail')
+					->setErrorCode(5420)
+					->respondWithResult($message);
 
 	}
 
@@ -234,9 +234,9 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldNotFound() {
 
-		return $this->setStatusCode( 446 )
-					->setStatusText( 'fail' )
-					->setErrorCode( 1001 )
+		return $this->setStatusCode(446)
+					->setStatusText('fail')
+					->setErrorCode(1001)
 					->respondWithMessage();
 
 	}
@@ -249,8 +249,8 @@  discard block
 block discarded – undo
 	 */
 	public function requestFieldDuplicated() {
 
-	  return $this->setStatusCode( 400 )
-					->setStatusText( 'fail' )
+	  return $this->setStatusCode(400)
+					->setStatusText('fail')
 					->SetErrorCode(1004)
 					->respondWithMessage();
 
@@ -263,11 +263,11 @@  discard block
 block discarded – undo
 	 * @param $code integer
 	 * @return json
 	 */
-	public function error( $code ) {
+	public function error($code) {
 
-	  return $this->SetStatusCode( 400 )
-					->setStatusText( 'fail' )
-					->setErrorCode( $code )
+	  return $this->SetStatusCode(400)
+					->setStatusText('fail')
+					->setErrorCode($code)
 					->respondWithMessage();
 
 	}

Please login to merge, or discard this patch.

		@@ -14,11 +14,11 @@ discard block
		block discarded – undo
14	14	* @uses
15	15	* @see
16	16	*/
17		- public function succeed( $data ) {
	17	+ public function succeed($data) {
18	18
19		- return $this->setStatusCode( 200 )
20		- ->setStatusText( 'success' )
21		- ->respondWithResult( $data );
	19	+ return $this->setStatusCode(200)
	20	+ ->setStatusText('success')
	21	+ ->respondWithResult($data);
22	22
23	23	}
24	24
		@@ -30,14 +30,14 @@ discard block
		block discarded – undo
30	30	* @uses
31	31	* @see
32	32	*/
33		- public function deleteSucceeded( $message = null ) {
	33	+ public function deleteSucceeded($message = null) {
34	34
35		- if ( is_null( $message ) )
	35	+ if (is_null($message))
36	36	$message = $this->config[ 'success' ][ 'delete' ];
37	37
38		- return $this->setStatusCode( 200 )
39		- ->setStatusText( 'success' )
40		- ->respondWithMessage( $message );
	38	+ return $this->setStatusCode(200)
	39	+ ->setStatusText('success')
	40	+ ->respondWithMessage($message);
41	41
42	42	}
43	43
		@@ -49,14 +49,14 @@ discard block
		block discarded – undo
49	49	* @uses
50	50	* @see
51	51	*/
52		- public function updateSucceeded( $message = null ) {
	52	+ public function updateSucceeded($message = null) {
53	53
54		- if ( is_null( $message ) )
	54	+ if (is_null($message))
55	55	$message = $this->config[ 'success' ][ 'update' ];
56	56
57		- return $this->setStatusCode( 200 )
58		- ->setStatusText( 'success' )
59		- ->respondWithMessage( $message );
	57	+ return $this->setStatusCode(200)
	58	+ ->setStatusText('success')
	59	+ ->respondWithMessage($message);
60	60
61	61	}
62	62
		@@ -68,14 +68,14 @@ discard block
		block discarded – undo
68	68	* @uses
69	69	* @see
70	70	*/
71		- public function insertSucceeded( $message = null ) {
	71	+ public function insertSucceeded($message = null) {
72	72
73		- if ( is_null( $message ) )
	73	+ if (is_null($message))
74	74	$message = $this->config[ 'success' ][ 'insert' ];
75	75
76		- return $this->setStatusCode( 200 )
77		- ->setStatusText( 'success' )
78		- ->respondWithMessage( $message );
	76	+ return $this->setStatusCode(200)
	77	+ ->setStatusText('success')
	78	+ ->respondWithMessage($message);
79	79
80	80	}
81	81
		@@ -87,15 +87,15 @@ discard block
		block discarded – undo
87	87	* @uses
88	88	* @see
89	89	*/
90		- public function deleteFaild( $message = null ) {
	90	+ public function deleteFaild($message = null) {
91	91
92		- if ( is_null( $message ) )
	92	+ if (is_null($message))
93	93	$message = $this->config[ 'fail' ][ 'delete' ];
94	94
95		- return $this->setStatusCode( 447 )
96		- ->setStatusText( 'fail' )
97		- ->setErrorCode( 5447 )
98		- ->respondWithMessage( $message );
	95	+ return $this->setStatusCode(447)
	96	+ ->setStatusText('fail')
	97	+ ->setErrorCode(5447)
	98	+ ->respondWithMessage($message);
99	99
100	100	}
101	101
		@@ -107,15 +107,15 @@ discard block
		block discarded – undo
107	107	* @uses
108	108	* @see
109	109	*/
110		- public function updateFaild( $message = null ) {
	110	+ public function updateFaild($message = null) {
111	111
112		- if ( is_null( $message ) )
	112	+ if (is_null($message))
113	113	$message = $this->config[ 'fail' ][ 'update' ];
114	114
115		- return $this->setStatusCode( 449 )
116		- ->setStatusText( 'fail' )
117		- ->setErrorCode( 5449 )
118		- ->respondWithMessage( $message );
	115	+ return $this->setStatusCode(449)
	116	+ ->setStatusText('fail')
	117	+ ->setErrorCode(5449)
	118	+ ->respondWithMessage($message);
119	119
120	120	}
121	121
		@@ -127,15 +127,15 @@ discard block
		block discarded – undo
127	127	* @uses
128	128	* @see
129	129	*/
130		- public function insertFaild( $message = null ) {
	130	+ public function insertFaild($message = null) {
131	131
132		- if ( is_null( $message ) )
	132	+ if (is_null($message))
133	133	$message = $this->config[ 'fail' ][ 'insert' ];
134	134
135		- return $this->setStatusCode( 448 )
136		- ->setStatusText( 'fail' )
137		- ->setErrorCode( 5448 )
138		- ->respondWithMessage( $message );
	135	+ return $this->setStatusCode(448)
	136	+ ->setStatusText('fail')
	137	+ ->setErrorCode(5448)
	138	+ ->respondWithMessage($message);
139	139
140	140	}
141	141
		@@ -149,9 +149,9 @@ discard block
		block discarded – undo
149	149	*/
150	150	public function connectionRefused() {
151	151
152		- return $this->setStatusCode( 445 )
153		- ->setStatusText( 'fail' )
154		- ->setErrorCode( 5445 )
	152	+ return $this->setStatusCode(445)
	153	+ ->setStatusText('fail')
	154	+ ->setErrorCode(5445)
155	155	->respondWithMessage();
156	156
157	157	}
		@@ -166,9 +166,9 @@ discard block
		block discarded – undo
166	166	*/
167	167	public function notFound() {
168	168
169		- return $this->setStatusCode( 404 )
170		- ->setStatusText( 'fail' )
171		- ->setErrorCode( 5404 )
	169	+ return $this->setStatusCode(404)
	170	+ ->setStatusText('fail')
	171	+ ->setErrorCode(5404)
172	172	->respondWithMessage();
173	173
174	174	}
		@@ -183,9 +183,9 @@ discard block
		block discarded – undo
183	183	*/
184	184	public function wrongParameters() {
185	185
186		- return $this->setStatusCode( 406 )
187		- ->setStatusText( 'fail' )
188		- ->setErrorCode( 5406 )
	186	+ return $this->setStatusCode(406)
	187	+ ->setStatusText('fail')
	188	+ ->setErrorCode(5406)
189	189	->respondWithMessage();
190	190
191	191	}
		@@ -200,9 +200,9 @@ discard block
		block discarded – undo
200	200	*/
201	201	public function methodNotAllowed() {
202	202
203		- return $this->setStatusCode( 405 )
204		- ->setStatusText( 'fail' )
205		- ->setErrorCode( 5405 )
	203	+ return $this->setStatusCode(405)
	204	+ ->setStatusText('fail')
	205	+ ->setErrorCode(5405)
206	206	->respondWithMessage();
207	207
208	208	}
		@@ -215,12 +215,12 @@ discard block
		block discarded – undo
215	215	* @uses
216	216	* @see
217	217	*/
218		- public function validationErrors( $message = null ) {
	218	+ public function validationErrors($message = null) {
219	219
220		- return $this->setStatusCode( 420 )
221		- ->setStatusText( 'fail' )
222		- ->setErrorCode( 5420 )
223		- ->respondWithResult( $message );
	220	+ return $this->setStatusCode(420)
	221	+ ->setStatusText('fail')
	222	+ ->setErrorCode(5420)
	223	+ ->respondWithResult($message);
224	224
225	225	}
226	226
		@@ -234,9 +234,9 @@ discard block
		block discarded – undo
234	234	*/
235	235	public function requestFieldNotFound() {
236	236
237		- return $this->setStatusCode( 446 )
238		- ->setStatusText( 'fail' )
239		- ->setErrorCode( 1001 )
	237	+ return $this->setStatusCode(446)
	238	+ ->setStatusText('fail')
	239	+ ->setErrorCode(1001)
240	240	->respondWithMessage();
241	241
242	242	}
		@@ -249,8 +249,8 @@ discard block
		block discarded – undo
249	249	*/
250	250	public function requestFieldDuplicated() {
251	251
252		- return $this->setStatusCode( 400 )
253		- ->setStatusText( 'fail' )
	252	+ return $this->setStatusCode(400)
	253	+ ->setStatusText('fail')
254	254	->SetErrorCode(1004)
255	255	->respondWithMessage();
256	256
		@@ -263,11 +263,11 @@ discard block
		block discarded – undo
263	263	* @param $code integer
264	264	* @return json
265	265	*/
266		- public function error( $code ) {
	266	+ public function error($code) {
267	267
268		- return $this->SetStatusCode( 400 )
269		- ->setStatusText( 'fail' )
270		- ->setErrorCode( $code )
	268	+ return $this->SetStatusCode(400)
	269	+ ->setStatusText('fail')
	270	+ ->setErrorCode($code)
271	271	->respondWithMessage();
272	272
273	273	}

anetwork / respond

Push — master ( e7cddf...c87dd8 )

Status

Category

Spacing +63 added lines, -63 removed lines patch added patch discarded remove patch