Completed
Push — master ( 3dee16...2bf36e )
by Andy
02:57
created

Area::getOtherNames()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 2
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 4
c 0
b 0
f 0
ccs 2
cts 2
cp 1
rs 10
cc 1
eloc 2
nc 1
nop 0
crap 1
1
<?php
2
3
namespace EveryPolitician\EveryPoliticianPopolo\Objects;
4
5
class Area extends PopoloObject
6
{
7
    protected $properties = [
8
        'id',
9
        'name',
10
        'type',
11
        'identifiers',
12
        'otherNames',
13
        'wikidata',
14
    ];
15
16 3
    public function __toString()
17
    {
18 3
        return "<Area: ".$this->name.">";
0 ignored issues
show
Documentation introduced by
The property name does not exist on object<EveryPolitician\E...ianPopolo\Objects\Area>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
19
    }
20
21 27
    protected function getId()
22
    {
23 27
         return $this->arrGet($this->data, 'id');
24
    }
25
26 6
    protected function getName()
27
    {
28 6
         return $this->arrGet($this->data, 'name');
29
    }
30
31 3
    protected function getType()
32
    {
33 3
         return $this->arrGet($this->data, 'type');
34
    }
35
36 3
    protected function getIdentifiers()
37
    {
38 3
         return $this->getRelatedObjectArr('identifiers');
39
    }
40
41 3
    protected function getOtherNames()
42
    {
43 3
         return $this->getRelatedObjectArr('other_names');
44
    }
45
46 3
    protected function getWikidata()
47
    {
48 3
        return $this->identifierValue('wikidata');
49
    }
50
}
51