mySociety\EveryPoliticianPopolo\Collections\PopoloCollection

Complexity

Total Complexity

26

Size/Duplication

Total Lines	138
Duplicated Lines	5.8 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

80%

Importance

Changes

0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	3
A	__toString()	0	4	1
A	__get()	8	8	2
A	getFirst()	0	4	2
B	filter()	0	17	5
A	get()	0	13	3
A	count()	0	4	1
A	offsetExists()	0	4	1
A	offsetGet()	0	4	1
A	offsetSet()	0	4	1
A	offsetUnset()	0	4	1
A	current()	0	4	1
A	key()	0	4	1
A	next()	0	4	1
A	rewind()	0	4	1
A	valid()	0	4	1

<?php

namespace EveryPolitician\EveryPoliticianPopolo\Collections;

use \EveryPolitician\EveryPoliticianPopolo\Exceptions;

class PopoloCollection implements \Countable, \ArrayAccess, \Iterator
{
    protected $properties = [
        'first',
    ];
    public $lookupFromKey;
    private $objectClass;
    private $objectArr;
    private $position;

    /**
     *
     */
    public function __construct($dataArr, $objectClass, $allPopolo)
    {
        $this->position = 0;
        $this->objectClass = $objectClass;
        $this->objectArr = [];
        foreach ($dataArr as $data) {
            $this->objectArr[] = new $objectClass($data, $allPopolo);
        }
        $this->lookupFromKey = [];
        foreach ($this->objectArr as $o) {
            $this->lookupFromKey[$o->keyForHash] = $o;
        }
    }

    public function __toString()
    {
        return '<'.get_class($this).'>';
    }

    public function __get($prop)

This method seems to be duplicated in your project.

    {
        if (in_array($prop, $this->properties)) {
            $getter = 'get' . ucfirst($prop);
            return $this->$getter();
        }
        trigger_error('Undefined property: '.__CLASS__.'::$'.$prop, E_USER_ERROR);
    }

    private function getFirst()
    {
        return (count($this->objectArr) > 0) ? $this->objectArr[0] : null;
    }

    public function filter($filters)
    {
        $filtered = [];
        foreach ($this->objectArr as $obj) {
            $success = true;
            foreach ($filters as $prop => $value) {
                if ($obj->$prop !== $value) {
                    $success = false;
                    break;
                }
            }
            if ($success) {
                $filtered[] = $obj;
            }
        }
        return $filtered;
    }

    public function get($filters)
    {
        $matches = $this->filter($filters);
        $n = count($matches);
        if ($n == 0) {
            $msg = "No " . $this->objectClass . " found matching " . json_encode($filters);
            throw new Exceptions\ObjectDoesNotExistException($msg);
        } elseif ($n > 1) {
            $msg = "Multiple " . $this->objectClass . " objects ($n) found matching " . json_encode($filters);
            throw new Exceptions\MultipleObjectsReturnedException($msg);
        }
        return $matches[0];
    }

    // Countable interface
    public function count()
    {
        return count($this->objectArr);
    }

    // ArrayAccess interface
    public function offsetExists($offset)
    {
        return array_key_exists($offset, $this->objectArr);
    }

    // ArrayAccess interface
    public function offsetGet($offset)
    {
        return $this->objectArr[$offset];
    }

    // ArrayAccess interface
    public function offsetSet($offset, $value)
    {
        $this->objectArr[$offset] = $value;
    }

    // ArrayAccess interface
    public function offsetUnset($offset)
    {
        unset($this->objectArr[$offset]);
    }

    // Iterator interface
    public function current()
    {
        return $this->objectArr[$this->position];
    }

    // Iterator interface
    public function key()
    {
        return $this->position;
    }

    // Iterator interface
    public function next()
    {
        $this->position += 1;
    }

    // Iterator interface
    public function rewind()
    {
        $this->position = 0;
    }

    // Iterator interface
    public function valid()
    {
        return array_key_exists($this->position, $this->objectArr);
    }
}