Post - Code Metrics - Inspection of "Change vendor everywhere" - andylolz/everypolitician-popolo-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3dee16...2bf36e )

by Andy

created 2016-12-12 02:24 UTC

Post A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	5
lcom	2
cbo	1
dl	0
loc	34
c	0
b	0
f	0
ccs	10
cts	10
cp	1
rs	10

5 Methods

Rating	Name	Size	Complexity
A	__toString()	4	1
A	getId()	4	1
A	getLabel()	4	1
A	getOrganizationId()	4	1
A	getOrganization()	4	1

<?php

namespace EveryPolitician\EveryPoliticianPopolo\Objects;

class Post extends PopoloObject
{
    protected $properties = [
        'id',
        'label',
        'organizationId',
        'organization',
    ];

    public function __toString()
    {
        return "<Post: ".$this->label.">";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function getId()
    {
         return $this->arrGet($this->data, 'id');
    }

    protected function getLabel()
    {
         return $this->arrGet($this->data, 'label');
    }

    protected function getOrganizationId()
    {
        return $this->arrGet($this->data, 'organization_id');
    }

    protected function getOrganization()
    {
        return $this->allPopolo->organizations->lookupFromKey[$this->organizationId];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1		<?php
2
3		namespace EveryPolitician\EveryPoliticianPopolo\Objects;
4
5		class Post extends PopoloObject
6		{
7		protected $properties = [
8		'id',
9		'label',
10		'organizationId',
11		'organization',
12		];
13
14	3	public function __toString()
15		{
16	3	return "<Post: ".$this->label.">";
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `label` does not exist on `object<EveryPolitician\E...ianPopolo\Objects\Post>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
17		}
18
19	21	protected function getId()
20		{
21	21	return $this->arrGet($this->data, 'id');
22		}
23
24	6	protected function getLabel()
25		{
26	6	return $this->arrGet($this->data, 'label');
27		}
28
29	6	protected function getOrganizationId()
30		{
31	6	return $this->arrGet($this->data, 'organization_id');
32		}
33
34	3	protected function getOrganization()
35		{
36	3	return $this->allPopolo->organizations->lookupFromKey[$this->organizationId];
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `organizationId` does not exist on `object<EveryPolitician\E...ianPopolo\Objects\Post>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37		}
38		}
39

andylolz / everypolitician-popolo-php

Push — master ( 3dee16...2bf36e )

Post A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like