Organization::getName() - Code Metrics - Inspection of "Tidy" - andylolz/everypolitician-popolo-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 01abf8...56bab1 )

by Andy

created 2016-12-11 23:04 UTC

Organization::getName() A

↳ Parent: Organization

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace mySociety\EveryPoliticianPopolo\Objects;

class Organization extends PopoloObject
{
    protected $properties = [
        'id',
        'name',
        'wikidata',
        'classification',
        'image',
        'foundingDate',
        'dissolutionDate',
        'seats',
        'otherNames',
        'identifiers',
        'links',
    ];

    public function __toString()
    {
        return "<Organization: ".$this->name.">";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function getId()
    {
         return $this->arrGet($this->data, 'id');
    }

    protected function getName()
    {
         return $this->arrGet($this->data, 'name');
    }

    protected function getWikidata()
    {
        return $this->identifierValue('wikidata');
    }

    protected function getClassification() {
        return $this->arrGet($this->data, 'classification');
    }

    protected function getImage()
    {
        return $this->arrGet($this->data, 'image');
    }

    protected function getFoundingDate()
    {
        return $this->getDate('founding_date');
    }
    protected function getDissolutionDate()
    {
        return $this->getDate('dissolution_date');
    }
    protected function getSeats()
    {
        return $this->arrGet($this->data, 'seats');
    }
    protected function getOtherNames()
    {
        return $this->arrGet($this->data, 'other_names', []);
    }

    protected function getIdentifiers()
    {
         return $this->getRelatedObjectArr('identifiers');
    }

    protected function getLinks()
    {
        return $this->getRelatedObjectArr('links');
    }
}


1		<?php
2
3		namespace mySociety\EveryPoliticianPopolo\Objects;
4
5		class Organization extends PopoloObject
6		{
7		protected $properties = [
8		'id',
9		'name',
10		'wikidata',
11		'classification',
12		'image',
13		'foundingDate',
14		'dissolutionDate',
15		'seats',
16		'otherNames',
17		'identifiers',
18		'links',
19		];
20
21	3	public function __toString()
22		{
23	3	return "<Organization: ".$this->name.">";
		0 ignored issues – show Documentation introduced 2016-12-11 23:06 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<mySociety\EveryPo...o\Objects\Organization>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24		}
25
26	42	protected function getId()
27		{
28	42	return $this->arrGet($this->data, 'id');
29		}
30
31	6	protected function getName()
32		{
33	6	return $this->arrGet($this->data, 'name');
34		}
35
36	6	protected function getWikidata()
37		{
38	6	return $this->identifierValue('wikidata');
39		}
40
41	3	protected function getClassification() {
42	3	return $this->arrGet($this->data, 'classification');
43		}
44
45	3	protected function getImage()
46		{
47	3	return $this->arrGet($this->data, 'image');
48		}
49
50	3	protected function getFoundingDate()
51		{
52	3	return $this->getDate('founding_date');
53		}
54	3	protected function getDissolutionDate()
55		{
56	3	return $this->getDate('dissolution_date');
57		}
58	3	protected function getSeats()
59		{
60	3	return $this->arrGet($this->data, 'seats');
61		}
62	3	protected function getOtherNames()
63		{
64	3	return $this->arrGet($this->data, 'other_names', []);
65		}
66
67	3	protected function getIdentifiers()
68		{
69	3	return $this->getRelatedObjectArr('identifiers');
70		}
71
72	3	protected function getLinks()
73		{
74	3	return $this->getRelatedObjectArr('links');
75		}
76		}
77

andylolz / everypolitician-popolo-php

Push — master ( 01abf8...56bab1 )

Organization::getName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like