Person - Code Metrics - andylolz/everypolitician-popolo-php - Measure and Improve Code Quality continuously with Scrutinizer

Person B
last analyzed 2016-12-14 12:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	259
Duplicated Lines	0 %

Coupling/Cohesion

Components	5
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	50
lcom	5
cbo	3
dl	0
loc	259
ccs	107
cts	107
cp	1
rs	8.6206
c	0
b	0
f	0

34 Methods

Rating	Name	Size	Complexity
A	__toString()	4	1
A	getId()	4	1
A	getEmail()	4	1
A	getGender()	4	1
A	getHonorificPrefix()	4	1
A	getHonorificSuffix()	4	1
A	getImage()	4	1
A	getName()	4	1
A	getSortName()	4	1
A	getNationalIdentity()	4	1
A	getSummary()	4	1
A	getBiography()	4	1
A	getBirthDate()	4	1
A	getDeathDate()	4	1
A	getFamilyName()	4	1
A	getGivenName()	4	1
A	getWikidata()	4	1
A	getTwitter()	8	3
A	getTwitterAll()	14	3
A	getPhone()	4	1
A	getPhoneAll()	4	1
A	getFacebook()	4	1
A	getFacebookAll()	4	1
A	getFax()	4	1
A	getFaxAll()	4	1
A	getLinks()	4	1
A	getContactDetails()	4	1
A	getIdentifiers()	4	1
A	getImages()	4	1
A	getOtherNames()	4	1
A	getSources()	4	1
A	getMemberships()	10	3
A	isNameCurrentAt()	6	4
C	nameAt()	27	8

How to fix Complexity

<?php

namespace EveryPolitician\EveryPoliticianPopolo\Objects;

use \Exception;
use \EveryPolitician\EveryPoliticianPopolo\Parse;

class Person extends PopoloObject
{
    use \EveryPolitician\EveryPoliticianPopolo\Traits\ArrayGetterTrait;

    protected $properties = [
        'id',
        'email',
        'gender',
        'honorificPrefix',
        'honorificSuffix',
        'image',
        'name',
        'sortName',
        'nationalIdentity',
        'summary',
        'biography',
        'birthDate',
        'deathDate',
        'familyName',
        'givenName',
        'wikidata',
        'twitter',
        'twitterAll',
        'phone',
        'phoneAll',
        'facebook',
        'facebookAll',
        'fax',
        'faxAll',

        'links',
        'contactDetails',
        'identifiers',
        'images',
        'otherNames',
        'sources',
        'memberships',
    ];

    /**
     * String representation of {@link Person}
     *
     * @return string
     */
    public function __toString()
    {
        return "<Person: ".$this->name.">";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function getId()
    {
        return $this->arrGet($this->data, 'id');
    }

    protected function getEmail()
    {
        return $this->arrGet($this->data, 'email');
    }

    protected function getGender()
    {
        return $this->arrGet($this->data, 'gender');
    }

    protected function getHonorificPrefix()
    {
        return $this->arrGet($this->data, 'honorific_prefix');
    }

    protected function getHonorificSuffix()
    {
        return $this->arrGet($this->data, 'honorific_suffix');
    }

    protected function getImage()
    {
        return $this->arrGet($this->data, 'image');
    }

    protected function getName()
    {
        return $this->arrGet($this->data, 'name');
    }

    protected function getSortName()
    {
        return $this->arrGet($this->data, 'sort_name');
    }

    protected function getNationalIdentity()
    {
        return $this->arrGet($this->data, 'national_identity');
    }

    protected function getSummary()
    {
        return $this->arrGet($this->data, 'summary');
    }

    protected function getBiography()
    {
        return $this->arrGet($this->data, 'biography');
    }

    protected function getBirthDate()
    {
        return $this->getDate('birth_date');
    }

    protected function getDeathDate()
    {
        return $this->getDate('death_date');
    }

    protected function getFamilyName()
    {
        return $this->arrGet($this->data, 'family_name');
    }

    protected function getGivenName()
    {
        return $this->arrGet($this->data, 'given_name');
    }

    protected function getWikidata()
    {
        return $this->identifierValue('wikidata');
    }

    protected function getTwitter()
    {
        $usernameOrUrl = $this->contactDetailValue('twitter') ?: $this->linkValue('twitter');
        if ($usernameOrUrl) {
            return Parse::extractTwitterUsername($usernameOrUrl);
        }
        return null;
    }

    protected function getTwitterAll()
    {
        // The Twitter screen names in contact_details and links will
        // in most cases be the same, so remove duplicates:
        $allTwitters = [];
        $rawTwitters = $this->contactDetailValues('twitter') + $this->linkValues('twitter');
        foreach ($rawTwitters as $rawTwitter) {
            $twitter = Parse::extractTwitterUsername($rawTwitter);
            if (!in_array($twitter, $allTwitters)) {
                $allTwitters[] = $twitter;
            }
        }
        return $allTwitters;
    }

    protected function getPhone()
    {
        return $this->contactDetailValue('phone');
    }

    protected function getPhoneAll()
    {
        return $this->contactDetailValues('phone');
    }

    protected function getFacebook()
    {
        return $this->linkValue('facebook');
    }

    protected function getFacebookAll()
    {
        return $this->linkValues('facebook');
    }

    protected function getFax()
    {
        return $this->contactDetailValue('fax');
    }

    protected function getFaxAll()
    {
        return $this->contactDetailValues('fax');
    }

    protected function getLinks()
    {
        return $this->getRelatedObjectArr('links');
    }

    protected function getContactDetails()
    {
        return $this->getRelatedObjectArr('contact_details');
    }

    protected function getIdentifiers()
    {
        return $this->getRelatedObjectArr('identifiers');
    }

    protected function getImages()
    {
        return $this->getRelatedObjectArr('images');
    }

    protected function getOtherNames()
    {
        return $this->getRelatedObjectArr('other_names');
    }

    protected function getSources()
    {
        return $this->getRelatedObjectArr('sources');
    }

    protected function getMemberships()
    {
        $memberships = [];
        foreach ($this->allPopolo->memberships as $m) {
            if ($m->personId == $this->id) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $memberships[] = $m;
            }
        }
        return $memberships;
    }

    private function isNameCurrentAt($name, $dateStr)
    {
        $startRange = $this->arrGet($name, 'start_date') ?: '0001-01-01';
        $endRange = $this->arrGet($name, 'end_date') ?: '9999-12-31';
        return $dateStr >= $startRange && $dateStr <= $endRange;
    }

    public function nameAt($particularDate)
    {
        $historicNames = [];
        foreach ($this->otherNames as $otherName) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (array_key_exists('end_date', $otherName)) {
                $historicNames[] = $otherName;
            }
        }
        if (empty($historicNames)) {
            return $this->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        $namesAtDate = [];
        foreach ($historicNames as $n) {
            if ($this->isNameCurrentAt($n, $particularDate->format('Y-m-d'))) {
                $namesAtDate[] = $n;
            }
        }
        if (empty($namesAtDate)) {
            return $this->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if (count($namesAtDate) > 1) {
            $msg = 'Multiple names for '.(string) $this;
            $msg .= ' found at date '.$particularDate->format('Y-m-d');
            throw new Exception($msg);
        }
        return $namesAtDate[0]['name'];
    }
}


1		<?php
2
3		namespace EveryPolitician\EveryPoliticianPopolo\Objects;
4
5		use \Exception;
6		use \EveryPolitician\EveryPoliticianPopolo\Parse;
7
8		class Person extends PopoloObject
9		{
10		use \EveryPolitician\EveryPoliticianPopolo\Traits\ArrayGetterTrait;
11
12		protected $properties = [
13		'id',
14		'email',
15		'gender',
16		'honorificPrefix',
17		'honorificSuffix',
18		'image',
19		'name',
20		'sortName',
21		'nationalIdentity',
22		'summary',
23		'biography',
24		'birthDate',
25		'deathDate',
26		'familyName',
27		'givenName',
28		'wikidata',
29		'twitter',
30		'twitterAll',
31		'phone',
32		'phoneAll',
33		'facebook',
34		'facebookAll',
35		'fax',
36		'faxAll',
37
38		'links',
39		'contactDetails',
40		'identifiers',
41		'images',
42		'otherNames',
43		'sources',
44		'memberships',
45		];
46
47		/**
48		* String representation of {@link Person}
49		*
50		* @return string
51		*/
52	6	public function __toString()
53		{
54	6	return "<Person: ".$this->name.">";
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<EveryPolitician\E...nPopolo\Objects\Person>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
55		}
56
57	90	protected function getId()
58		{
59	90	return $this->arrGet($this->data, 'id');
60		}
61
62	3	protected function getEmail()
63		{
64	3	return $this->arrGet($this->data, 'email');
65		}
66
67	3	protected function getGender()
68		{
69	3	return $this->arrGet($this->data, 'gender');
70		}
71
72	3	protected function getHonorificPrefix()
73		{
74	3	return $this->arrGet($this->data, 'honorific_prefix');
75		}
76
77	3	protected function getHonorificSuffix()
78		{
79	3	return $this->arrGet($this->data, 'honorific_suffix');
80		}
81
82	6	protected function getImage()
83		{
84	6	return $this->arrGet($this->data, 'image');
85		}
86
87	33	protected function getName()
88		{
89	33	return $this->arrGet($this->data, 'name');
90		}
91
92	3	protected function getSortName()
93		{
94	3	return $this->arrGet($this->data, 'sort_name');
95		}
96
97	3	protected function getNationalIdentity()
98		{
99	3	return $this->arrGet($this->data, 'national_identity');
100		}
101
102	3	protected function getSummary()
103		{
104	3	return $this->arrGet($this->data, 'summary');
105		}
106
107	3	protected function getBiography()
108		{
109	3	return $this->arrGet($this->data, 'biography');
110		}
111
112	6	protected function getBirthDate()
113		{
114	6	return $this->getDate('birth_date');
115		}
116
117	6	protected function getDeathDate()
118		{
119	6	return $this->getDate('death_date');
120		}
121
122	3	protected function getFamilyName()
123		{
124	3	return $this->arrGet($this->data, 'family_name');
125		}
126
127	3	protected function getGivenName()
128		{
129	3	return $this->arrGet($this->data, 'given_name');
130		}
131
132	3	protected function getWikidata()
133		{
134	3	return $this->identifierValue('wikidata');
135		}
136
137	9	protected function getTwitter()
138		{
139	9	$usernameOrUrl = $this->contactDetailValue('twitter') ?: $this->linkValue('twitter');
140	9	if ($usernameOrUrl) {
141	6	return Parse::extractTwitterUsername($usernameOrUrl);
142		}
143	3	return null;
144		}
145
146	6	protected function getTwitterAll()
147		{
148		// The Twitter screen names in contact_details and links will
149		// in most cases be the same, so remove duplicates:
150	6	$allTwitters = [];
151	6	$rawTwitters = $this->contactDetailValues('twitter') + $this->linkValues('twitter');
152	6	foreach ($rawTwitters as $rawTwitter) {
153	6	$twitter = Parse::extractTwitterUsername($rawTwitter);
154	6	if (!in_array($twitter, $allTwitters)) {
155	6	$allTwitters[] = $twitter;
156	2	}
157	2	}
158	6	return $allTwitters;
159		}
160
161	3	protected function getPhone()
162		{
163	3	return $this->contactDetailValue('phone');
164		}
165
166	3	protected function getPhoneAll()
167		{
168	3	return $this->contactDetailValues('phone');
169		}
170
171	3	protected function getFacebook()
172		{
173	3	return $this->linkValue('facebook');
174		}
175
176	3	protected function getFacebookAll()
177		{
178	3	return $this->linkValues('facebook');
179		}
180
181	3	protected function getFax()
182		{
183	3	return $this->contactDetailValue('fax');
184		}
185
186	3	protected function getFaxAll()
187		{
188	3	return $this->contactDetailValues('fax');
189		}
190
191	3	protected function getLinks()
192		{
193	3	return $this->getRelatedObjectArr('links');
194		}
195
196	3	protected function getContactDetails()
197		{
198	3	return $this->getRelatedObjectArr('contact_details');
199		}
200
201	3	protected function getIdentifiers()
202		{
203	3	return $this->getRelatedObjectArr('identifiers');
204		}
205
206	3	protected function getImages()
207		{
208	3	return $this->getRelatedObjectArr('images');
209		}
210
211	21	protected function getOtherNames()
212		{
213	21	return $this->getRelatedObjectArr('other_names');
214		}
215
216	3	protected function getSources()
217		{
218	3	return $this->getRelatedObjectArr('sources');
219		}
220
221	3	protected function getMemberships()
222		{
223	3	$memberships = [];
224	3	foreach ($this->allPopolo->memberships as $m) {
225	3	if ($m->personId == $this->id) {
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<EveryPolitician\E...nPopolo\Objects\Person>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
226	3	$memberships[] = $m;
227	1	}
228	1	}
229	3	return $memberships;
230		}
231
232	9	private function isNameCurrentAt($name, $dateStr)
233		{
234	9	$startRange = $this->arrGet($name, 'start_date') ?: '0001-01-01';
235	9	$endRange = $this->arrGet($name, 'end_date') ?: '9999-12-31';
236	9	return $dateStr >= $startRange && $dateStr <= $endRange;
237		}
238
239	15	public function nameAt($particularDate)
240		{
241	15	$historicNames = [];
242	15	foreach ($this->otherNames as $otherName) {
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `otherNames` does not exist on `object<EveryPolitician\E...nPopolo\Objects\Person>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
243	12	if (array_key_exists('end_date', $otherName)) {
244	11	$historicNames[] = $otherName;
245	3	}
246	5	}
247	15	if (empty($historicNames)) {
248	6	return $this->name;
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<EveryPolitician\E...nPopolo\Objects\Person>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
249		}
250	9	$namesAtDate = [];
251	9	foreach ($historicNames as $n) {
252	9	if ($this->isNameCurrentAt($n, $particularDate->format('Y-m-d'))) {
253	8	$namesAtDate[] = $n;
254	2	}
255	3	}
256	9	if (empty($namesAtDate)) {
257	3	return $this->name;
		0 ignored issues – show Documentation introduced 2016-12-12 02:27 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<EveryPolitician\E...nPopolo\Objects\Person>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
258		}
259	6	if (count($namesAtDate) > 1) {
260	3	$msg = 'Multiple names for '.(string) $this;
261	3	$msg .= ' found at date '.$particularDate->format('Y-m-d');
262	3	throw new Exception($msg);
263		}
264	3	return $namesAtDate[0]['name'];
265		}
266		}
267

andylolz / everypolitician-popolo-php

Person B last analyzed 2016-12-14 12:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

34 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like

Person B
last analyzed 2016-12-14 12:42 UTC