View GitHub Repository everypolitician-php

Schedule Inspection
Subscribe
Completed
Push — master ( c1b78a...571de1 )
by Andy
02:15
created

Legislature::__construct()   A

↳ Parent: Legislature

Complexity

Conditions 3
Paths 3

Size

Total Lines 11
Code Lines 8

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 10
CRAP Score 3

Importance

Changes 0
Metric Value
dl 0
loc 11
ccs 10
cts 10
cp 1
rs 9.4285
c 0
b 0
f 0
cc 3
eloc 8
nc 3
nop 2
crap 3
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace EveryPolitician\EveryPolitician;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
class Legislature

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
    public $name;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    public $slug;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
    public $personCount;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    public $sha;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
    public $statementCount;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
    public $popoloUrl;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    protected $legislatureData;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
    protected $country;

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    16
                

                                    
                             6                         
                
                
                
    public function __construct($legislatureData, $country)

            


            
                                                                        
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
    {

            


            
                                                                        
                            
            
                                    
            
            

                
                    18
                

                                    
                             6                         
                
                
                
        $properties = ['name', 'slug', 'personCount', 'sha', 'statementCount', 'popoloUrl'];

            


            
                                                                        
                            
            
                                    
            
            

                
                    19
                

                                    
                             6                         
                
                
                
        foreach ($properties as $k) {

            


            
                                                                        
                            
            
                                    
            
            

                
                    20
                

                                    
                             6                         
                
                
                
            $this->$k = array_key_exists($k, $legislatureData) ? $legislatureData[$k] : null;

            


            
                                                                        
                            
            
                                    
            
            

                
                    21
                

                                    
                             4                         
                
                
                
        }

            


            
                                                                        
                            
            
                                    
            
            

                
                    22
                

                                    
                             6                         
                
                
                
        $timestamp = $legislatureData['lastmod'];

            


            
                                                                        
                            
            
                                    
            
            

                
                    23
                

                                    
                             6                         
                
                
                
        $this->lastmod = \DateTime::createFromFormat('U', $timestamp);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The property lastmod does not exist. Did you maybe forget to declare it?
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
In PHP it is possible to write to properties without declaring them. For example,
the following is perfectly valid PHP code:


class MyClass { }

$x = new MyClass();
$x->foo = true;





Generally, it is a good practice to explictly declare properties to avoid
accidental typos and provide IDE auto-completion:


class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;





                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                        
                            
            
                                    
            
            

                
                    24
                

                                    
                             6                         
                
                
                
        $this->legislatureData = $legislatureData;

            


            
                                                                        
                            
            
                                    
            
            

                
                    25
                

                                    
                             6                         
                
                
                
        $this->country = $country;

            


            
                                                                        
                            
            
                                    
            
            

                
                    26
                

                                    
                             6                         
                
                
                
    }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    29