ElasticEntityManager - Code Metrics - Inspection of "Refactoring use of Parser for query construction" - andsalves/doctrine-elastic - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f769c2...a53f28 )

by Anderson

created 2017-09-09 06:49 UTC

ElasticEntityManager B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	260
Duplicated Lines	0 %

Coupling/Cohesion

Components	4
Dependencies	13

Importance

Changes

Metric	Value
wmc	48
lcom	4
cbo	13
dl	0
loc	260
rs	8.4864
c	0
b	0
f	0

43 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	registerEventsListeners()	21	1
A	getUnitOfWork()	3	1
A	getRepository()	3	1
A	getReference()	11	2
A	find()	3	1
A	getCache()	3	1
A	getConnection()	3	1
A	getExpressionBuilder()	7	2
A	beginTransaction()	3	1
A	transactional()	3	1
A	commit()	3	1
A	rollback()	3	1
A	createQuery()	9	2
A	createNamedQuery()	3	1
A	createNativeQuery()	3	1
A	createNamedNativeQuery()	3	1
A	createQueryBuilder()	3	1
A	getPartialReference()	3	1
A	close()	3	1
A	copy()	3	1
A	lock()	3	1
A	getEventManager()	7	2
A	getConfiguration()	3	1
A	isOpen()	3	1
A	getHydrator()	3	1
A	newHydrator()	3	1
A	getProxyFactory()	3	1
A	getFilters()	3	1
A	isFiltersStateClean()	3	1
A	hasFilters()	3	1
A	persist()	3	1
A	remove()	3	1
A	merge()	3	1
A	clear()	3	1
A	detach()	3	1
A	refresh()	3	1
A	flush()	3	1
A	getMetadataFactory()	3	1
A	initializeObject()	3	1
A	contains()	3	1
A	getAnnotationDriver()	7	2
A	getClassMetadata()	9	1

How to fix Complexity

<?php

namespace DoctrineElastic;

use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\EventManager;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Query\Expr;
use Doctrine\ORM\Query\ResultSetMapping;
use DoctrineElastic\Connection\ElasticConnection;
use DoctrineElastic\Elastic\DoctrineElasticEvents;
use DoctrineElastic\Elastic\ElasticQuery;
use DoctrineElastic\Elastic\ElasticQueryBuilder;
use DoctrineElastic\Listener\DeleteListener;
use DoctrineElastic\Listener\InsertListener;
use DoctrineElastic\Listener\QueryListener;
use DoctrineElastic\Listener\UpdateListener;
use DoctrineElastic\Mapping\Driver\ElasticAnnotationDriver;
use DoctrineElastic\Repository\ElasticRepositoryManager;

/**
 * ElasticEntityManager - leading class for all
 *
 * @author Andsalves <[email protected]>
 */
class ElasticEntityManager implements EntityManagerInterface {

    /** @var ElasticRepositoryManager */
    protected $repositoryManager;

    /** @var Configuration */
    protected $config;

    /** @var EventManager */
    protected $eventManager;

    /** @var ElasticUnitOfWork */
    protected $unitOfWork;

    /** @var Expr */
    protected $expressionBuilder;

    /** @var ElasticConnection */
    protected $conn;

    /** @var ElasticAnnotationDriver */
    private $annotationDriver;

    public function __construct(ElasticConnection $connection, EventManager $eventManager = null) {
        $this->eventManager = $eventManager;
        $this->conn = $connection;

        $this->repositoryManager = new ElasticRepositoryManager();
        $this->unitOfWork = new ElasticUnitOfWork($this);
        $this->registerEventsListeners();
    }

    private function registerEventsListeners() {
        $this->getEventManager()->addEventListener(array(
            DoctrineElasticEvents::beforeInsert,
            DoctrineElasticEvents::postInsert,
        ), new InsertListener());

        $this->getEventManager()->addEventListener(array(
            DoctrineElasticEvents::beforeDelete,
            DoctrineElasticEvents::postDelete,
        ), new DeleteListener());

        $this->getEventManager()->addEventListener(array(
            DoctrineElasticEvents::beforeDelete,
            DoctrineElasticEvents::postDelete,
        ), new UpdateListener());

        $this->getEventManager()->addEventListener(array(
            DoctrineElasticEvents::beforeQuery,
            DoctrineElasticEvents::postQuery,
        ), new QueryListener());
    }

    /**
     * @return ElasticUnitOfWork
     */
    public function getUnitOfWork() {
        return $this->unitOfWork;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getRepository($className) {
        return $this->repositoryManager->getRepository($this, $className);
    }

    public function getReference($entityName, $id) {
        if (!is_array($id)) {
            $criteria = ['_id' => $id];
        } else {
            $criteria = $id;
        }

        $persister = $this->getUnitOfWork()->getEntityPersister($entityName);

        return $persister->load($criteria);
    }

    public function find($entityName, $id, $lockMode = null, $lockVersion = null) {
        return $this->getReference($entityName, $id);
    }

    public function getCache() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    /**
     * @return ElasticConnection
     */
    public function getConnection() {
        return $this->conn;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getExpressionBuilder() {
        if ($this->expressionBuilder === null) {
            $this->expressionBuilder = new Expr();
        }

        return $this->expressionBuilder;
    }

    public function beginTransaction() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function transactional($func) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function commit() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function rollback() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function createQuery($dql = '') {
        $query = new ElasticQuery($this);

        if (!empty($dql)) {
            $query->setDQL($dql);
        }

        return $query;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function createNamedQuery($name) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function createNativeQuery($sql, ResultSetMapping $rsm) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function createNamedNativeQuery($name) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function createQueryBuilder() {
        return new ElasticQueryBuilder($this);
    }

    public function getPartialReference($entityName, $identifier) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function close() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function copy($entity, $deep = false) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function lock($entity, $lockMode, $lockVersion = null) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function getEventManager() {
        if (is_null($this->eventManager)) {
            $this->eventManager = new EventManager();
        }

        return $this->eventManager;
    }

    public function getConfiguration() {
        return [];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function isOpen() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function getHydrator($hydrationMode) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function newHydrator($hydrationMode = null) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function getProxyFactory() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function getFilters() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function isFiltersStateClean() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function hasFilters() {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function persist($object) {
        return $this->unitOfWork->persist($object);
    }

    public function remove($object) {
        return $this->unitOfWork->delete($object);
    }

    public function merge($object) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function clear($objectName = null) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function detach($object) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function refresh($object) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function flush($entity = null) {
        $this->getUnitOfWork()->commit($entity);
    }

    public function getMetadataFactory() {
        trigger_error(__METHOD__ . ' method not supported. ');
    }

    public function initializeObject($obj) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    public function contains($object) {
        trigger_error(__METHOD__ . ' method is not supported. ');
    }

    private function getAnnotationDriver(AnnotationReader $annotationReader = null) {
        if (is_null($this->annotationDriver)) {
            $this->annotationDriver = new ElasticAnnotationDriver($annotationReader);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
        }

        return $this->annotationDriver;
    }

    /**
     * @param string $className
     * @return ClassMetadata
     */
    public function getClassMetadata($className) {
        $metadata = new ClassMetadata($className);

        $this->getAnnotationDriver(
            $this->getUnitOfWork()->getEntityPersister($className)->getAnnotionReader()
        )->loadMetadataForClass($className, $metadata);

        return $metadata;
    }
}

GitHub Access Token became invalid

Push — master ( f769c2...a53f28 )

ElasticEntityManager B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

43 Methods

How to fix Complexity

Complex Class

1			<?php
2
3			namespace DoctrineElastic;
4
5			use Doctrine\Common\Annotations\AnnotationReader;
6			use Doctrine\Common\EventManager;
7			use Doctrine\ORM\Configuration;
8			use Doctrine\ORM\EntityManagerInterface;
9			use Doctrine\ORM\Mapping\ClassMetadata;
10			use Doctrine\ORM\Query\Expr;
11			use Doctrine\ORM\Query\ResultSetMapping;
12			use DoctrineElastic\Connection\ElasticConnection;
13			use DoctrineElastic\Elastic\DoctrineElasticEvents;
14			use DoctrineElastic\Elastic\ElasticQuery;
15			use DoctrineElastic\Elastic\ElasticQueryBuilder;
16			use DoctrineElastic\Listener\DeleteListener;
17			use DoctrineElastic\Listener\InsertListener;
18			use DoctrineElastic\Listener\QueryListener;
19			use DoctrineElastic\Listener\UpdateListener;
20			use DoctrineElastic\Mapping\Driver\ElasticAnnotationDriver;
21			use DoctrineElastic\Repository\ElasticRepositoryManager;
22
23			/**
24			* ElasticEntityManager - leading class for all
25			*
26			* @author Andsalves <[email protected]>
27			*/
28			class ElasticEntityManager implements EntityManagerInterface {
29
30			/** @var ElasticRepositoryManager */
31			protected $repositoryManager;
32
33			/** @var Configuration */
34			protected $config;
35
36			/** @var EventManager */
37			protected $eventManager;
38
39			/** @var ElasticUnitOfWork */
40			protected $unitOfWork;
41
42			/** @var Expr */
43			protected $expressionBuilder;
44
45			/** @var ElasticConnection */
46			protected $conn;
47
48			/** @var ElasticAnnotationDriver */
49			private $annotationDriver;
50
51			public function __construct(ElasticConnection $connection, EventManager $eventManager = null) {
52			$this->eventManager = $eventManager;
53			$this->conn = $connection;
54
55			$this->repositoryManager = new ElasticRepositoryManager();
56			$this->unitOfWork = new ElasticUnitOfWork($this);
57			$this->registerEventsListeners();
58			}
59
60			private function registerEventsListeners() {
61			$this->getEventManager()->addEventListener(array(
62			DoctrineElasticEvents::beforeInsert,
63			DoctrineElasticEvents::postInsert,
64			), new InsertListener());
65
66			$this->getEventManager()->addEventListener(array(
67			DoctrineElasticEvents::beforeDelete,
68			DoctrineElasticEvents::postDelete,
69			), new DeleteListener());
70
71			$this->getEventManager()->addEventListener(array(
72			DoctrineElasticEvents::beforeDelete,
73			DoctrineElasticEvents::postDelete,
74			), new UpdateListener());
75
76			$this->getEventManager()->addEventListener(array(
77			DoctrineElasticEvents::beforeQuery,
78			DoctrineElasticEvents::postQuery,
79			), new QueryListener());
80			}
81
82			/**
83			* @return ElasticUnitOfWork
84			*/
85			public function getUnitOfWork() {
86			return $this->unitOfWork;
			0 ignored issues – show Bug Best Practice introduced 2017-08-07 14:53 UTC by Report Bug Copy Issue Report The return type of `return $this->unitOfWork;` (`DoctrineElastic\ElasticUnitOfWork`) is incompatible with the return type declared by the interface `Doctrine\ORM\EntityManagerInterface::getUnitOfWork` of type `Doctrine\ORM\UnitOfWork`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
87			}
88
89			public function getRepository($className) {
90			return $this->repositoryManager->getRepository($this, $className);
91			}
92
93			public function getReference($entityName, $id) {
94			if (!is_array($id)) {
95			$criteria = ['_id' => $id];
96			} else {
97			$criteria = $id;
98			}
99
100			$persister = $this->getUnitOfWork()->getEntityPersister($entityName);
101
102			return $persister->load($criteria);
103			}
104
105			public function find($entityName, $id, $lockMode = null, $lockVersion = null) {
106			return $this->getReference($entityName, $id);
107			}
108
109			public function getCache() {
110			trigger_error(__METHOD__ . ' method is not supported. ');
111			}
112
113			/**
114			* @return ElasticConnection
115			*/
116			public function getConnection() {
117			return $this->conn;
			0 ignored issues – show Bug Best Practice introduced 2017-08-07 14:53 UTC by Report Bug Copy Issue Report The return type of `return $this->conn;` (`DoctrineElastic\Connection\ElasticConnection`) is incompatible with the return type declared by the interface `Doctrine\ORM\EntityManagerInterface::getConnection` of type `Doctrine\DBAL\Connection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
118			}
119
120			public function getExpressionBuilder() {
121			if ($this->expressionBuilder === null) {
122			$this->expressionBuilder = new Expr();
123			}
124
125			return $this->expressionBuilder;
126			}
127
128			public function beginTransaction() {
129			trigger_error(__METHOD__ . ' method is not supported. ');
130			}
131
132			public function transactional($func) {
133			trigger_error(__METHOD__ . ' method is not supported. ');
134			}
135
136			public function commit() {
137			trigger_error(__METHOD__ . ' method is not supported. ');
138			}
139
140			public function rollback() {
141			trigger_error(__METHOD__ . ' method is not supported. ');
142			}
143
144			public function createQuery($dql = '') {
145			$query = new ElasticQuery($this);
146
147			if (!empty($dql)) {
148			$query->setDQL($dql);
149			}
150
151			return $query;
			0 ignored issues – show Bug Best Practice introduced 2017-03-10 23:06 UTC by Report Bug Copy Issue Report The return type of `return $query;` (`DoctrineElastic\Elastic\ElasticQuery`) is incompatible with the return type declared by the interface `Doctrine\ORM\EntityManagerInterface::createQuery` of type `Doctrine\ORM\Query`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
152			}
153
154			public function createNamedQuery($name) {
155			trigger_error(__METHOD__ . ' method is not supported. ');
156			}
157
158			public function createNativeQuery($sql, ResultSetMapping $rsm) {
159			trigger_error(__METHOD__ . ' method is not supported. ');
160			}
161
162			public function createNamedNativeQuery($name) {
163			trigger_error(__METHOD__ . ' method is not supported. ');
164			}
165
166			public function createQueryBuilder() {
167			return new ElasticQueryBuilder($this);
168			}
169
170			public function getPartialReference($entityName, $identifier) {
171			trigger_error(__METHOD__ . ' method is not supported. ');
172			}
173
174			public function close() {
175			trigger_error(__METHOD__ . ' method is not supported. ');
176			}
177
178			public function copy($entity, $deep = false) {
179			trigger_error(__METHOD__ . ' method is not supported. ');
180			}
181
182			public function lock($entity, $lockMode, $lockVersion = null) {
183			trigger_error(__METHOD__ . ' method is not supported. ');
184			}
185
186			public function getEventManager() {
187			if (is_null($this->eventManager)) {
188			$this->eventManager = new EventManager();
189			}
190
191			return $this->eventManager;
192			}
193
194			public function getConfiguration() {
195			return [];
			0 ignored issues – show Bug Best Practice introduced 2017-08-07 14:53 UTC by Report Bug Copy Issue Report The return type of `return array();` (`array`) is incompatible with the return type declared by the interface `Doctrine\ORM\EntityManag...rface::getConfiguration` of type `Doctrine\ORM\Configuration`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
196			}
197
198			public function isOpen() {
199			trigger_error(__METHOD__ . ' method is not supported. ');
200			}
201
202			public function getHydrator($hydrationMode) {
203			trigger_error(__METHOD__ . ' method is not supported. ');
204			}
205
206			public function newHydrator($hydrationMode = null) {
207			trigger_error(__METHOD__ . ' method is not supported. ');
208			}
209
210			public function getProxyFactory() {
211			trigger_error(__METHOD__ . ' method is not supported. ');
212			}
213
214			public function getFilters() {
215			trigger_error(__METHOD__ . ' method is not supported. ');
216			}
217
218			public function isFiltersStateClean() {
219			trigger_error(__METHOD__ . ' method is not supported. ');
220			}
221
222			public function hasFilters() {
223			trigger_error(__METHOD__ . ' method is not supported. ');
224			}
225
226			public function persist($object) {
227			return $this->unitOfWork->persist($object);
228			}
229
230			public function remove($object) {
231			return $this->unitOfWork->delete($object);
232			}
233
234			public function merge($object) {
235			trigger_error(__METHOD__ . ' method is not supported. ');
236			}
237
238			public function clear($objectName = null) {
239			trigger_error(__METHOD__ . ' method is not supported. ');
240			}
241
242			public function detach($object) {
243			trigger_error(__METHOD__ . ' method is not supported. ');
244			}
245
246			public function refresh($object) {
247			trigger_error(__METHOD__ . ' method is not supported. ');
248			}
249
250			public function flush($entity = null) {
251			$this->getUnitOfWork()->commit($entity);
252			}
253
254			public function getMetadataFactory() {
255			trigger_error(__METHOD__ . ' method not supported. ');
256			}
257
258			public function initializeObject($obj) {
259			trigger_error(__METHOD__ . ' method is not supported. ');
260			}
261
262			public function contains($object) {
263			trigger_error(__METHOD__ . ' method is not supported. ');
264			}
265
266			private function getAnnotationDriver(AnnotationReader $annotationReader = null) {
267			if (is_null($this->annotationDriver)) {
268			$this->annotationDriver = new ElasticAnnotationDriver($annotationReader);
			0 ignored issues – show Bug introduced 2017-09-09 06:54 UTC by Report Bug Copy Issue Report It seems like `$annotationReader` defined by parameter `$annotationReader` on line `266` can be `null`; however, `Doctrine\Common\Persiste...onDriver::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
269			}
270
271			return $this->annotationDriver;
272			}
273
274			/**
275			* @param string $className
276			* @return ClassMetadata
277			*/
278			public function getClassMetadata($className) {
279			$metadata = new ClassMetadata($className);
280
281			$this->getAnnotationDriver(
282			$this->getUnitOfWork()->getEntityPersister($className)->getAnnotionReader()
283			)->loadMetadataForClass($className, $metadata);
284
285			return $metadata;
286			}
287			}

andsalves / doctrine-elastic

GitHub Access Token became invalid

Push — master ( f769c2...a53f28 )

ElasticEntityManager B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

43 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like