andreyvolosyuk / simple-eloquent

src/Relations/HasOneOrMany.php

<?php

namespace Volosyuk\SimpleEloquent\Relations;

use Illuminate\Support\Collection;
use Volosyuk\SimpleEloquent\ModelAccessor;

/**
 * @package Volosyuk\SimpleEloquent
 */
trait HasOneOrMany
{
    /**
     * Match the eagerly loaded results to their single parents.
     *
     * @param  array   $models
     * @param  Collection  $results
     * @param  string  $relation
     * @return array
     */
    protected function matchOneSimple(array $models, Collection $results, $relation)
    {
        return $this->matchOneOrManySimple($models, $results, $relation, 'one');
    }

    /**
     * Match the eagerly loaded results to their many parents.
     *
     * @param  array   $models
     * @param  Collection  $results
     * @param  string  $relation
     * @param  string  $type
     * @return array
     */
    protected function matchOneOrManySimple(array &$models, Collection $results, $relation, $type)
    {
        $dictionary = [];

        $foreign = $this->getForeignKeyName();

It seems like getForeignKeyName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($results as $result) {
            $dictionary[ModelAccessor::get($result, $foreign)][] = $result;
        }

        foreach ($models as &$model) {
            $key = ModelAccessor::get($model, $this->localKey);

            if (isset($dictionary[$key])) {
                $value = $this->getRelationValue($dictionary, $key, $type);

It seems like getRelationValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                ModelAccessor::set($model, $relation, $value);
            }
        }
        unset($model);

        return $models;
    }
}