Volosyuk\SimpleEloquent\SimpleEloquent

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	newEloquentBuilder()	0	3	1
A	allSimple()	0	10	2

<?php

namespace Volosyuk\SimpleEloquent;

use Illuminate\Support\Collection;
use stdClass;
use Volosyuk\SimpleEloquent\Relations\HasRelationships;

/**
 * Trait SimpleEloquent
 *
 * @package Volosyuk\SimpleEloquent
 * @authour Volosyuk Andrey <valasiuk.andrei@gmail.com>
 */
trait SimpleEloquent
{
    use HasRelationships;

    /**
     * Create a new Eloquent query builder for the model.
     *
     * @param  Builder  $query
     * @return Builder|static
     */
    public function newEloquentBuilder($query)
    {
        return new Builder($query);

$query of type Volosyuk\SimpleEloquent\Builder is incompatible with the type Illuminate\Database\Query\Builder expected by parameter $query of Volosyuk\SimpleEloquent\Builder::__construct().

    }

    /**
     * Get all of the models from the database.
     *
     * @param  array|mixed  $columns
     * @return Collection|stdClass[]|array
     */
    public static function allSimple($columns = ['*'])
    {
        $columns = is_array($columns) ? $columns : func_get_args();

        /**
         * @var Builder $query
         */
        $query = (new static)->newQuery();

It seems like newQuery() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $query->simple()->get($columns);
    }
}