AbstractInterfaceType::addAdditionalField() - Code Metrics - Inspection of "Merge pull request #30 from andrey-mokhov/improve-..." - andrey-mokhov/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 645e63...6cbe16 )

by Andrey

created 2023-11-07 18:15 UTC

AbstractInterfaceType::addAdditionalField() A

↳ Parent: AbstractInterfaceType

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	5
ccs	3
cts	3
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

namespace Andi\GraphQL\Type;

use Andi\GraphQL\Definition\Field\ObjectFieldInterface;
use Andi\GraphQL\Definition\Type\InterfaceTypeInterface;
use Andi\GraphQL\Exception\CantResolveObjectFieldException;
use Andi\GraphQL\Field\AbstractAnonymousObjectField;
use Andi\GraphQL\Field\AbstractObjectField;
use GraphQL\Type\Definition as Webonyx;

abstract class AbstractInterfaceType extends AbstractType implements InterfaceTypeInterface, DynamicObjectTypeInterface
{
    /**
     * @template A of array{name: string, type: string, typeMode: int, description: string, deprecationReason: string, defaultValue: mixed}
     * @template F of array{name: string, type: string, typeMode: int, description: string, deprecationReason: string, arguments: array<array-key, string|A>}
     *
     * @var iterable<array-key, string|ObjectFieldInterface|Webonyx\FieldDefinition|F>
     */
    protected iterable $fields;

    protected iterable $additionalFields = [];

    public function getFields(): iterable
    {
        foreach ($this->fields ?? [] as $name => $field) {
            if ($field instanceof Webonyx\FieldDefinition || $field instanceof ObjectFieldInterface) {
                yield $field;

                continue;
            }

            if (is_string($field) || is_array($field)) {
                yield $this->getObjectField($name, $field);

                continue;
            }

            throw new CantResolveObjectFieldException(
                'Can\'t resolve ObjectField configuration: unknown field configuration',
            );
        }

        yield from $this->additionalFields;
    }

    public function addAdditionalField(mixed $field): static
    {
        $this->additionalFields[] = $field;

        return $this;
    }

    private function getObjectField(int|string $name, string|array $field): AbstractObjectField
    {
        $fieldName = $field['name'] ?? $name;

        if (! is_string($fieldName)) {
            throw new CantResolveObjectFieldException('Can\'t resolve ObjectField configuration: undefined name');
        }

        if (is_string($field)) {

            return $this->makeObjectField($fieldName, ['type' => $field]);
        }

        if (is_array($field)) {

            if (! isset($field['type']) || ! is_string($field['type'])) {
                throw new CantResolveObjectFieldException(
                    'Can\'t resolve ObjectField configuration: undefined type',
                );
            }

            return $this->makeObjectField($fieldName, $field);
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    private function makeObjectField(string $name, array $field): AbstractObjectField
    {
        return new class($name, $field) extends AbstractAnonymousObjectField {};
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Andi\GraphQL\Type;
6
7		use Andi\GraphQL\Definition\Field\ObjectFieldInterface;
8		use Andi\GraphQL\Definition\Type\InterfaceTypeInterface;
9		use Andi\GraphQL\Exception\CantResolveObjectFieldException;
10		use Andi\GraphQL\Field\AbstractAnonymousObjectField;
11		use Andi\GraphQL\Field\AbstractObjectField;
12		use GraphQL\Type\Definition as Webonyx;
13
14		abstract class AbstractInterfaceType extends AbstractType implements InterfaceTypeInterface, DynamicObjectTypeInterface
15		{
16		/**
17		* @template A of array{name: string, type: string, typeMode: int, description: string, deprecationReason: string, defaultValue: mixed}
18		* @template F of array{name: string, type: string, typeMode: int, description: string, deprecationReason: string, arguments: array<array-key, string\|A>}
19		*
20		* @var iterable<array-key, string\|ObjectFieldInterface\|Webonyx\FieldDefinition\|F>
21		*/
22		protected iterable $fields;
23
24		protected iterable $additionalFields = [];
25
26	7	public function getFields(): iterable
27		{
28	7	foreach ($this->fields ?? [] as $name => $field) {
29	6	if ($field instanceof Webonyx\FieldDefinition \|\| $field instanceof ObjectFieldInterface) {
30	1	yield $field;
31
32	1	continue;
33		}
34
35	5	if (is_string($field) \|\| is_array($field)) {
36	4	yield $this->getObjectField($name, $field);
37
38	2	continue;
39		}
40
41	1	throw new CantResolveObjectFieldException(
42	1	'Can\'t resolve ObjectField configuration: unknown field configuration',
43	1	);
44		}
45
46	4	yield from $this->additionalFields;
47		}
48
49	1	public function addAdditionalField(mixed $field): static
50		{
51	1	$this->additionalFields[] = $field;
52
53	1	return $this;
54		}
55
56	4	private function getObjectField(int\|string $name, string\|array $field): AbstractObjectField
57		{
58	4	$fieldName = $field['name'] ?? $name;
59
60	4	if (! is_string($fieldName)) {
61	1	throw new CantResolveObjectFieldException('Can\'t resolve ObjectField configuration: undefined name');
62		}
63
64	3	if (is_string($field)) {
		0 ignored issues – show introduced 2023-11-07 18:10 UTC by Report Bug Copy Issue Report The condition `is_string($field)` is always `false`. Loading history...
65	1	return $this->makeObjectField($fieldName, ['type' => $field]);
66		}
67
68	2	if (is_array($field)) {
		0 ignored issues – show introduced 2023-11-07 18:10 UTC by Report Bug Copy Issue Report The condition `is_array($field)` is always `true`. Loading history...
69	2	if (! isset($field['type']) \|\| ! is_string($field['type'])) {
70	1	throw new CantResolveObjectFieldException(
71	1	'Can\'t resolve ObjectField configuration: undefined type',
72	1	);
73		}
74
75	1	return $this->makeObjectField($fieldName, $field);
76		}
		0 ignored issues – show Bug Best Practice introduced 2023-11-07 18:10 UTC by Report Bug Copy Issue Report The function implicitly returns `null` when the `if` condition on line 68 is `false`. This is incompatible with the type-hinted return `Andi\GraphQL\Field\AbstractObjectField`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
77		}
78
79	2	private function makeObjectField(string $name, array $field): AbstractObjectField
80		{
81	2	return new class($name, $field) extends AbstractAnonymousObjectField {};
82		}
83		}
84

andrey-mokhov / graphql-php

Push — master ( 645e63...6cbe16 )

AbstractInterfaceType::addAdditionalField() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like