Argument::__construct() - Code Metrics - Inspection of "Improve unit test coverage" - andrey-mokhov/graphql-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Andrey

created 2023-11-13 15:48 UTC

Argument::__construct() A

↳ Parent: Argument

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	2
eloc	3
c	1
b	0
f	1
nc	2
nop	6
dl	0
loc	12
ccs	4
cts	4
cp	1
crap	2
rs	10

<?php

declare(strict_types=1);

namespace Andi\GraphQL\Attribute;

use Attribute;
use ReflectionProperty;
use Spiral\Attributes\NamedArgumentConstructor;

#[Attribute(Attribute::TARGET_PARAMETER), NamedArgumentConstructor]
final class Argument extends AbstractDefinition
{
    public readonly mixed $defaultValue;

    public function __construct(
        ?string $name = null,
        ?string $description = null,
        public readonly ?string $type = null,
        public readonly ?int $mode = null,
        public readonly ?string $deprecationReason = null,
        mixed $defaultValue = null,
    ) {
        parent::__construct($name, $description);

        if (func_num_args() >= 6) {
            $this->defaultValue = $defaultValue;

        }
    }

    public function hasDefaultValue(): bool
    {
        return (new ReflectionProperty($this, 'defaultValue'))->isInitialized($this);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Andi\GraphQL\Attribute;
6
7		use Attribute;
8		use ReflectionProperty;
9		use Spiral\Attributes\NamedArgumentConstructor;
10
11		#[Attribute(Attribute::TARGET_PARAMETER), NamedArgumentConstructor]
12		final class Argument extends AbstractDefinition
13		{
14		public readonly mixed $defaultValue;
15
16	3	public function __construct(
17		?string $name = null,
18		?string $description = null,
19		public readonly ?string $type = null,
20		public readonly ?int $mode = null,
21		public readonly ?string $deprecationReason = null,
22		mixed $defaultValue = null,
23		) {
24	3	parent::__construct($name, $description);
25
26	3	if (func_num_args() >= 6) {
27	2	$this->defaultValue = $defaultValue;
		0 ignored issues – show Bug introduced 2023-09-27 08:21 UTC by Report Bug Copy Issue Report The property `defaultValue` is declared read-only in `Andi\GraphQL\Attribute\Argument`. Loading history...
28		}
29		}
30
31	3	public function hasDefaultValue(): bool
32		{
33	3	return (new ReflectionProperty($this, 'defaultValue'))->isInitialized($this);
34		}
35		}
36

andrey-mokhov / graphql-php

Pull Request — master (#38)

Argument::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like