File::delete() - Code Metrics - Inspection of "Upgrade project" - andrey-helldar/support - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#22)

by Andrey

created 2020-12-28 21:19 UTC

File::delete() A

↳ Parent: File

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	4
nop	1
dl	0
loc	18
rs	9.9666
c	0
b	0
f	0

<?php

namespace Helldar\Support\Helpers\Filesystem;

use DirectoryIterator;
use ErrorException;
use Helldar\Support\Facades\Helpers\Arr;
use Helldar\Support\Facades\Helpers\Filesystem\Directory;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Helldar\Support\Facades\Helpers\Instance;
use SplFileInfo;

class File
{
    public function store(string $path, string $content): void
    {
        Directory::make(pathinfo($path, PATHINFO_DIRNAME));

        file_put_contents($path, $content);
    }

    public function exists(string $path): bool
    {
        return file_exists($path) && is_file($path);
    }

    /**
     * @param  string|string[]  $paths
     *
     * @return bool
     */
    public function delete($paths): bool
    {
        $paths = Arr::wrap($paths);

        $success = true;

        foreach ($paths as $path) {
            try {
                if (! @unlink($path)) {
                    $success = false;
                }
            }
            catch (ErrorException $e) {
                $success = false;
            }
        }

        return $success;
    }

    /**
     * @param  \SplFileInfo|\DirectoryIterator|string  $value
     *
     * @return bool
     */
    public function isFile($value): bool
    {
        if (Instance::of($value, [SplFileInfo::class, DirectoryIterator::class])) {
            return $value->isFile();
        }

        return is_file($value);
    }
}


1			<?php
2
3			namespace Helldar\Support\Helpers\Filesystem;
4
5			use DirectoryIterator;
6			use ErrorException;
7			use Helldar\Support\Facades\Helpers\Arr;
8			use Helldar\Support\Facades\Helpers\Filesystem\Directory;
			0 ignored issues – show Bug introduced 2020-12-28 14:58 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Helldar\Support\Helpers\Filesystem\Directory`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9			use Helldar\Support\Facades\Helpers\Instance;
10			use SplFileInfo;
11
12			class File
13			{
14			public function store(string $path, string $content): void
15			{
16			Directory::make(pathinfo($path, PATHINFO_DIRNAME));
17
18			file_put_contents($path, $content);
19			}
20
21			public function exists(string $path): bool
22			{
23			return file_exists($path) && is_file($path);
24			}
25
26			/**
27			* @param string\|string[] $paths
28			*
29			* @return bool
30			*/
31			public function delete($paths): bool
32			{
33			$paths = Arr::wrap($paths);
34
35			$success = true;
36
37			foreach ($paths as $path) {
38			try {
39			if (! @unlink($path)) {
40			$success = false;
41			}
42			}
43			catch (ErrorException $e) {
44			$success = false;
45			}
46			}
47
48			return $success;
49			}
50
51			/**
52			* @param \SplFileInfo\|\DirectoryIterator\|string $value
53			*
54			* @return bool
55			*/
56			public function isFile($value): bool
57			{
58			if (Instance::of($value, [SplFileInfo::class, DirectoryIterator::class])) {
59			return $value->isFile();
60			}
61
62			return is_file($value);
63			}
64			}
65

andrey-helldar / support

Pull Request — main (#22)

File::delete() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like