andrey-helldar / laravel-lang-publisher

src/Support/Path/Json.php

<?php

namespace Helldar\LaravelLangPublisher\Support\Path;

use Helldar\LaravelLangPublisher\Facades\Config;

final class Json extends BasePath
{
    protected $is_json = true;

    /**
     * Returns a direct link to the folder with the source localization files.
     *
     * If the file name is specified, a full link to the file will be returned,
     * otherwise a direct link to the folder.
     *
     * @param  string|null  $locale
     *
     * @return string
     */
    public function source(string $locale = null): string
    {
        $directory = $this->getPathForEnglish($locale);

It seems like $locale can also be of type null; however, parameter $locale of Helldar\LaravelLangPublisher\Support\Path\BasePath::getPathForEnglish() does only seem to accept string, maybe add an additional type check?

        $locale    = $this->clean($locale);

        return $this->real(
            Config::getVendorPath() . $directory . $locale . '.json'
        );
    }

    /**
     * Returns the direct link to the localization folder or,
     * if the file name is specified, a link to the localization file.
     *
     * If the file name or localization is not specified,
     * the link to the shared folder of all localizations will be returned.
     *
     * @param  string|null  $locale
     * @param  string|null  $filename
     *
     * @return string
     */
    public function target(string $locale = null, string $filename = null): string
    {
        $locale = $this->clean($locale);

        return resource_path(self::LANG . $locale . '.json');
    }
}