Helldar\LaravelLangPublisher\Concerns\Ask

Complexity

Total Complexity

11

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	askLocales()	0	5	2
A	getAllLocales()	0	3	1
A	getLocales()	0	7	2
A	selectLocales()	0	3	1
A	resolveSelectedLocales()	0	9	2
A	getMethod()	0	5	1
A	validatedLocales()	0	7	2

<?php

/*
 * This file is part of the "andrey-helldar/laravel-lang-publisher" project.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Andrey Helldar <helldar@ai-rus.com>
 *
 * @copyright 2021 Andrey Helldar
 *
 * @license MIT
 *
 * @see https://github.com/andrey-helldar/laravel-lang-publisher
 */

declare(strict_types=1);

namespace Helldar\LaravelLangPublisher\Concerns;

use Helldar\LaravelLangPublisher\Facades\Helpers\Locales;
use Helldar\Support\Facades\Helpers\Arr;
use Helldar\Support\Facades\Helpers\Str;

trait Ask
{
    protected function getLocales(): array
    {
        if ($locales = $this->argument('locales')) {

It seems like argument() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->resolveSelectedLocales($locales);
        }

        return $this->askLocales($this->getMethod());
    }

    protected function askLocales(string $method): array
    {
        $locales = $this->confirm("Do you want to $method all localizations?") ? $this->getAllLocales() : $this->selectLocales($method);

It seems like confirm() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->resolveSelectedLocales($locales);
    }

    protected function getAllLocales(): array
    {
        return Locales::available();
    }

    protected function selectLocales(string $method)
    {
        return $this->choice("Select localizations to $method (specify the necessary localizations separated by commas):", $this->getAllLocales(), null, null, true);

It seems like choice() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    protected function resolveSelectedLocales($locales): array
    {
        if ($locales === '*') {
            return $this->getAllLocales();
        }

        $locales = Arr::wrap($locales);

        return $this->validatedLocales($locales);
    }

    protected function getMethod(): string
    {
        $name = class_basename(static::class);

        return Str::lower($name);

The expression return Helldar\Support\Facades\Helpers\Str::lower($name) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    protected function validatedLocales(array $locales): array
    {
        foreach ($locales as $locale) {
            Locales::validate($locale);
        }

        return $locales;
    }
}