Localization::copyValidations() - Code Metrics - Inspection of "Big refactoring" - andrey-helldar/laravel-lang-publisher - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a7279d...feb425 )

by Andrey

created 2020-03-04 22:51 UTC

Localization::copyValidations() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	13
c	1
b	0
f	0
dl	0
loc	21
rs	9.8333
cc	1
nc	1
nop	3

<?php

namespace Helldar\LaravelLangPublisher\Services;

use Helldar\LaravelLangPublisher\Contracts\Localization as LocalizationContract;
use Helldar\LaravelLangPublisher\Contracts\Process;
use Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException;
use Helldar\LaravelLangPublisher\Services\Processing\Delete;
use Helldar\LaravelLangPublisher\Services\Processing\Publish;

use function app;

final class Localization implements LocalizationContract
{
    /** @var array */
    protected $result = [];

    /**
     * @param string $locale
     * @param bool $force
     *
     * @return array
     * @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
     */
    public function publish(string $locale, bool $force = false): array
    {
        return $this->process(Publish::class, $locale, $force);
    }

    /**
     * @param string $locale
     *
     * @return array
     * @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
     */
    public function delete(string $locale): array
    {
        return $this->process(Delete::class, $locale);
    }

    /**
     * @param string $classname
     * @param string $locale
     * @param bool $force
     *
     * @return mixed
     * @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
     */
    protected function process(string $classname, string $locale, bool $force = false)
    {
        return $this->makeProcess($classname)
            ->locale($locale)
            ->force($force)
            ->run();
    }

    /**
     * @param string $classname
     *
     * @return \Helldar\LaravelLangPublisher\Contracts\Process
     * @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
     */
    protected function makeProcess(string $classname): Process
    {
        if (! is_subclass_of($classname, Process::class)) {
            throw new NoProcessInstanceException($classname);
        }

        return app($classname);

    }
}


1			<?php
2
3			namespace Helldar\LaravelLangPublisher\Services;
4
5			use Helldar\LaravelLangPublisher\Contracts\Localization as LocalizationContract;
6			use Helldar\LaravelLangPublisher\Contracts\Process;
7			use Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException;
8			use Helldar\LaravelLangPublisher\Services\Processing\Delete;
9			use Helldar\LaravelLangPublisher\Services\Processing\Publish;
10
11			use function app;
12
13			final class Localization implements LocalizationContract
14			{
15			/** @var array */
16			protected $result = [];
17
18			/**
19			* @param string $locale
20			* @param bool $force
21			*
22			* @return array
23			* @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
24			*/
25			public function publish(string $locale, bool $force = false): array
26			{
27			return $this->process(Publish::class, $locale, $force);
28			}
29
30			/**
31			* @param string $locale
32			*
33			* @return array
34			* @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
35			*/
36			public function delete(string $locale): array
37			{
38			return $this->process(Delete::class, $locale);
39			}
40
41			/**
42			* @param string $classname
43			* @param string $locale
44			* @param bool $force
45			*
46			* @return mixed
47			* @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
48			*/
49			protected function process(string $classname, string $locale, bool $force = false)
50			{
51			return $this->makeProcess($classname)
52			->locale($locale)
53			->force($force)
54			->run();
55			}
56
57			/**
58			* @param string $classname
59			*
60			* @return \Helldar\LaravelLangPublisher\Contracts\Process
61			* @throws \Helldar\LaravelLangPublisher\Exceptions\NoProcessInstanceException
62			*/
63			protected function makeProcess(string $classname): Process
64			{
65			if (! is_subclass_of($classname, Process::class)) {
66			throw new NoProcessInstanceException($classname);
67			}
68
69			return app($classname);
			0 ignored issues – show Bug Best Practice introduced 2020-03-04 23:02 UTC by Report Bug Copy Issue Report The expression `return app($classname)` could return the type `Illuminate\Contracts\Foundation\Application` which is incompatible with the type-hinted return `Helldar\LaravelLangPublisher\Contracts\Process`. Consider adding an additional type-check to rule them out. Loading history...
70			}
71			}
72

andrey-helldar / laravel-lang-publisher

Push — master ( a7279d...feb425 )

Localization::copyValidations() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like