Issues in S3Helper.php (master) - Issues in master - andrewfenn/awshelper - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AwsHelper/S3Helper.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace AwsHelper;

use Aws\S3\S3Client;
use Aws\S3\Exception\S3Exception;

class S3Helper
{
    protected $s3;
    protected $adapter;
    protected $bucket_name;
    protected $region;

    public function __construct(AwsHelper $adapter, $bucket_name, $region)
    {
        $this->bucket_name = $bucket_name;
        $this->adapter = $adapter;
        $this->region = $region;
        $this->connect();
    }

    public function connect()
    {
        $this->s3 = S3Client::factory($this->adapter->getDefaultOptions() + ['region' => $this->region]);
    }

    /* When accessing the S3Client you should call this function everytime
    so that you can be sure that the token isn't going to expire on you in the
    middle of a call */
    public function getClient()
    {
        $expirationTime = $this->adapter->getJSON()->Expiration;
        if ($this->adapter->hasAccessExpired($expirationTime)) {
            $this->connect();
        }
        return $this->s3;
    }

    /*
    @param $file_location   The location of the file on your local system
    @param $s3_location     The location of the file you want to upload to s3
    @param $acl             What access the file should have, options are: private,
        public-read, public-read-write, authenticated-read, bucket-owner-read,
        bucket-owner-full-control
    @param $params          Additional parameters you want to pass to S3 client.
    */
    public function saveFile($file_location, $s3_location, $acl = 'private', $params = [])

    {
        if ($this->s3 == null)
            return false;

        $this->getClient();

        try {
            $result = $this->s3->putObject([
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'Bucket'     => $this->bucket_name,
                'Key'        => $s3_location,
                'SourceFile' => $file_location,
                'ACL'        => $acl,
            ] + $params);
        } catch (\Exception $e) {
            return false;
        }
    }

    /*
    @param $file_content    The file content to upload to s3
    @param $s3_location     The location of the file you want to upload to s3
    @param $acl             What access the file should have, options are: private,
        public-read, public-read-write, authenticated-read, bucket-owner-read,
        bucket-owner-full-control
    @param $params          Additional parameters you want to pass to S3 client.
    */
    public function saveFileContent($file_content, $s3_location, $acl = 'private', $params = [])

    {
        if ($this->s3 == null)
            return false;

        $this->getClient();

        try {
            $result = $this->s3->putObject([
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'Bucket'     => $this->bucket_name,
                'Key'        => $s3_location,
                'Body'       => $file_content,
                'ACL'        => $acl,
            ] + $params);
        } catch (\Exception $e) {
            return false;
        }
    }

    /*
    @param  $s3_location the location of the file on s3
    @return A pointer to a temporary file that is deleted upon script exit
        or false if error
    */
    public function getFile($s3_location)
    {
        if ($this->s3 == null)
            return false;

        $this->getClient();

        try {
            $result = $this->s3->getObject([
                'Bucket' => $this->bucket_name,
                'Key'    => $s3_location,
            ]);
        }
        catch (\Exception $e)
        {
            return false;
        }

        $result['Body']->rewind();
        $temp_file = tmpfile();
        while ($data = $result['Body']->read(1024)) {
            fwrite($temp_file, $data);
        }

        fseek($temp_file, 0);
        return $temp_file;
    }
}


1		<?php namespace AwsHelper;
2
3		use Aws\S3\S3Client;
4		use Aws\S3\Exception\S3Exception;
5
6		class S3Helper
7		{
8		protected $s3;
9		protected $adapter;
10		protected $bucket_name;
11		protected $region;
12
13		public function __construct(AwsHelper $adapter, $bucket_name, $region)
14		{
15		$this->bucket_name = $bucket_name;
16		$this->adapter = $adapter;
17		$this->region = $region;
18		$this->connect();
19		}
20
21		public function connect()
22		{
23		$this->s3 = S3Client::factory($this->adapter->getDefaultOptions() + ['region' => $this->region]);
24		}
25
26		/* When accessing the S3Client you should call this function everytime
27		so that you can be sure that the token isn't going to expire on you in the
28		middle of a call */
29		public function getClient()
30		{
31		$expirationTime = $this->adapter->getJSON()->Expiration;
32		if ($this->adapter->hasAccessExpired($expirationTime)) {
33		$this->connect();
34		}
35		return $this->s3;
36		}
37
38		/*
39		@param $file_location The location of the file on your local system
40		@param $s3_location The location of the file you want to upload to s3
41		@param $acl What access the file should have, options are: private,
42		public-read, public-read-write, authenticated-read, bucket-owner-read,
43		bucket-owner-full-control
44		@param $params Additional parameters you want to pass to S3 client.
45		*/
46	View Code Duplication	public function saveFile($file_location, $s3_location, $acl = 'private', $params = [])
		0 ignored issues – show Duplication introduced 2016-08-31 03:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		if ($this->s3 == null)
49		return false;
50
51		$this->getClient();
52
53		try {
54		$result = $this->s3->putObject([
		0 ignored issues – show Unused Code introduced 2016-08-31 03:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55		'Bucket' => $this->bucket_name,
56		'Key' => $s3_location,
57		'SourceFile' => $file_location,
58		'ACL' => $acl,
59		] + $params);
60		} catch (\Exception $e) {
61		return false;
62		}
63		}
64
65		/*
66		@param $file_content The file content to upload to s3
67		@param $s3_location The location of the file you want to upload to s3
68		@param $acl What access the file should have, options are: private,
69		public-read, public-read-write, authenticated-read, bucket-owner-read,
70		bucket-owner-full-control
71		@param $params Additional parameters you want to pass to S3 client.
72		*/
73	View Code Duplication	public function saveFileContent($file_content, $s3_location, $acl = 'private', $params = [])
		0 ignored issues – show Duplication introduced 2016-08-31 03:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		if ($this->s3 == null)
76		return false;
77
78		$this->getClient();
79
80		try {
81		$result = $this->s3->putObject([
		0 ignored issues – show Unused Code introduced 2016-08-31 03:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
82		'Bucket' => $this->bucket_name,
83		'Key' => $s3_location,
84		'Body' => $file_content,
85		'ACL' => $acl,
86		] + $params);
87		} catch (\Exception $e) {
88		return false;
89		}
90		}
91
92		/*
93		@param $s3_location the location of the file on s3
94		@return A pointer to a temporary file that is deleted upon script exit
95		or false if error
96		*/
97		public function getFile($s3_location)
98		{
99		if ($this->s3 == null)
100		return false;
101
102		$this->getClient();
103
104		try {
105		$result = $this->s3->getObject([
106		'Bucket' => $this->bucket_name,
107		'Key' => $s3_location,
108		]);
109		}
110		catch (\Exception $e)
111		{
112		return false;
113		}
114
115		$result['Body']->rewind();
116		$temp_file = tmpfile();
117		while ($data = $result['Body']->read(1024)) {
118		fwrite($temp_file, $data);
119		}
120
121		fseek($temp_file, 0);
122		return $temp_file;
123		}
124		}
125

andrewfenn / awshelper

Issues (10)

Security Analysis no request data

src/AwsHelper/S3Helper.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like