RealWorldTest::testConsolidateSubnetsVerbose() - Code Metrics - Inspection of "introduce verbose methods, add real-world-esque te..." - andrewandante/submuncher - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#6)

by Andrew

created 2018-03-09 17:12 UTC

RealWorldTest::testConsolidateSubnetsVerbose() A

↳ Parent: RealWorldTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	11
rs	9.4285
c	1
b	0
f	1
cc	1
eloc	6
nc	1
nop	0

<?php

namespace AndrewAndante\SubMuncher\Test;

use AndrewAndante\SubMuncher\SubMuncher;

class RealWorldTest extends \PHPUnit_Framework_TestCase
{
    private $json_data;

    protected function setUp()
    {
        parent::setUp();
        $this->json_data = json_decode(file_get_contents(__DIR__ . '/../data/real_world_data.json'), true);
    }

    public function testConsolidateSubnets()
    {
        $this->assertEquals(
            $this->json_data['consolidated_subnets'],
            SubMuncher::consolidate_subnets($this->json_data['subnets'])
        );
    }

    public function testConsolidateSubnetsVerbose()
    {
        $this->assertEquals(
            [
                'consolidated_subnets' => $this->json_data['consolidated_subnets'],
                'initial_IPs' => $this->json_data['raw_ips'],
                'total_IPs' => $this->json_data['raw_ips'],
            ],
            SubMuncher::consolidate_subnets_verbose($this->json_data['subnets'])
        );
    }

    public function testConsolidateSubnetsVerboseWithMaxRules()
    {
        $result = SubMuncher::consolidate_subnets_verbose($this->json_data['subnets'], 25);
        $this->assertCount(25, $result['consolidated_subnets']);
        $this->assertEquals($this->json_data['raw_ips'], $result['initial_IPs']);
        $this->assertGreaterThanOrEqual(count($this->json_data['raw_ips']), count($result['total_IPs']));

        foreach ($this->json_data['raw_ips'] as $raw_ip) {
            $this->assertContains($raw_ip, $result['total_IPs']);
        }
    }
}


1			<?php
2
3			namespace AndrewAndante\SubMuncher\Test;
4
5			use AndrewAndante\SubMuncher\SubMuncher;
6
7			class RealWorldTest extends \PHPUnit_Framework_TestCase
8			{
9			private $json_data;
10
11			protected function setUp()
12			{
13			parent::setUp();
14			$this->json_data = json_decode(file_get_contents(__DIR__ . '/../data/real_world_data.json'), true);
15			}
16
17			public function testConsolidateSubnets()
18			{
19			$this->assertEquals(
20			$this->json_data['consolidated_subnets'],
21			SubMuncher::consolidate_subnets($this->json_data['subnets'])
22			);
23			}
24
25			public function testConsolidateSubnetsVerbose()
26			{
27			$this->assertEquals(
28			[
29			'consolidated_subnets' => $this->json_data['consolidated_subnets'],
30			'initial_IPs' => $this->json_data['raw_ips'],
31			'total_IPs' => $this->json_data['raw_ips'],
32			],
33			SubMuncher::consolidate_subnets_verbose($this->json_data['subnets'])
34			);
35			}
36
37			public function testConsolidateSubnetsVerboseWithMaxRules()
38			{
39			$result = SubMuncher::consolidate_subnets_verbose($this->json_data['subnets'], 25);
40			$this->assertCount(25, $result['consolidated_subnets']);
41			$this->assertEquals($this->json_data['raw_ips'], $result['initial_IPs']);
42			$this->assertGreaterThanOrEqual(count($this->json_data['raw_ips']), count($result['total_IPs']));
43
44			foreach ($this->json_data['raw_ips'] as $raw_ip) {
45			$this->assertContains($raw_ip, $result['total_IPs']);
46			}
47			}
48			}
49

andrewandante / submuncher

Pull Request — master (#6)

RealWorldTest::testConsolidateSubnetsVerbose() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like