AndrewAndante\SubMuncher\Test\RealWorldTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testConsolidateSubnetsPerformance()	0	5	1
A	setUp()	0	5	1
A	testConsolidateSubnets()	0	7	1
A	testConsolidateSubnetsVerbose()	0	11	1
B	testConsolidateSubnetsWithMaxRules()	0	17	5

<?php

namespace AndrewAndante\SubMuncher\Test;

use AndrewAndante\SubMuncher\SubMuncher;
use AndrewAndante\SubMuncher\Util;

class RealWorldTest extends \PHPUnit_Framework_TestCase
{
    private $json_data;

    protected function setUp()
    {
        parent::setUp();
        $this->json_data = json_decode(file_get_contents(__DIR__ . '/../data/real_world_data.json'), true);
    }

    public function testConsolidateSubnets()
    {
        $this->assertEquals(
            $this->json_data['consolidated_subnets'],
            SubMuncher::consolidate_subnets($this->json_data['subnets'])
        );
    }

    public function testConsolidateSubnetsVerbose()
    {
        $this->assertEquals(
            [
                'consolidated_subnets' => $this->json_data['consolidated_subnets'],
                'initial_IPs' => $this->json_data['raw_ips'],
                'total_IPs' => $this->json_data['raw_ips'],
            ],
            SubMuncher::consolidate_subnets_verbose($this->json_data['subnets'])
        );
    }

    public function testConsolidateSubnetsPerformance()
    {
        $result = SubMuncher::consolidate_subnets($this->json_data['subnets'], 1);
        $this->assertLessThanOrEqual(1, count($result));
    }

    public function testConsolidateSubnetsWithMaxRules()
    {
        $result = SubMuncher::consolidate_subnets($this->json_data['subnets'], 25);
        $fail = true;
        foreach ($this->json_data['raw_ips'] as $ip) {
            foreach ($result as $subnet) {
                if (Util::cidr_contains($subnet, $ip)) {
                    $fail = false;
                    break;
                }
            }
        }

        if ($fail) {
            $this->fail($ip . " not contained in any subnets returned");

The variable $ip seems to be defined by a foreach iteration on line 48. Are you sure the iterator is never empty, otherwise this variable is not defined?

        }
    }
}