AuditSns::toAwsSnsTopic() - Code Metrics - Inspection of "Added the ability to queue the notification." - andreshg112/laravel-auditing-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8049c5...c740e0 )

by Andrés

created 2019-04-11 21:37 UTC

AuditSns::toAwsSnsTopic() A

↳ Parent: AuditSns

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	9
cts	9
cp	1
rs	9.7666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace Andreshg112\LaravelAuditingNotifications;

use Illuminate\Support\Facades\Config;
use Lab123\AwsSns\Messages\AwsSnsMessage;
use Illuminate\Notifications\Notification;
use Lab123\AwsSns\Channels\AwsSnsTopicChannel;
use OwenIt\Auditing\Exceptions\AuditingException;

class AuditSns extends Notification
{
    /** @var array $auditData */
    protected $auditData = null;

    /**
     * Create a new notification instance.
     *
     * @param array $auditData
     */
    public function __construct(array $auditData)
    {
        $this->auditData = $auditData;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  \OwenIt\Auditing\Contracts\Auditable  $notifiable
     * @return array
     */
    public function via($notifiable)

    {
        return [AwsSnsTopicChannel::class];
    }

    /**
     * Get the SNS representation of the notification.
     *
     * @param  \OwenIt\Auditing\Contracts\Auditable  $notifiable
     * @return \Lab123\AwsSns\Messages\AwsSnsMessage
     */
    public function toAwsSnsTopic($notifiable)

    {
        $config = 'audit.notification-driver.sns.topic_arn';

        $topicArn = Config::get($config);

        throw_if(
            empty($topicArn),
            new AuditingException("config $config is not set.")
        );

        return (new AwsSnsMessage())
            ->message(json_encode($this->auditData))
            ->topicArn($topicArn);
    }
}


1		<?php
2
3		namespace Andreshg112\LaravelAuditingNotifications;
4
5		use Illuminate\Support\Facades\Config;
6		use Lab123\AwsSns\Messages\AwsSnsMessage;
7		use Illuminate\Notifications\Notification;
8		use Lab123\AwsSns\Channels\AwsSnsTopicChannel;
9		use OwenIt\Auditing\Exceptions\AuditingException;
10
11		class AuditSns extends Notification
12		{
13		/** @var array $auditData */
14		protected $auditData = null;
15
16		/**
17		* Create a new notification instance.
18		*
19		* @param array $auditData
20		*/
21	3	public function __construct(array $auditData)
22		{
23	3	$this->auditData = $auditData;
24	3	}
25
26		/**
27		* Get the notification's delivery channels.
28		*
29		* @param \OwenIt\Auditing\Contracts\Auditable $notifiable
30		* @return array
31		*/
32	1	public function via($notifiable)
		0 ignored issues – show Unused Code introduced 2019-04-02 22:34 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
33		{
34	1	return [AwsSnsTopicChannel::class];
35		}
36
37		/**
38		* Get the SNS representation of the notification.
39		*
40		* @param \OwenIt\Auditing\Contracts\Auditable $notifiable
41		* @return \Lab123\AwsSns\Messages\AwsSnsMessage
42		*/
43	1	public function toAwsSnsTopic($notifiable)
		0 ignored issues – show Unused Code introduced 2019-04-02 22:34 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
44		{
45	1	$config = 'audit.notification-driver.sns.topic_arn';
46
47	1	$topicArn = Config::get($config);
48
49	1	throw_if(
50	1	empty($topicArn),
51	1	new AuditingException("config $config is not set.")
52		);
53
54	1	return (new AwsSnsMessage())
55	1	->message(json_encode($this->auditData))
56	1	->topicArn($topicArn);
57		}
58		}
59

andreshg112 / laravel-auditing-notifications

Push — master ( 8049c5...c740e0 )

AuditSns::toAwsSnsTopic() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like