Andreshg112\HolidaysPhp\Providers\Colombia\CalendarioHispanohablanteCom::holidays()

Complexity

Conditions	5
Paths	5

Size

Total Lines	61
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	28
CRAP Score	5.0073

Importance

Changes	2
Bugs	1	Features	0

<?php
    public function holidays(int $year = null): array
    {
        $year = $year ?? date('Y');

        $baseUrl = $this->baseUrl();

        $url = "{$baseUrl}/{$year}/calendario-colombia-{$year}.html";

        try {
            $html = file_get_contents($url);
        } catch (\Throwable $th) {
            throw HolidaysPhpException::notFound();
        }

        $page = new HtmlPage($html);

        $rows = $page->filter('.group-three > p');

        if ($rows->count() === 0) {
            throw HolidaysPhpException::unrecognizedStructure();
        }

        $holidays = [];

        $country = $this->country();

        foreach ($rows as $row) {
            $crawler = new HtmlPageCrawler($row);

            $dateContainer = $crawler->filter('b')->first();

            // This element must exist
            if ($dateContainer->count() === 0) {
                continue;
            }

            // The text is like "Viernes 1 de Enero", so it has to be separated
            [, $spanishDate] = explode(' ', $dateContainer->text(), 2);

            // The ending : has to be removed
            $spanishDate = rtrim($spanishDate, ':');

            Date::setLocale($this->getLanguage());

            // The date looks this way "1 de Enero 2021"
            $date = Date::createFromFormat('j \d\e F Y', "{$spanishDate} {$year}");

            // Remove it so the text inside the $crawler is only the title of the holiday
            $dateContainer->remove();

            $titleContainer = $crawler->first();

            $holidays[] = new Holiday(
                $country,
                $date->setTime(0, 0),

It seems like $date->setTime(0, 0) can also be of type false; however, parameter $date of Andreshg112\HolidaysPhp\Holiday::__construct() does only seem to accept Jenssegers\Date\Date, maybe add an additional type check?

                $titleContainer->text(),
                $this->getLanguage()
            );
        }

        return $holidays;
    }