Andreshg112\HolidaysPhp\Providers\Colombia\CalendarioDeColombiaCom::holidays()

Complexity

Conditions	5
Paths	5

Size

Total Lines	52
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	23
CRAP Score	5.0812

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function holidays(int $year = null): array
    {
        $year = $year ?? date('Y');

        $baseUrl = $this->baseUrl();

        $url = "{$baseUrl}/calendario-{$year}.html";

        try {
            $html = file_get_contents($url);
        } catch (\Throwable $th) {
            throw HolidaysPhpException::notFound();
        }

        $page = new HtmlPage($html);

        $rows = $page->filter(
            '#cuadro_festivos > div > .tabla_festivos1 > .formato_fechas, #cuadro_festivos > div > .tabla_festivos2 > .formato_fechas'
        );

        if ($rows->count() === 0) {
            throw HolidaysPhpException::unrecognizedStructure();
        }

        $holidays = [];

        $country = $this->country();

        foreach ($rows as $row) {
            $crawler = new HtmlPageCrawler($row);

            $dateContainer = $crawler->filter('time')->first();

            // This element must exist
            if ($dateContainer->count() === 0) {
                continue;
            }

            // The date is already in a field time
            $date = Date::parse($dateContainer->getAttribute('datetime'));

            $titleContainer = $crawler->filter('a')->first();

            $holidays[] = new Holiday(
                $country,
                $date->setTime(0, 0),
                $titleContainer->getAttribute('title'), // title

It seems like $titleContainer->getAttribute('title') can also be of type null; however, parameter $title of Andreshg112\HolidaysPhp\Holiday::__construct() does only seem to accept string, maybe add an additional type check?

                $this->getLanguage()
            );
        }

        return $holidays;
    }