Middleware::__invoke() - Code Metrics - Inspection of "Fix token authentication, variables and indentatio..." - andela-tolotin/Emoji-REST-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 59d00e...88e4b3 )

by Temitope

created 2016-03-24 17:37 UTC

Middleware::__invoke() B

↳ Parent: Middleware

Complexity

Conditions	4
Paths	7

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	3	Features	0

Metric	Value
c	5
b	3
f	0
dl	0
loc	23
rs	8.7972
cc	4
eloc	12
nc	7
nop	3

<?php
/**
 * @author   Temitope Olotin <[email protected]>
 * @license  <https://opensource.org/license/MIT> MIT
 */

namespace Laztopaz\EmojiRestfulAPI;

use Firebase\JWT\JWT;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;

class Middleware
{
    public function __invoke(Request $request, Response $response, $next)
    {
        $loadEnv = DatabaseConnection::loadEnv();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $authHeader = $request->getHeader('HTTP_AUTHORIZATION');

        try {
            if (is_array($authHeader) && !empty($authHeader)) {

                $secretKey = base64_decode(getenv('secret'));
                $jwt = json_decode($authHeader[0], true);
                //decode the JWT using the key from config

                $decodedToken = JWT::decode($jwt['jwt'], $secretKey, ['HS512']);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

                return $next($request, $response);

            }
        } catch (\Exception $e) {
            return $response->withJson(['status' => $e->getMessage()], 401);
        }
        return $response->withJson(['status'], 401);
    }
}


1			<?php
2			/**
3			* @author Temitope Olotin <[email protected]>
4			* @license <https://opensource.org/license/MIT> MIT
5			*/
6
7			namespace Laztopaz\EmojiRestfulAPI;
8
9			use Firebase\JWT\JWT;
10			use Psr\Http\Message\ResponseInterface as Response;
11			use Psr\Http\Message\ServerRequestInterface as Request;
12
13			class Middleware
14			{
15			public function __invoke(Request $request, Response $response, $next)
16			{
17			$loadEnv = DatabaseConnection::loadEnv();
			0 ignored issues – show Bug introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$loadEnv` is correct as `\Laztopaz\EmojiRestfulAP...seConnection::loadEnv()` (which targets `Laztopaz\EmojiRestfulAPI...seConnection::loadEnv()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Unused Code introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report `$loadEnv` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
18
19			$authHeader = $request->getHeader('HTTP_AUTHORIZATION');
20
21			try {
22			if (is_array($authHeader) && !empty($authHeader)) {
23
24			$secretKey = base64_decode(getenv('secret'));
25			$jwt = json_decode($authHeader[0], true);
26			//decode the JWT using the key from config
27
28			$decodedToken = JWT::decode($jwt['jwt'], $secretKey, ['HS512']);
			0 ignored issues – show Unused Code introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report `$decodedToken` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
29
30			return $next($request, $response);
31
32			}
33			} catch (\Exception $e) {
34			return $response->withJson(['status' => $e->getMessage()], 401);
35			}
36			return $response->withJson(['status'], 401);
37			}
38			}
39

andela-tolotin / Emoji-REST-API

Push — master ( 59d00e...88e4b3 )

Middleware::__invoke() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like