UploadTableInfo::createEmojiKeywords() - Code Metrics - Inspection of "create table populator" - andela-tolotin/Emoji-REST-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 313ed9...d109e4 )

by Temitope

created 2016-03-23 21:24 UTC

UploadTableInfo::createEmojiKeywords() A

↳ Parent: UploadTableInfo

Complexity

Conditions	3
Paths	2

Size

Total Lines	20
Code Lines	10

Duplication

Lines	20
Ratio	100 %

Metric	Value
dl	20
loc	20
rs	9.4285
cc	3
eloc	10
nc	2
nop	2

<?php
/**
 * @author   Temitope Olotin <[email protected]>
 * @license  <https://opensource.org/license/MIT> MIT
 */

namespace Laztopaz\EmojiRestfulAPI;

use Laztopaz\EmojiRestfulAPI\Emoji;
use Laztopaz\EmojiRestfulAPI\Keyword;
use Laztopaz\EmojiRestfulAPI\UserController;


class UploadTableInfo 
{

    public function __construct()
    {
        $this->createUser();
        $this->createCategory();
        $this->createEmoji();
    }

    public function createUser()
    {
        $suer = new UserController();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $user->createUser([

            'firstname' => 'Temitope',
            'lastname'  => 'Olotin',
            'username' => 'laztopaz',
            'password' => 'tope0852',
            'email' => '[email protected]',
            'created_at' => date('Y-m-d h:i:s'), 
            'updated_at' => date('Y-m-d h:i:s')
            ]);

    }

    public function createEmoji()
    {
        $emojiKeyword = 'eye,face,grin,person';

        $userId = 1;

            $created_at = date('Y-m-d h:i:s');

            $emoji = Emoji::create(
                [
                    'name' => 'GRINNING FACE', 
                    'char' => '\u{1F600}', 
                    'created_at' => $created_at, 
                    'category' => 1, 
                    'created_by' => $userId
                ]
            );

            if ($emoji->id) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $createdKeyword = $this->createEmojiKeywords($emoji->id, $emojiKeyword);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }

    }

    public function createCategory()
    {
        $created_at = date('Y-m-d h:i:s');

        $category = Category::create(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                [
                    'category_name' => 'people', 
                    'created_at' => $created_at
                ]
            );

    }

    public function createEmojiKeywords($emoji_id, $keywords)

    {
        if ($keywords) {
            $splittedKeywords = explode(',', $keywords);

            $created_at = date('Y-m-d h:i:s');

            foreach ($splittedKeywords as $keyword) {
                $emojiKeyword = Keyword::create(
                    [
                        'emoji_id'     => $emoji_id,
                        'keyword_name' => $keyword,
                        'created_at'   => $created_at,
                    ]
                );
            }
        }

        return $emojiKeyword->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}

1		<?php
2		/**
3		* @author Temitope Olotin <[email protected]>
4		* @license <https://opensource.org/license/MIT> MIT
5		*/
6
7		namespace Laztopaz\EmojiRestfulAPI;
8
9		use Laztopaz\EmojiRestfulAPI\Emoji;
10		use Laztopaz\EmojiRestfulAPI\Keyword;
11		use Laztopaz\EmojiRestfulAPI\UserController;
12
13
14		class UploadTableInfo
15		{
16
17		public function __construct()
18		{
19		$this->createUser();
20		$this->createCategory();
21		$this->createEmoji();
22		}
23
24		public function createUser()
25		{
26		$suer = new UserController();
		0 ignored issues – show Unused Code introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report `$suer` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
27
28		$user->createUser([
		0 ignored issues – show Bug introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report The variable `$user` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
29		'firstname' => 'Temitope',
30		'lastname' => 'Olotin',
31		'username' => 'laztopaz',
32		'password' => 'tope0852',
33		'email' => '[email protected]',
34		'created_at' => date('Y-m-d h:i:s'),
35		'updated_at' => date('Y-m-d h:i:s')
36		]);
37
38		}
39
40		public function createEmoji()
41		{
42		$emojiKeyword = 'eye,face,grin,person';
43
44		$userId = 1;
45
46		$created_at = date('Y-m-d h:i:s');
47
48		$emoji = Emoji::create(
49		[
50		'name' => 'GRINNING FACE',
51		'char' => '\u{1F600}',
52		'created_at' => $created_at,
53		'category' => 1,
54		'created_by' => $userId
55		]
56		);
57
58		if ($emoji->id) {
		0 ignored issues – show Documentation introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Laztopaz\EmojiRestfulAPI\Emoji>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
59		$createdKeyword = $this->createEmojiKeywords($emoji->id, $emojiKeyword);
		0 ignored issues – show Documentation introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Laztopaz\EmojiRestfulAPI\Emoji>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Unused Code introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report `$createdKeyword` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
60		}
61
62		}
63
64		public function createCategory()
65		{
66		$created_at = date('Y-m-d h:i:s');
67
68		$category = Category::create(
		0 ignored issues – show Unused Code introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report `$category` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
69		[
70		'category_name' => 'people',
71		'created_at' => $created_at
72		]
73		);
74
75		}
76
77	View Code Duplication	public function createEmojiKeywords($emoji_id, $keywords)
		0 ignored issues – show Duplication introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		if ($keywords) {
80		$splittedKeywords = explode(',', $keywords);
81
82		$created_at = date('Y-m-d h:i:s');
83
84		foreach ($splittedKeywords as $keyword) {
85		$emojiKeyword = Keyword::create(
86		[
87		'emoji_id' => $emoji_id,
88		'keyword_name' => $keyword,
89		'created_at' => $created_at,
90		]
91		);
92		}
93		}
94
95		return $emojiKeyword->id;
		0 ignored issues – show Documentation introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Laztopaz\EmojiRestfulAPI\Keyword>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-03-23 21:26 UTC by Report Bug Copy Issue Report The variable `$emojiKeyword` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
96		}
97		}

andela-tolotin / Emoji-REST-API

Push — master ( 313ed9...d109e4 )

UploadTableInfo::createEmojiKeywords() A

Complexity

Size

Duplication

Available Fixes

Duplication Side-by-Side

Filter issues like