Oauth::buildAcessToken() - Code Metrics - Inspection of "Testing failing on create user" - andela-tolotin/Emoji-REST-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0f1d25...bd39e2 )

by Temitope

created 2016-04-01 14:34 UTC

Oauth::buildAcessToken() B

↳ Parent: Oauth

Complexity

Conditions	1
Paths	1

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	2	Features	1

Metric	Value
c	10
b	2
f	1
dl	0
loc	34
rs	8.8571
cc	1
eloc	21
nc	1
nop	1

<?php
/**
 * @author   Temitope Olotin <[email protected]>
 * @license  <https://opensource.org/license/MIT> MIT
 */
namespace Laztopaz\EmojiRestfulAPI;

use Firebase\JWT\JWT;
use Illuminate\Database\Capsule\Manager as Capsule;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;

class Oauth
{
    /**
     * This method register a new user.
     *
     * @param $request
     * @param $response
     *
     * @return json response
     */
    public function registerUser(Request $request, Response $response)
    {
        $userParams = $request->getParsedBody();

        if (is_array($userParams)) {
            $user = new UserController();
            $emoji = new EmojiController($this);

            $validateResponse = $emoji->validateUserInput([
                'firstname',
                'lastname',
                'username',
                'password',
                'email',
            ], $userParams);

            if (is_array($validateResponse)) {
                return $response->withJson($validateResponse, 400);
            }

            if (!$this->verifyUserRegistration($userParams['username'], $userParams['email'])) {
                $this->runRegisterUser($user, $userParams, $response);
            }

            return $response->withJson(['message' => 'User already exists'], 400);
        }
    }

    /**
     * This method creates user
     *
     * @param $user
     * @param $userParams
     * @param $response
     *
     * @return json $response
     */
    public function runRegisterUser($user, $userParams, $response)
    {
        $boolResponse = $user->createUser([
            'firstname'  => $userParams['firstname'],
            'lastname'   => $userParams['lastname'],
            'username'   => strtolower($userParams['username']),
            'password'   => $userParams['password'],
            'email'      => strtolower($userParams['email']),
            'created_at' => date('Y-m-d h:i:s'),
            'updated_at' => date('Y-m-d h:i:s'),
        ]);

        if ($boolResponse) {
            return $response->withJson(['message' => 'User successfully created'], 201);
        }

        return $response->withJson(['message' => 'User not created'], 400);
    }

    /**
     * This method authenticate the user and log them in if the supplied
     * credentials are valid.
     *
     * @param array $loginParams
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return json jwt
     */
    public function loginUser(Request $request, Response $response)
    {
        $loginParams = $request->getParsedBody();

        if (is_array($loginParams)) {
            $user = User::where('username', '=', $loginParams['username'])->get()->first();

            if (count($user) > 0) {
                $userInfo = ['id' => $user->id, 'username' => $user->username, 'email' => $user->email];

                if (password_verify($loginParams['password'], $user->password)) {
                    $token = $this->buildAcessToken($userInfo);

                    return $response->withAddedHeader('HTTP_AUTHORIZATION', $token)
                    ->withStatus(200)
                    ->write($token);
                }
            }

            return $response->withJson(['message' => 'Login credentials incorrect'], 400);
        }
    }

    /**
     * This method logout the user.
     *
     * @param $args logout
     *
     * @return $reponse

     */
    public function logoutUser(Request $request, Response $response, $args)

    {
        return $response->withJson(['message' => 'Logout successful'], 200);
    }

    /**
     * This method verifies a registered user.
     *
     * @param $email
     * @param $username
     *
     * @return bool true
     */
    public function verifyUserRegistration($username, $email)
    {
        if (isset($username) && isset($email)) {
            $userFound = Capsule::table('users')
            ->Where('username', '=', strtolower($username))
            ->orWhere('email', '=', strtolower($email))
            ->get();

            if (count($userFound) > 0) {
                return true;
            }
        }

        return false;
    }

    /**
     * This method builds an access token for a login user;.
     *
     * @param $userData
     *
     * @return string $token
     */
    public function buildAcessToken(array $userData)
    {
        $tokenId = base64_encode(mcrypt_create_iv(32));
        $issuedAt = time();
        $notBefore = $issuedAt;
        $expire = (float) strtotime('+30 days'); // Adding 30 days expiry date
        $serverName = 'http://localhost:8000/emojis'; // the server name

        /*
         *
         * Create the token params as an array
         */
        $data = [
            'iat'  => $issuedAt,         // Issued at: time when the token was generated
            'jti'  => $tokenId,          // Json Token Id: an unique identifier for the token
            'iss'  => $serverName,       // Issuer
            'nbf'  => $notBefore,        // Not before
            'exp'  => $expire,           // Expire
            'dat'  => $userData,          // User Information retrieved from the database
        ];

        $loadEnv = DatabaseConnection::loadEnv();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $secretKey = base64_decode(getenv('secret'));

        $jwt = JWT::encode(
        $data,      //Data to be encoded in the JWT
        $secretKey, // The signing key
        'HS512'     // Algorithm used to sign the token
        );
        $unencodedArray = ['jwt' => $jwt];

        return json_encode($unencodedArray);
    }
}


1			<?php
2			/**
3			* @author Temitope Olotin <[email protected]>
4			* @license <https://opensource.org/license/MIT> MIT
5			*/
6			namespace Laztopaz\EmojiRestfulAPI;
7
8			use Firebase\JWT\JWT;
9			use Illuminate\Database\Capsule\Manager as Capsule;
10			use Psr\Http\Message\ResponseInterface as Response;
11			use Psr\Http\Message\ServerRequestInterface as Request;
12
13			class Oauth
14			{
15			/**
16			* This method register a new user.
17			*
18			* @param $request
19			* @param $response
20			*
21			* @return json response
22			*/
23			public function registerUser(Request $request, Response $response)
24			{
25			$userParams = $request->getParsedBody();
26
27			if (is_array($userParams)) {
28			$user = new UserController();
29			$emoji = new EmojiController($this);
30
31			$validateResponse = $emoji->validateUserInput([
32			'firstname',
33			'lastname',
34			'username',
35			'password',
36			'email',
37			], $userParams);
38
39			if (is_array($validateResponse)) {
40			return $response->withJson($validateResponse, 400);
41			}
42
43			if (!$this->verifyUserRegistration($userParams['username'], $userParams['email'])) {
44			$this->runRegisterUser($user, $userParams, $response);
45			}
46
47			return $response->withJson(['message' => 'User already exists'], 400);
48			}
49			}
50
51			/**
52			* This method creates user
53			*
54			* @param $user
55			* @param $userParams
56			* @param $response
57			*
58			* @return json $response
59			*/
60			public function runRegisterUser($user, $userParams, $response)
61			{
62			$boolResponse = $user->createUser([
63			'firstname' => $userParams['firstname'],
64			'lastname' => $userParams['lastname'],
65			'username' => strtolower($userParams['username']),
66			'password' => $userParams['password'],
67			'email' => strtolower($userParams['email']),
68			'created_at' => date('Y-m-d h:i:s'),
69			'updated_at' => date('Y-m-d h:i:s'),
70			]);
71
72			if ($boolResponse) {
73			return $response->withJson(['message' => 'User successfully created'], 201);
74			}
75
76			return $response->withJson(['message' => 'User not created'], 400);
77			}
78
79			/**
80			* This method authenticate the user and log them in if the supplied
81			* credentials are valid.
82			*
83			* @param array $loginParams
			0 ignored issues – show Bug introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report There is no parameter named `$loginParams`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
84			*
85			* @return json jwt
86			*/
87			public function loginUser(Request $request, Response $response)
88			{
89			$loginParams = $request->getParsedBody();
90
91			if (is_array($loginParams)) {
92			$user = User::where('username', '=', $loginParams['username'])->get()->first();
93
94			if (count($user) > 0) {
95			$userInfo = ['id' => $user->id, 'username' => $user->username, 'email' => $user->email];
96
97			if (password_verify($loginParams['password'], $user->password)) {
98			$token = $this->buildAcessToken($userInfo);
99
100			return $response->withAddedHeader('HTTP_AUTHORIZATION', $token)
101			->withStatus(200)
102			->write($token);
103			}
104			}
105
106			return $response->withJson(['message' => 'Login credentials incorrect'], 400);
107			}
108			}
109
110			/**
111			* This method logout the user.
112			*
113			* @param $args logout
114			*
115			* @return $reponse
			0 ignored issues – show Documentation introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report The doc-type `$reponse` could not be parsed: Unknown type name "$reponse" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
116			*/
117			public function logoutUser(Request $request, Response $response, $args)
			0 ignored issues – show Unused Code introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report The parameter `$args` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
118			{
119			return $response->withJson(['message' => 'Logout successful'], 200);
120			}
121
122			/**
123			* This method verifies a registered user.
124			*
125			* @param $email
126			* @param $username
127			*
128			* @return bool true
129			*/
130			public function verifyUserRegistration($username, $email)
131			{
132			if (isset($username) && isset($email)) {
133			$userFound = Capsule::table('users')
134			->Where('username', '=', strtolower($username))
135			->orWhere('email', '=', strtolower($email))
136			->get();
137
138			if (count($userFound) > 0) {
139			return true;
140			}
141			}
142
143			return false;
144			}
145
146			/**
147			* This method builds an access token for a login user;.
148			*
149			* @param $userData
150			*
151			* @return string $token
152			*/
153			public function buildAcessToken(array $userData)
154			{
155			$tokenId = base64_encode(mcrypt_create_iv(32));
156			$issuedAt = time();
157			$notBefore = $issuedAt;
158			$expire = (float) strtotime('+30 days'); // Adding 30 days expiry date
159			$serverName = 'http://localhost:8000/emojis'; // the server name
160
161			/*
162			*
163			* Create the token params as an array
164			*/
165			$data = [
166			'iat' => $issuedAt, // Issued at: time when the token was generated
167			'jti' => $tokenId, // Json Token Id: an unique identifier for the token
168			'iss' => $serverName, // Issuer
169			'nbf' => $notBefore, // Not before
170			'exp' => $expire, // Expire
171			'dat' => $userData, // User Information retrieved from the database
172			];
173
174			$loadEnv = DatabaseConnection::loadEnv();
			0 ignored issues – show Bug introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$loadEnv` is correct as `\Laztopaz\EmojiRestfulAP...seConnection::loadEnv()` (which targets `Laztopaz\EmojiRestfulAPI...seConnection::loadEnv()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... Unused Code introduced 2016-03-21 23:39 UTC by Report Bug Copy Issue Report `$loadEnv` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
175
176			$secretKey = base64_decode(getenv('secret'));
177
178			$jwt = JWT::encode(
179			$data, //Data to be encoded in the JWT
180			$secretKey, // The signing key
181			'HS512' // Algorithm used to sign the token
182			);
183			$unencodedArray = ['jwt' => $jwt];
184
185			return json_encode($unencodedArray);
186			}
187			}
188

andela-tolotin / Emoji-REST-API

Push — master ( 0f1d25...bd39e2 )

Oauth::buildAcessToken() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like