Formatter::makeAssociativeArray() - Code Metrics - andela-sakande/potatoORM - Measure and Improve Code Quality continuously with Scrutinizer

Formatter::makeAssociativeArray() A
last analyzed 2015-11-26 11:01 UTC

↳ Parent: Formatter

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	16
rs	9.4286
cc	3
eloc	10
nc	3
nop	1

<?php
/**
 * @package A simple ORM that performs basic CRUD operations
 * @author Surajudeen AKANDE <[email protected]>
 * @license MIT <https://opensource.org/licenses/MIT>
 * @link http://www.github.com/andela-sakande
 * */
namespace Sirolad\Libraries;

use Sirolad\Exception;
use Sirolad\Interfaces\FormatterInterface;

/**
 * This class pluralizes, tokenize, make placeholders and associative array for the main class (Potato).
 * */
class Formatter implements FormatterInterface
{
    /**
     * Pluralizes or singularizes inputs
     * @param string $str
     * @return string $str
     * */
    public static function addOrRemoveS($str)
    {
        $tableNameAsArray = str_split($str);

        if ($tableNameAsArray[count($tableNameAsArray) - 1] === 's') {
            array_pop($tableNameAsArray);
            $str = implode($tableNameAsArray);
        } else {
            $str .= 's';
        }

        return $str;
    }

    /**
     * Break down a delimited statement into set of string separated by comma
     *
     * @param string $str Statement to be broken down
     * @param string $delimiter Character being searched for to bring about the break down
     * @return string Comma-separated set of string
     */
    public static function tokenize($str, $delimiter)
    {
        $output = '';
        $token = strtok($str, $delimiter);
        $output .= $token;

        while ($token) {
            $token = strtok($delimiter);
            $output .= ',' .$token;
        }

        return rtrim($output, ',');
    }

    /**
     * Generate unnamed placeholders depending on the number of table fields concerned
     *
     * @param array $record Set of affected table fields
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return array $placeholder Sql statement placeholders for field values
     */
    public static function generateUnnamedPlaceholders(array $records)
    {
        $placeholder = [];

        foreach ($records as $record) {
            array_push($placeholder, '?');
        }

        return $placeholder;
    }

    /**
     * Create an array of elements in the format 'array_key=array_value' of the argument array supplied
     *
     * @param array $record Associative type of array
     * @return array $temp New array of elements in the format 'array_key=array_value' of the argument array supplied
     */
    public static function makeAssociativeArray(array $record)
    {
        $temp = [];
        for ($i = 1; $i < count($record); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $value = array_values($record)[$i];

            if (is_null($value)) {
                $value = 'NULL';
            } else {
                $value = '"' . $value . '"';
            }

            array_push($temp, array_keys($record)[$i] . '=' . $value);
        }
        return $temp;
    }
}


1			<?php
2			/**
3			* @package A simple ORM that performs basic CRUD operations
4			* @author Surajudeen AKANDE <[email protected]>
5			* @license MIT <https://opensource.org/licenses/MIT>
6			* @link http://www.github.com/andela-sakande
7			* */
8			namespace Sirolad\Libraries;
9
10			use Sirolad\Exception;
11			use Sirolad\Interfaces\FormatterInterface;
12
13			/**
14			* This class pluralizes, tokenize, make placeholders and associative array for the main class (Potato).
15			* */
16			class Formatter implements FormatterInterface
17			{
18			/**
19			* Pluralizes or singularizes inputs
20			* @param string $str
21			* @return string $str
22			* */
23			public static function addOrRemoveS($str)
24			{
25			$tableNameAsArray = str_split($str);
26
27			if ($tableNameAsArray[count($tableNameAsArray) - 1] === 's') {
28			array_pop($tableNameAsArray);
29			$str = implode($tableNameAsArray);
30			} else {
31			$str .= 's';
32			}
33
34			return $str;
35			}
36
37			/**
38			* Break down a delimited statement into set of string separated by comma
39			*
40			* @param string $str Statement to be broken down
41			* @param string $delimiter Character being searched for to bring about the break down
42			* @return string Comma-separated set of string
43			*/
44			public static function tokenize($str, $delimiter)
45			{
46			$output = '';
47			$token = strtok($str, $delimiter);
48			$output .= $token;
49
50			while ($token) {
51			$token = strtok($delimiter);
52			$output .= ',' .$token;
53			}
54
55			return rtrim($output, ',');
56			}
57
58			/**
59			* Generate unnamed placeholders depending on the number of table fields concerned
60			*
61			* @param array $record Set of affected table fields
			0 ignored issues – show Documentation introduced 2015-11-26 11:01 UTC by Report Bug Copy Issue Report There is no parameter named `$record`. Did you maybe mean `$records`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
62			* @return array $placeholder Sql statement placeholders for field values
63			*/
64			public static function generateUnnamedPlaceholders(array $records)
65			{
66			$placeholder = [];
67
68			foreach ($records as $record) {
69			array_push($placeholder, '?');
70			}
71
72			return $placeholder;
73			}
74
75			/**
76			* Create an array of elements in the format 'array_key=array_value' of the argument array supplied
77			*
78			* @param array $record Associative type of array
79			* @return array $temp New array of elements in the format 'array_key=array_value' of the argument array supplied
80			*/
81			public static function makeAssociativeArray(array $record)
82			{
83			$temp = [];
84			for ($i = 1; $i < count($record); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2015-11-26 11:01 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
85			$value = array_values($record)[$i];
86
87			if (is_null($value)) {
88			$value = 'NULL';
89			} else {
90			$value = '"' . $value . '"';
91			}
92
93			array_push($temp, array_keys($record)[$i] . '=' . $value);
94			}
95			return $temp;
96			}
97			}
98

andela-sakande / potatoORM

Formatter::makeAssociativeArray() A last analyzed 2015-11-26 11:01 UTC

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like

Formatter::makeAssociativeArray() A
last analyzed 2015-11-26 11:01 UTC