Issues in SqliteConnection.php (master) - Issues in master - andela-oogunjimi/Potato-ORM - Measure and Improve Code Quality continuously with Scrutinizer

Issues (26)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Connections/SqliteConnection.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Opeyemiabiodun\PotatoORM\Connections;

use PDO;
use PDOException;
use InvalidArgumentException;

final class SqliteConnection implements Connection
{
    use DatabaseTransactionsTrait;

    /**
     * $_pdo The PDO instance of the connection.
     *
     * @var PDO
     */
    private $_pdo;

    /**
     * $columns Columns of the database table.
     *
     * @var array
     */
    private $columns = [];

    /**
     * $keys Keys of the database table.
     *
     * @var array
     */
    private $keys = [];

    /**
     * The method called in the constructor.
     *
     * @return void

     */
    public function __construct()
    {
        $dsn = 'sqlite:../../potatodb.sq3';

        try {
            $this->_pdo = new PDO($dsn);
        } catch (PDOException $e) {

        }
    }

    /**
     * Returns the columns of a table.
     *
     * @param string $table The table inspected for its columns.
     *
     * @return array The columns of the table.        
     */
    public function getColumns($table)

    {
        if (gettype($table) !== 'string') {
            throw new InvalidArgumentException("The parameter {$table} is not an string. A string is required instead.");
        }

        $this->loadColumnInfo($table);

        return $this->columns[$table];
    }

    /**
     * Returns the Connection's PDO.
     *
     * @return PDO PHP Data Objects
     */
    public function getPdo()
    {
        return $this->_pdo;
    }

    /**
     * Returns the primary key of a table.
     *
     * @param string $table The table inspected for its primary key.
     *
     * @return string The primary key of the table.
     */
    public function getPrimaryKey($table)

    {
        if (gettype($table) !== 'string') {
            throw new InvalidArgumentException("The parameter {$table} is not an string. A string is required instead.");
        }

        $this->loadColumnInfo($table);

        return $this->keys[$table][0];
    }

    private function loadColumnInfo($table)
    {
        $query = "PRAGMA table_info('{$table}')";
        $statement = $this->_pdo->query($query);

        /* @var $statement PDOStatement */
        $this->columns[$table] = [];
        $this->keys[$table] = [];

        while ($columnData = $statement->fetch(PDO::FETCH_NUM)) {
            $this->columns[$table][] = ['column_name' => $columnData[1]];

            if ($columnData[5] == 1) {
                $this->keys[$table][] = $columnData[1];
            }
        }
    }
}


1			<?php
2
3			namespace Opeyemiabiodun\PotatoORM\Connections;
4
5			use PDO;
6			use PDOException;
7			use InvalidArgumentException;
8
9			final class SqliteConnection implements Connection
10			{
11			use DatabaseTransactionsTrait;
12
13			/**
14			* $_pdo The PDO instance of the connection.
15			*
16			* @var PDO
17			*/
18			private $_pdo;
19
20			/**
21			* $columns Columns of the database table.
22			*
23			* @var array
24			*/
25			private $columns = [];
26
27			/**
28			* $keys Keys of the database table.
29			*
30			* @var array
31			*/
32			private $keys = [];
33
34			/**
35			* The method called in the constructor.
36			*
37			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2015-12-19 03:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
38			*/
39			public function __construct()
40			{
41			$dsn = 'sqlite:../../potatodb.sq3';
42
43			try {
44			$this->_pdo = new PDO($dsn);
45			} catch (PDOException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-19 03:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
46			}
47			}
48
49			/**
50			* Returns the columns of a table.
51			*
52			* @param string $table The table inspected for its columns.
53			*
54			* @return array The columns of the table.
55			*/
56	7	View Code Duplication	public function getColumns($table)
			0 ignored issues – show Duplication introduced 2015-12-19 03:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57			{
58	7		if (gettype($table) !== 'string') {
59			throw new InvalidArgumentException("The parameter {$table} is not an string. A string is required instead.");
60			}
61
62	7		$this->loadColumnInfo($table);
63
64	7		return $this->columns[$table];
65			}
66
67			/**
68			* Returns the Connection's PDO.
69			*
70			* @return PDO PHP Data Objects
71			*/
72	4		public function getPdo()
73			{
74	4		return $this->_pdo;
75			}
76
77			/**
78			* Returns the primary key of a table.
79			*
80			* @param string $table The table inspected for its primary key.
81			*
82			* @return string The primary key of the table.
83			*/
84	8	View Code Duplication	public function getPrimaryKey($table)
			0 ignored issues – show Duplication introduced 2015-12-20 20:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85			{
86	8		if (gettype($table) !== 'string') {
87			throw new InvalidArgumentException("The parameter {$table} is not an string. A string is required instead.");
88			}
89
90	8		$this->loadColumnInfo($table);
91
92	8		return $this->keys[$table][0];
93			}
94
95	8		private function loadColumnInfo($table)
96			{
97	8		$query = "PRAGMA table_info('{$table}')";
98	8		$statement = $this->_pdo->query($query);
99
100			/* @var $statement PDOStatement */
101	8		$this->columns[$table] = [];
102	8		$this->keys[$table] = [];
103
104	8		while ($columnData = $statement->fetch(PDO::FETCH_NUM)) {
105	8		$this->columns[$table][] = ['column_name' => $columnData[1]];
106
107	8		if ($columnData[5] == 1) {
108	8		$this->keys[$table][] = $columnData[1];
109	8		}
110	8		}
111	8		}
112			}
113

andela-oogunjimi / Potato-ORM

Issues (26)

Security Analysis no request data

src/Connections/SqliteConnection.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like