Opeyemiabiodun\PotatoORM\Connections\SqliteConnection

Complexity

Total Complexity

8

Size/Duplication

Total Lines	75
Duplicated Lines	13.33 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	getColumns()	10	10	2
A	getPdo()	0	4	1
A	getPrimaryKey()	0	8	2
A	load()	0	4	1

<?php

namespace Opeyemiabiodun\PotatoORM\Connections;

use PDO;
use PDOException;
use RuntimeException;
use InvalidArgumentException;
use Opeyemiabiodun\PotatoORM\Connections\Connection;
use Opeyemiabiodun\PotatoORM\Connections\DatabaseTransactionsTrait;

final class SqliteConnection implements Connection
{
    use DatabaseTransactionsTrait;

    /**
     * $_pdo The PDO instance of the connection.
     *
     * @var PDO
     */
    private $_pdo;

    /**
     * The method called in the constructor.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    private function __construct()
    {
        $dsn = "sqlite:../../testdb.sq3";

        try {
            $this->_pdo = new PDO($dsn);
        } catch (PDOException $e) {

Consider adding a comment why this CATCH block is empty.

        }
    }

    /**
     * Returns the columns of a table.
     *
     * @param string $table The table inspected for its columns.
     *
     * @return array The columns of the table.        
     */
    public function getColumns($table)

This method seems to be duplicated in your project.

    {
        if (gettype($table) !== 'string') {
            throw new InvalidArgumentException("The parameter {$table} is not an string. A string is required instead.");
        }

        var_dump($this->getPdo()->query("pragma table_info({$table})")->fetchAll());

var_dump($this->getPdo()->query("pragma table_info({$table})")->fetchAll()); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        //return $this->getPdo()->query("pragma table_info(table_name)")->fetchAll();

77% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * Returns the Connection's PDO.
     *
     * @return PDO PHP Data Objects
     */
    public function getPdo()
    {
        return $this->_pdo;
    }

    /**
     * Returns the primary key of a table.
     *
     * @param string $table The table inspected for its primary key.
     *
     * @return string The primary key of the table.
     */
    public function getPrimaryKey($table)
    {
        if (gettype($table) !== 'string') {
            throw new InvalidArgumentException("The parameter {$table} is not an string. A string is required instead.");
        }

        //return $this->getPdo()->query("SHOW KEYS FROM {$table} WHERE Key_name = 'PRIMARY'")->fetchAll()[0]['Column_name'];

83% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    public static function load()
    {
        return new SqliteConnection();
    }
}