ModelTest - Code Metrics - Inspection of "[Chore] Merge branch 'develop' of https://github.c..." - andela-joyebanji/PotatoORM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 3f7eb4...5c5c48 )

by Oyebanji Jacob

created 2016-03-18 08:15 UTC

ModelTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	153
Duplicated Lines	21.57 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	10
Bugs	5	Features	4

Metric	Value
wmc	14
c	10
b	5
f	4
lcom	1
cbo	6
dl	33
loc	153
rs	10

14 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetTableNameReturnsCorrectTableName()	0	9	1
A	testGetReturnsAnObjectWhenIdIsFoundInDatabase()	0	10	1
A	setUp()	0	14	1
A	testGetReturnNullWhenIdNotFoundInDatabase()	9	9	1
A	testAllReturnsAnArrayOfObjectsWhenValuesAreInDatabase()	0	7	1
A	testGetPropertiesReturnsExpectedArrayValues()	0	7	1
A	testDeleteReturnsTrueWhenModelIsSuccessfullyRemovedFromDatabase()	8	8	1
A	testDeleteReturnsFalseWhenModelWasNotDeletedFromDatabase()	8	8	1
A	testMagicMethodsReturnCorrectResult()	0	10	1
A	testCreateModelWithNoParameter()	0	5	1
A	testUpdateChangesTheValueOfObjectInDatabase()	0	9	1
A	testCreateObjectInDatabase()	8	9	1
A	testSaveShouldCreateNewModelInDatabaseWhenIdNotPresent()	0	8	1
A	testSaveShouldUpdateModelInDatabaseIfIdIsPresent()	0	8	1

How to fix Duplicated Code

<?php


use \Mockery as m;
use Pyjac\ORM\Model;

class ModelTest extends PHPUnit_Framework_TestCase
{
    /**
     * Instance of DatabaseConnection used in test.
     */
    protected $databaseConnection;

    /**
     * Instance of Model used in test.
     */
    protected $model;

    /**
     * Instance of SqlStatement used in test.
     */
    protected $sqlStatement;

    public function setUp()
    {
        $databaseConnectionStringFactory =
                        m::mock('Pyjac\ORM\DatabaseConnectionStringFactoryInterface');

        $databaseConnectionStringFactory->shouldReceive('createDatabaseSourceString')
                                             ->with(['DRIVER' => 'sqlite', 'HOSTNAME' => '127.0.0.1', 'USERNAME' => '', 'PASSWORD' => '', 'DBNAME' => 'potatoORM', 'PORT' => '54320'])->once()->andReturn('sqlite::memory:');

        $this->databaseConnection = m::mock('Pyjac\ORM\DatabaseConnection');

        $this->sqlStatement = m::mock('\PDOStatement');

        $this->model = $this->getMockForAbstractClass('Pyjac\ORM\Model', [$this->databaseConnection]);
    }

    public function testGetTableNameReturnsCorrectTableName()
    {
        $this->databaseConnection->shouldReceive('createConnection')->with('sqlite::memory:')->once()->andReturn('');
        $this->model->expects($this->any())
             ->method('getTableName')
             ->will($this->returnValue(strtolower(get_class($this->model).'s')));

        $this->assertEquals($this->model->getTableName(), strtolower(get_class($this->model).'s'));
    }

    public function testGetReturnsAnObjectWhenIdIsFoundInDatabase()
    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('setFetchMode');
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
        $this->sqlStatement->shouldReceive('fetch')->once()->andReturn(new stdClass());

        $this->assertInstanceOf('stdClass', $this->model->get(1));
    }

    
    public function testGetReturnNullWhenIdNotFoundInDatabase()

    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('setFetchMode');
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(0);

        $this->assertEquals(null, $this->model->get(1));
    }

    public function testAllReturnsAnArrayOfObjectsWhenValuesAreInDatabase()
    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('fetchAll')->once()->andReturn([new stdClass(), new stdClass()]);
        $this->assertContainsOnlyInstancesOf('stdClass', $this->model->all());
    }

    public function testUpdateChangesTheValueOfObjectInDatabase()
    {
        $this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);

        $this->assertEquals(1, $this->model->update());
    }

    public function testCreateObjectInDatabase()

    {
        $this->model->setProperties(['name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);

        $this->assertEquals(1, $this->model->create());
    }

    public function testSaveShouldCreateNewModelInDatabaseWhenIdNotPresent()
    {
        $this->model->setProperties(['name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
        $this->assertEquals(1, $this->model->save());
    }

    public function testSaveShouldUpdateModelInDatabaseIfIdIsPresent()
    {
        $this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
        $this->assertEquals(1, $this->model->save());
    }

    public function testGetPropertiesReturnsExpectedArrayValues()
    {
        $values = ['id' => 2, 'name' => 'pyjac', 'age' => '419'];
        $this->model->setProperties($values);

        $this->assertEquals($values, $this->model->getProperties());
    }

    public function testDeleteReturnsTrueWhenModelIsSuccessfullyRemovedFromDatabase()

    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);

        $this->assertEquals(true, $this->model->delete(1));
    }

    public function testDeleteReturnsFalseWhenModelWasNotDeletedFromDatabase()

    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(0);

        $this->assertEquals(false, $this->model->delete(1));
    }

    public function testMagicMethodsReturnCorrectResult()
    {
        $this->model->id = '10';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->model->name = 'Pyjac';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->model->age = '60';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->assertEquals($this->model->name, 'Pyjac');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertEquals($this->model->id, '10');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertEquals($this->model->age, '60');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function testCreateModelWithNoParameter()
    {
        $model = $this->getMockForAbstractClass('Pyjac\ORM\Model');
        $this->assertInstanceOf(\Pyjac\ORM\Model::class, $model);
    }
}


1		<?php
2
3
4		use \Mockery as m;
5		use Pyjac\ORM\Model;
6
7		class ModelTest extends PHPUnit_Framework_TestCase
8		{
9		/**
10		* Instance of DatabaseConnection used in test.
11		*/
12		protected $databaseConnection;
13
14		/**
15		* Instance of Model used in test.
16		*/
17		protected $model;
18
19		/**
20		* Instance of SqlStatement used in test.
21		*/
22		protected $sqlStatement;
23
24		public function setUp()
25		{
26		$databaseConnectionStringFactory =
27		m::mock('Pyjac\ORM\DatabaseConnectionStringFactoryInterface');
28
29		$databaseConnectionStringFactory->shouldReceive('createDatabaseSourceString')
30		->with(['DRIVER' => 'sqlite', 'HOSTNAME' => '127.0.0.1', 'USERNAME' => '', 'PASSWORD' => '', 'DBNAME' => 'potatoORM', 'PORT' => '54320'])->once()->andReturn('sqlite::memory:');
31
32		$this->databaseConnection = m::mock('Pyjac\ORM\DatabaseConnection');
33
34		$this->sqlStatement = m::mock('\PDOStatement');
35
36		$this->model = $this->getMockForAbstractClass('Pyjac\ORM\Model', [$this->databaseConnection]);
37		}
38
39		public function testGetTableNameReturnsCorrectTableName()
40		{
41		$this->databaseConnection->shouldReceive('createConnection')->with('sqlite::memory:')->once()->andReturn('');
42		$this->model->expects($this->any())
43		->method('getTableName')
44		->will($this->returnValue(strtolower(get_class($this->model).'s')));
45
46		$this->assertEquals($this->model->getTableName(), strtolower(get_class($this->model).'s'));
47		}
48
49		public function testGetReturnsAnObjectWhenIdIsFoundInDatabase()
50		{
51		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
52		$this->sqlStatement->shouldReceive('setFetchMode');
53		$this->sqlStatement->shouldReceive('execute');
54		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
55		$this->sqlStatement->shouldReceive('fetch')->once()->andReturn(new stdClass());
56
57		$this->assertInstanceOf('stdClass', $this->model->get(1));
58		}
59
60
61	View Code Duplication	public function testGetReturnNullWhenIdNotFoundInDatabase()
		0 ignored issues – show Duplication introduced 2016-03-18 08:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
64		$this->sqlStatement->shouldReceive('setFetchMode');
65		$this->sqlStatement->shouldReceive('execute');
66		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(0);
67
68		$this->assertEquals(null, $this->model->get(1));
69		}
70
71		public function testAllReturnsAnArrayOfObjectsWhenValuesAreInDatabase()
72		{
73		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
74		$this->sqlStatement->shouldReceive('execute');
75		$this->sqlStatement->shouldReceive('fetchAll')->once()->andReturn([new stdClass(), new stdClass()]);
76		$this->assertContainsOnlyInstancesOf('stdClass', $this->model->all());
77		}
78
79		public function testUpdateChangesTheValueOfObjectInDatabase()
80		{
81		$this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
82		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
83		$this->sqlStatement->shouldReceive('execute');
84		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
85
86		$this->assertEquals(1, $this->model->update());
87		}
88
89	View Code Duplication	public function testCreateObjectInDatabase()
		0 ignored issues – show Duplication introduced 2016-03-05 12:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90		{
91		$this->model->setProperties(['name' => 'pyjac', 'age' => '419']);
92		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
93		$this->sqlStatement->shouldReceive('execute');
94		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
95
96		$this->assertEquals(1, $this->model->create());
97		}
98
99		public function testSaveShouldCreateNewModelInDatabaseWhenIdNotPresent()
100		{
101		$this->model->setProperties(['name' => 'pyjac', 'age' => '419']);
102		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
103		$this->sqlStatement->shouldReceive('execute');
104		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
105		$this->assertEquals(1, $this->model->save());
106		}
107
108		public function testSaveShouldUpdateModelInDatabaseIfIdIsPresent()
109		{
110		$this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
111		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
112		$this->sqlStatement->shouldReceive('execute');
113		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
114		$this->assertEquals(1, $this->model->save());
115		}
116
117		public function testGetPropertiesReturnsExpectedArrayValues()
118		{
119		$values = ['id' => 2, 'name' => 'pyjac', 'age' => '419'];
120		$this->model->setProperties($values);
121
122		$this->assertEquals($values, $this->model->getProperties());
123		}
124
125	View Code Duplication	public function testDeleteReturnsTrueWhenModelIsSuccessfullyRemovedFromDatabase()
		0 ignored issues – show Duplication introduced 2016-03-05 12:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		{
127		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
128		$this->sqlStatement->shouldReceive('execute');
129		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
130
131		$this->assertEquals(true, $this->model->delete(1));
132		}
133
134	View Code Duplication	public function testDeleteReturnsFalseWhenModelWasNotDeletedFromDatabase()
		0 ignored issues – show Duplication introduced 2016-03-05 12:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
135		{
136		$this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
137		$this->sqlStatement->shouldReceive('execute');
138		$this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(0);
139
140		$this->assertEquals(false, $this->model->delete(1));
141		}
142
143		public function testMagicMethodsReturnCorrectResult()
144		{
145		$this->model->id = '10';
		0 ignored issues – show Bug introduced 2016-03-05 14:26 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
146		$this->model->name = 'Pyjac';
		0 ignored issues – show Bug introduced 2016-03-05 14:26 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
147		$this->model->age = '60';
		0 ignored issues – show Bug introduced 2016-03-05 14:26 UTC by Report Bug Copy Issue Report Accessing `age` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
148
149		$this->assertEquals($this->model->name, 'Pyjac');
		0 ignored issues – show Bug introduced 2016-03-05 14:26 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
150		$this->assertEquals($this->model->id, '10');
		0 ignored issues – show Bug introduced 2016-03-05 14:26 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
151		$this->assertEquals($this->model->age, '60');
		0 ignored issues – show Bug introduced 2016-03-05 14:26 UTC by Report Bug Copy Issue Report Accessing `age` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
152		}
153
154		public function testCreateModelWithNoParameter()
155		{
156		$model = $this->getMockForAbstractClass('Pyjac\ORM\Model');
157		$this->assertInstanceOf(\Pyjac\ORM\Model::class, $model);
158		}
159		}
160

andela-joyebanji / PotatoORM

Push — develop ( 3f7eb4...5c5c48 )

ModelTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like