andela-joyebanji / PotatoORM

src/Model.php

Doc Comments +1 added lines, -1 removed lines

@@ -178,7 +178,7 @@
     /**
      * Save the model data to the database.
      * 
-     * @return boolean
+     * @return integer
      */
     public function save()
     {

Indentation +50 added lines, -50 removed lines

@@ -10,21 +10,21 @@ 
 
     /**
      * Store instance of database connection used.
-    * @var [type]
-    */
+     * @var [type]
+     */
     protected  $databaseConnection;
 
     /**
      *  The id of the model.
      *  
      * @property string $id
-    */
+     */
      
     /**
      * Create a model instance.
      * 
      */
-     public function __construct()
+        public function __construct()
     {
         $this->databaseConnection = DatabaseConnection::getInstance()->databaseConnection;
        
@@ -32,19 +32,19 @@ 
     /**
      * Sets into $properties the $key => $value pairs
      * 
-    * @param string $key 
-    * @param string $val 
-    *
-    */
+     * @param string $key 
+     * @param string $val 
+     *
+     */
     public  function __set($key, $val)
     {
         $this->properties[$key] = $val;
     }
     /**
-    * @param string $key
-    * 
-    * @return array
-    */
+     * @param string $key
+     * 
+     * @return array
+     */
     public function __get($key)
     {
         return $this->properties[$key];
@@ -54,15 +54,15 @@ 
      *
      * @return array
      */
-     public function getProperties()
-     {
-         return $this->properties;
-     }
+        public function getProperties()
+        {
+            return $this->properties;
+        }
     /**
-    * Gets the name of the child class with a 's'.
-    *
-    * @return string
-    */
+     * Gets the name of the child class with a 's'.
+     *
+     * @return string
+     */
     public function getTableName()
     {
         $className = explode('\\', get_called_class());
@@ -70,12 +70,12 @@ 
         return $table;
     }
     /**
-    * Find the particular model with the passed id.
-    * 
-    * @param int $id
-    * 
-    * @return object
-    */
+     * Find the particular model with the passed id.
+     * 
+     * @param int $id
+     * 
+     * @return object
+     */
     public static function find($id)
     {
         $model = new static;
@@ -83,12 +83,12 @@ 
     }
 
     /**
-    * Get the particular model with the passed id.
-    * 
-    * @param int $id
-    * 
-    * @return object
-    */
+     * Get the particular model with the passed id.
+     * 
+     * @param int $id
+     * 
+     * @return object
+     */
     public function get($id)
     {
         $sql = "SELECT * FROM {$this->getTableName()} WHERE id={$id}";
@@ -102,10 +102,10 @@ 
     }
 
     /**
-    * Get all the models from the database.
-    * 
-    * @return array
-    */
+     * Get all the models from the database.
+     * 
+     * @return array
+     */
     public static function getAll()
     {
         $model = new static;
@@ -113,10 +113,10 @@ 
     }
 
     /**
-    * Returns all the models from the database.
-    * 
-    * @return array
-    */
+     * Returns all the models from the database.
+     * 
+     * @return array
+     */
     public function all()
     {
         $sql = "SELECT * FROM {$this->getTableName()}";
@@ -130,7 +130,7 @@ 
      * Update the model in the database.
      * 
      * @return int
-    */
+     */
     private function update()
     {
        
@@ -151,10 +151,10 @@ 
     }
 
     /**
-    * Insert the model values into the database.
-    *
-    * @return int
-    */
+     * Insert the model values into the database.
+     *
+     * @return int
+     */
     private function create()
     {
         
@@ -189,11 +189,11 @@ 
         return $this->id ? $this->update() : $this->create();
     }
 
-   /**
-    * Delete a model from the database. 
-    * @param  int $id 
-    * @return boolean
-    */
+    /**
+     * Delete a model from the database. 
+     * @param  int $id 
+     * @return boolean
+     */
     public static function destroy($id)
     {
         $model = new static;

test/DatabaseConnectionStringFactoryTest.php

Indentation +8 added lines, -8 removed lines

@@ -5,11 +5,11 @@ 
 
 class DatabaseConnectionStringFactoryTest extends PHPUnit_Framework_TestCase
 {
-     /**
-     * The instance of DatabaseConnectionStringFactory used in the test.
-     *
-     * @var Pyjac\ORM\DatabaseConnectionStringFactory
-     */
+        /**
+         * The instance of DatabaseConnectionStringFactory used in the test.
+         *
+         * @var Pyjac\ORM\DatabaseConnectionStringFactory
+         */
     protected $databaseConnectionStringFactoryTest;
 
     /**
@@ -45,9 +45,9 @@ 
         $this->assertEquals("sqlite::memory:", $dsn);
     }
 
-     /**
-     * @expectedException Pyjac\ORM\Exception\DatabaseDriverNotSupportedException
-     */
+        /**
+         * @expectedException Pyjac\ORM\Exception\DatabaseDriverNotSupportedException
+         */
     public function testCreateDatabaseSourceStringThrowsDatabaseDriverNotSupportedExceptionWhenUnknownDriverIsPassed()
     {
         $this->config['DRIVER']= 'pyjac';

test/HelpersTest.php

Indentation +4 added lines, -4 removed lines

@@ -24,14 +24,14 @@
         ];
     }
     public function testContainsReturnsFalseWhenStringNotFoundInArray()
-     {
+        {
         $this->assertFalse(Helpers::contains("PHP rocks", $this->testArray));
 
-     }
+        }
 
     public function testContainsReturnsTrueWhenStringIsFoundInArray()
-     {
+        {
         $this->assertTrue(Helpers::contains("Error while sending", $this->testArray));
 
-     }
+        }
 }
\ No newline at end of file

test/DatabaseConnectionTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
 	 * Reference: https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/
 	* Call protected/private method of a class.
 	*
-	* @param object &$object    Instantiated object that we will run method on.
+	* @param object DatabaseConnection    Instantiated object that we will run method on.
 	* @param string $methodName Method name to call
 	* @param array  $parameters Array of parameters to pass into method.
 	*

Indentation +62 added lines, -62 removed lines

@@ -5,86 +5,86 @@
 
 class DatabaseConnectionTest extends PHPUnit_Framework_TestCase
 {
-	/**
-	 * instance of DatabaseConnection used in test.
-	 */
-	protected $databaseConnection;
+    /**
+     * instance of DatabaseConnection used in test.
+     */
+    protected $databaseConnection;
 
 
 
-	public function setUp(){
-		$databaseConnectionStringFactory =
+    public function setUp(){
+        $databaseConnectionStringFactory =
                         m::mock('Pyjac\ORM\DatabaseConnectionStringFactoryInterface');
         $databaseConnectionStringFactory->shouldReceive('createDatabaseSourceString')
-                                             ->with(['DRIVER' => 'sqlite', 'HOSTNAME' => '127.0.0.1', 'USERNAME' => '', 'PASSWORD' => '', 'DBNAME' => 'potatoORM', 'PORT' => '54320'])->once()->andReturn('sqlite::memory:');
+                                                ->with(['DRIVER' => 'sqlite', 'HOSTNAME' => '127.0.0.1', 'USERNAME' => '', 'PASSWORD' => '', 'DBNAME' => 'potatoORM', 'PORT' => '54320'])->once()->andReturn('sqlite::memory:');
 
         $this->databaseConnection = new DatabaseConnection($databaseConnectionStringFactory);
-	}
+    }
 
-	public function testCreateConnectionReturnsDatabaseConnection()
-	{
-		$dbInstance = $this->databaseConnection->createConnection('sqlite::memory:');
+    public function testCreateConnectionReturnsDatabaseConnection()
+    {
+        $dbInstance = $this->databaseConnection->createConnection('sqlite::memory:');
 
-		$this->assertInstanceOf('PDO', $dbInstance);
+        $this->assertInstanceOf('PDO', $dbInstance);
 
-	}
+    }
 
-	public function testGetInstanceReturnsCorrectInstance()
-	{
-		$dbInstance = DatabaseConnection::getInstance();
+    public function testGetInstanceReturnsCorrectInstance()
+    {
+        $dbInstance = DatabaseConnection::getInstance();
 
-		$this->assertInstanceOf('Pyjac\ORM\DatabaseConnection', $dbInstance);
+        $this->assertInstanceOf('Pyjac\ORM\DatabaseConnection', $dbInstance);
 
-	}
+    }
 
-	public function testSetOptionsAndGetOptionsReturnsCorrectValue()
-	{
-		$options = [
-	        PDO::ATTR_CASE => PDO::CASE_NATURAL,
-	        PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
-	        PDO::ATTR_ORACLE_NULLS => PDO::NULL_NATURAL,
-	        PDO::ATTR_STRINGIFY_FETCHES => false,
-	        PDO::ATTR_EMULATE_PREPARES => false,
-	    ];
-		$this->databaseConnection->setDefaultOptions($options);
+    public function testSetOptionsAndGetOptionsReturnsCorrectValue()
+    {
+        $options = [
+            PDO::ATTR_CASE => PDO::CASE_NATURAL,
+            PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
+            PDO::ATTR_ORACLE_NULLS => PDO::NULL_NATURAL,
+            PDO::ATTR_STRINGIFY_FETCHES => false,
+            PDO::ATTR_EMULATE_PREPARES => false,
+        ];
+        $this->databaseConnection->setDefaultOptions($options);
 
-		$this->assertEquals($this->databaseConnection->getDefaultOptions(), $options);
-	}
+        $this->assertEquals($this->databaseConnection->getDefaultOptions(), $options);
+    }
 
-	public function testTryAgainIfCausedByLostConnectionCreateNewConnectionWhenReasonForExceptionIsConnectionLoss()
-	{
-		 $e = new \Exception("Error while sending");
-		$result = $this->invokeMethod($this->databaseConnection, 'tryAgainIfCausedByLostConnection', [$e, 'sqlite::memory:', '', '', []]);
+    public function testTryAgainIfCausedByLostConnectionCreateNewConnectionWhenReasonForExceptionIsConnectionLoss()
+    {
+            $e = new \Exception("Error while sending");
+        $result = $this->invokeMethod($this->databaseConnection, 'tryAgainIfCausedByLostConnection', [$e, 'sqlite::memory:', '', '', []]);
 
-		$this->assertInstanceOf('PDO', $result);
-	}
+        $this->assertInstanceOf('PDO', $result);
+    }
 
-	/**
+    /**
      * @expectedException \Exception
      */
-	public function testTryAgainIfCausedByLostConnectionThrowsExceptionWhenReasonForExceptionIsNotConnectionLoss()
-	{
-		$e = new \Exception("PHP Rocks !!!");
-		$result = $this->invokeMethod($this->databaseConnection, 'tryAgainIfCausedByLostConnection', [$e, 'sqlite::memory:', '', '', []]);
-
-	}
-
-	/**
-	 * Reference: https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/
-	* Call protected/private method of a class.
-	*
-	* @param object &$object    Instantiated object that we will run method on.
-	* @param string $methodName Method name to call
-	* @param array  $parameters Array of parameters to pass into method.
-	*
-	* @return mixed Method return.
-	*/
-	public function invokeMethod(&$object, $methodName, array $parameters = array())
-	{
-		$reflection = new \ReflectionClass(get_class($object));
-		$method = $reflection->getMethod($methodName);
-		$method->setAccessible(true);
-
-		return $method->invokeArgs($object, $parameters);
-	}
+    public function testTryAgainIfCausedByLostConnectionThrowsExceptionWhenReasonForExceptionIsNotConnectionLoss()
+    {
+        $e = new \Exception("PHP Rocks !!!");
+        $result = $this->invokeMethod($this->databaseConnection, 'tryAgainIfCausedByLostConnection', [$e, 'sqlite::memory:', '', '', []]);
+
+    }
+
+    /**
+     * Reference: https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/
+     * Call protected/private method of a class.
+     *
+     * @param object &$object    Instantiated object that we will run method on.
+     * @param string $methodName Method name to call
+     * @param array  $parameters Array of parameters to pass into method.
+     *
+     * @return mixed Method return.
+     */
+    public function invokeMethod(&$object, $methodName, array $parameters = array())
+    {
+        $reflection = new \ReflectionClass(get_class($object));
+        $method = $reflection->getMethod($methodName);
+        $method->setAccessible(true);
+
+        return $method->invokeArgs($object, $parameters);
+    }
 }
\ No newline at end of file