ModelTest

Complexity

Total Complexity

14

Size/Duplication

Total Lines	151
Duplicated Lines	21.85 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	6
Bugs	2	Features	4

14 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	16	1
A	testGetTableNameReturnsCorrectTableName()	0	9	1
A	testGetReturnsAnObjectWhenIdIsFoundInDatabase()	0	10	1
A	testGetThrowsModelNotFoundExceptionWhenIdNotFoundInDatabase()	9	9	1
A	testAllReturnsAnArrayOfObjectsWhenValuesAreInDatabase()	0	7	1
A	testUpdateChangesTheValueOfObjectInDatabase()	0	9	1
A	testCreateObjectInDatabase()	0	9	1
A	testSaveShouldCreateNewModelInDatabaseWhenIdNotPresent()	8	8	1
A	testSaveShouldUpdateModelInDatabaseIfIdIsPresent()	0	8	1
A	testGetPropertiesReturnsExpectedArrayValues()	0	7	1
A	testDeleteReturnsTrueWhenModelIsSuccessfullyRemovedFromDatabase()	8	8	1
A	testDeleteReturnsFalseWhenModelWasNotDeletedFromDatabase()	8	8	1
A	testMagicMethodsReturnCorrectResult()	0	10	1
A	testCreateModelWithNoParameter()	0	5	1

<?php


use \Mockery as m;
use Pyjac\ORM\Model;

class ModelTest extends PHPUnit_Framework_TestCase
{
    /**
     * Instance of DatabaseConnection used in test.
     */
    protected $databaseConnection;

    protected $model;

    protected $sqlStatement;

    public function setUp()
    {
        $databaseConnectionStringFactory =
                        m::mock('Pyjac\ORM\DatabaseConnectionStringFactoryInterface');

        $databaseConnectionStringFactory->shouldReceive('createDatabaseSourceString')
                                             ->with(['DRIVER' => 'sqlite', 'HOSTNAME' => '127.0.0.1', 'USERNAME' => '', 'PASSWORD' => '', 'DBNAME' => 'potatoORM', 'PORT' => '54320'])->once()->andReturn('sqlite::memory:');

        $this->databaseConnection = m::mock('Pyjac\ORM\DatabaseConnection');

        $this->sqlStatement = m::mock('\PDOStatement');

        /*$this->databaseConnection = m::mock('Pyjac\ORM\DatabaseConnection[getInstance,createConnection]',array($databaseConnectionStringFactory));*/

67% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->model = $this->getMockForAbstractClass('Pyjac\ORM\Model', [$this->databaseConnection]);
        //= new DatabaseConnection($databaseConnectionStringFactory);

56% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    public function testGetTableNameReturnsCorrectTableName()
    {
        $this->databaseConnection->shouldReceive('createConnection')->with('sqlite::memory:')->once()->andReturn('');
        $this->model->expects($this->any())
             ->method('getTableName')
             ->will($this->returnValue(strtolower(get_class($this->model).'s')));

        $this->assertEquals($this->model->getTableName(), strtolower(get_class($this->model).'s'));
    }

    public function testGetReturnsAnObjectWhenIdIsFoundInDatabase()
    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('setFetchMode');
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
        $this->sqlStatement->shouldReceive('fetch')->once()->andReturn(new stdClass());

        $this->assertInstanceOf('stdClass', $this->model->get(1));
    }

    /**
     * @expectedException Pyjac\ORM\Exception\ModelNotFoundException
     */
    public function testGetThrowsModelNotFoundExceptionWhenIdNotFoundInDatabase()

This method seems to be duplicated in your project.

    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('setFetchMode');
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(0);

        $this->assertInstanceOf('stdClass', $this->model->get(1));
    }

    public function testAllReturnsAnArrayOfObjectsWhenValuesAreInDatabase()
    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('fetchAll')->once()->andReturn([new stdClass(), new stdClass()]);
        $this->assertContainsOnlyInstancesOf('stdClass', $this->model->all());
    }

    public function testUpdateChangesTheValueOfObjectInDatabase()
    {
        $this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);

        $this->assertEquals(1, $this->model->update());
    }

    public function testCreateObjectInDatabase()
    {
        $this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);

        $this->assertEquals(1, $this->model->create());
    }

    public function testSaveShouldCreateNewModelInDatabaseWhenIdNotPresent()

This method seems to be duplicated in your project.

    {
        $this->model->setProperties(['name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
        $this->assertEquals(1, $this->model->save());
    }

    public function testSaveShouldUpdateModelInDatabaseIfIdIsPresent()
    {
        $this->model->setProperties(['id' => 2, 'name' => 'pyjac', 'age' => '419']);
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);
        $this->assertEquals(1, $this->model->save());
    }

    public function testGetPropertiesReturnsExpectedArrayValues()
    {
        $values = ['id' => 2, 'name' => 'pyjac', 'age' => '419'];
        $this->model->setProperties($values);

        $this->assertEquals($values, $this->model->getProperties());
    }

    public function testDeleteReturnsTrueWhenModelIsSuccessfullyRemovedFromDatabase()

This method seems to be duplicated in your project.

    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(1);

        $this->assertEquals(true, $this->model->delete(1));
    }

    public function testDeleteReturnsFalseWhenModelWasNotDeletedFromDatabase()

This method seems to be duplicated in your project.

    {
        $this->databaseConnection->shouldReceive('prepare')->once()->andReturn($this->sqlStatement);
        $this->sqlStatement->shouldReceive('execute');
        $this->sqlStatement->shouldReceive('rowCount')->once()->andReturn(0);

        $this->assertEquals(false, $this->model->delete(1));
    }

    public function testMagicMethodsReturnCorrectResult()
    {
        $this->model->id = '10';

Accessing id on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->name = 'Pyjac';

Accessing name on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->age = '60';

Accessing age on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals($this->model->name, 'Pyjac');

Accessing name on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals($this->model->id, '10');

Accessing id on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals($this->model->age, '60');

Accessing age on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function testCreateModelWithNoParameter()
    {
        $model = $this->getMockForAbstractClass('Pyjac\ORM\Model');
        $this->assertInstanceOf(\Pyjac\ORM\Model::class, $model);
    }
}