Model::update() - Code Metrics - Inspection of "Initial commit" - andela-joyebanji/PotatoORM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (32cfca)

by Oyebanji Jacob

created 2016-03-03 15:36 UTC

Model::update() B

↳ Parent: Model

Complexity

Conditions	6
Paths	12

Size

Total Lines	24
Code Lines	18

Duplication

Lines	24
Ratio	100 %

Metric	Value
dl	24
loc	24
rs	8.5125
cc	6
eloc	18
nc	12
nop	0

<?php 

namespace Pyjac\ORM;

abstract class Model implements ModelInterface

{

   
    protected  $properties = [];

    /**
     * Store instance of database connection used.
    * @var [type]
    */
    protected  $databaseConnection;

     public function __construct()
    {
        $this->databaseConnection = DatabaseConnection::getInstance()->databaseConnection;
        //$databaseConnection->databaseConnection->connect();

    }
    /**
    * @param string $key rep column name
    * @param string $val rep column value
    * sets into $propertie the $key => $value pairs
    */
    public  function __set($key, $val)
    {
        $this->properties[$key] = $val;
    }
    /**
    * @param string $key reps the column name
    * @return $key and $value

    */
    public function __get($key)
    {
        return $this->properties[$key];
    }
    /**
     * Get all the model properties
     *
     * @return array
     */
     public function getProperties()
     {
         return $this->properties;
     }
    /**
    * Gets the name of the child class only
    * without the namespace
    * @var $className
    * @var $table
    * @return $table

    */
    public function getTableName()
    {
        $className = explode('\\', get_called_class());
        $table = strtolower(end($className) .'s');
        return $table;
    }
    /**
    * returns a particular record
    * @param $id reps the record id
    * @param $connection initialised to null
    * @return object
    */
    public static function find($id)
    {
        $model = new static;
        return $model->get($id); 
    }
    /**
    * returns a particular record
    * @param $id reps the record id
    * @param $connection initialised to null
    * @return object
    */
    public function get($id)
    {
        $sql = "SELECT * FROM {$this->getTableName()} WHERE id={$id}";
        $sqlStatement = $this->databaseConnection->prepare($sql);
        $sqlStatement->setFetchMode($this->databaseConnection::FETCH_CLASS, get_called_class());
        $sqlStatement->execute();
        if($sqlStatement->rowCount() < 1){
            throw new ModelNotFoundException($id);
        }
        return $sqlStatement->fetch();
    }
    
    public static function getAll()
    {
        $model = new static;
        return $model->all();
    }

    public function all()
    {
        $sql = "SELECT * FROM {$this->getTableName()}";
        $row = $this->databaseConnection->prepare($sql);
        $row->execute();
       
        return $row->fetchAll($this->databaseConnection::FETCH_CLASS);

    }
    /** update table with instance properties
    *
    */
    private function update()
    {
        $connection = $this->getConnection();
        $columnNames = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $columnValues = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $count = 0;
        $update = "UPDATE " . $this->getTableName() . " SET " ;
        foreach ($this->properties as $key => $val) {
            $count++;
            if(($key == 'id')) continue;
            $update .= "$key = '$val'";
            if ($count < count($this->properties) )
            {
                $update .=",";
            }
        }
        $update .= " WHERE id = " . $this->properties['id'];
        $stmt = $connection->prepare($update);
            foreach ($this->properties as $key => $val) {
                if($key == 'id') continue;
            }
        $stmt->execute();
        return $stmt->rowCount();
    }
    /**
    * insert instance data into the table
    */
    private function create()
    {
        $connection = $this->getConnection();
        $columnNames = "";
        $columnValues = "";
        $count = 0;
        $create = "INSERT" . " INTO " . $this->getTableName()." (";
            foreach ($this->properties as $key => $val) {
                $columnNames .= $key;
                $columnValues .= ':' . $key;
                $count++;
                if ($count < count($this->properties))
                {
                    $columnNames .= ', ';
                    $columnValues .= ', ';
                }
            }
        $create .= $columnNames.') VALUES (' .$columnValues.')';
        $stmt = $connection->prepare($create);
            foreach ($this->properties as $key => $val) {
                $stmt->bindValue(':'.$key, $val);
            }
            try {
                // if prop returned and props from db differ throw exception
                $stmt->execute();
            } catch(PDOException $e){

                return $e->getExceptionMessage();
            }
        return $stmt->rowCount();
    }
    /**
    * get db connection
    */
    public function getConnection($connection = null)
    {
        if(is_null($connection))
        {
            return new Connection();
        }
    }
    /**
    * checks if the id exists
    * update if exist
    * create if not exist
    */
    public function save()
    {
        if ($this->id) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->update();
        } else {
            $this->create();
        }
    }
    /**
    * @param row reps record id
    * @param $connection initialised to null
    * @return boolean
    */
    public static function destroy($id)
    {
        
        $sql = "DELETE" . " FROM " . self::getTableName()." WHERE id = ". $id;
        $delete = $connection->prepare($sql);

        $delete->execute();
        $count = $delete->rowCount();
        if ($count < 1) {
            throw new RecordNotFoundException('Record with id ' . $id . ' does not exist.');
        }
        return ($count > 0) ? true : false;
    }

    /**
     * Handle dynamic static method calls into the method.
     *
     * @param  string  $method
     * @param  array  $parameters
     * @return mixed
     */
    public static function __callStatic($method, $parameters)

    {
        exit("HERE");
        $instance = new static;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

        return call_user_func_array([$instance, $method], $parameters);
    }   
}

1		<?php
2
3		namespace Pyjac\ORM;
4
5	View Code Duplication	abstract class Model implements ModelInterface
		0 ignored issues – show Duplication introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
6		{
7
8
9		protected $properties = [];
10
11		/**
12		* Store instance of database connection used.
13		* @var [type]
14		*/
15		protected $databaseConnection;
16
17		public function __construct()
18		{
19		$this->databaseConnection = DatabaseConnection::getInstance()->databaseConnection;
20		//$databaseConnection->databaseConnection->connect();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
21		}
22		/**
23		* @param string $key rep column name
24		* @param string $val rep column value
25		* sets into $propertie the $key => $value pairs
26		*/
27		public function __set($key, $val)
28		{
29		$this->properties[$key] = $val;
30		}
31		/**
32		* @param string $key reps the column name
33		* @return $key and $value
		0 ignored issues – show Documentation introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The doc-type `$key` could not be parsed: Unknown type name "$key" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
34		*/
35		public function __get($key)
36		{
37		return $this->properties[$key];
38		}
39		/**
40		* Get all the model properties
41		*
42		* @return array
43		*/
44		public function getProperties()
45		{
46		return $this->properties;
47		}
48		/**
49		* Gets the name of the child class only
50		* without the namespace
51		* @var $className
52		* @var $table
53		* @return $table
		0 ignored issues – show Documentation introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The doc-type `$table` could not be parsed: Unknown type name "$table" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
54		*/
55		public function getTableName()
56		{
57		$className = explode('\\', get_called_class());
58		$table = strtolower(end($className) .'s');
59		return $table;
60		}
61		/**
62		* returns a particular record
63		* @param $id reps the record id
64		* @param $connection initialised to null
65		* @return object
66		*/
67		public static function find($id)
68		{
69		$model = new static;
70		return $model->get($id);
71		}
72		/**
73		* returns a particular record
74		* @param $id reps the record id
75		* @param $connection initialised to null
76		* @return object
77		*/
78		public function get($id)
79		{
80		$sql = "SELECT * FROM {$this->getTableName()} WHERE id={$id}";
81		$sqlStatement = $this->databaseConnection->prepare($sql);
82		$sqlStatement->setFetchMode($this->databaseConnection::FETCH_CLASS, get_called_class());
83		$sqlStatement->execute();
84		if($sqlStatement->rowCount() < 1){
85		throw new ModelNotFoundException($id);
86		}
87		return $sqlStatement->fetch();
88		}
89
90		public static function getAll()
91		{
92		$model = new static;
93		return $model->all();
94		}
95
96		public function all()
97		{
98		$sql = "SELECT * FROM {$this->getTableName()}";
99		$row = $this->databaseConnection->prepare($sql);
100		$row->execute();
101
102		return $row->fetchAll($this->databaseConnection::FETCH_CLASS);
103
104		}
105		/** update table with instance properties
106		*
107		*/
108		private function update()
109		{
110		$connection = $this->getConnection();
111		$columnNames = "";
		0 ignored issues – show Unused Code introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report `$columnNames` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
112		$columnValues = "";
		0 ignored issues – show Unused Code introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report `$columnValues` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
113		$count = 0;
114		$update = "UPDATE " . $this->getTableName() . " SET " ;
115		foreach ($this->properties as $key => $val) {
116		$count++;
117		if(($key == 'id')) continue;
118		$update .= "$key = '$val'";
119		if ($count < count($this->properties) )
120		{
121		$update .=",";
122		}
123		}
124		$update .= " WHERE id = " . $this->properties['id'];
125		$stmt = $connection->prepare($update);
126		foreach ($this->properties as $key => $val) {
127		if($key == 'id') continue;
128		}
129		$stmt->execute();
130		return $stmt->rowCount();
131		}
132		/**
133		* insert instance data into the table
134		*/
135		private function create()
136		{
137		$connection = $this->getConnection();
138		$columnNames = "";
139		$columnValues = "";
140		$count = 0;
141		$create = "INSERT" . " INTO " . $this->getTableName()." (";
142		foreach ($this->properties as $key => $val) {
143		$columnNames .= $key;
144		$columnValues .= ':' . $key;
145		$count++;
146		if ($count < count($this->properties))
147		{
148		$columnNames .= ', ';
149		$columnValues .= ', ';
150		}
151		}
152		$create .= $columnNames.') VALUES (' .$columnValues.')';
153		$stmt = $connection->prepare($create);
154		foreach ($this->properties as $key => $val) {
155		$stmt->bindValue(':'.$key, $val);
156		}
157		try {
158		// if prop returned and props from db differ throw exception
159		$stmt->execute();
160		} catch(PDOException $e){
		0 ignored issues – show Bug introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The class `Pyjac\ORM\PDOException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
161		return $e->getExceptionMessage();
162		}
163		return $stmt->rowCount();
164		}
165		/**
166		* get db connection
167		*/
168		public function getConnection($connection = null)
169		{
170		if(is_null($connection))
171		{
172		return new Connection();
173		}
174		}
175		/**
176		* checks if the id exists
177		* update if exist
178		* create if not exist
179		*/
180		public function save()
181		{
182		if ($this->id) {
		0 ignored issues – show Documentation introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Pyjac\ORM\Model>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
183		$this->update();
184		} else {
185		$this->create();
186		}
187		}
188		/**
189		* @param row reps record id
190		* @param $connection initialised to null
191		* @return boolean
192		*/
193		public static function destroy($id)
194		{
195
196		$sql = "DELETE" . " FROM " . self::getTableName()." WHERE id = ". $id;
197		$delete = $connection->prepare($sql);
		0 ignored issues – show Bug introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The variable `$connection` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
198		$delete->execute();
199		$count = $delete->rowCount();
200		if ($count < 1) {
201		throw new RecordNotFoundException('Record with id ' . $id . ' does not exist.');
202		}
203		return ($count > 0) ? true : false;
204		}
205
206		/**
207		* Handle dynamic static method calls into the method.
208		*
209		* @param string $method
210		* @param array $parameters
211		* @return mixed
212		*/
213		public static function __callStatic($method, $parameters)
		0 ignored issues – show Unused Code introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The parameter `$method` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report The parameter `$parameters` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
214		{
215		exit("HERE");
216		$instance = new static;
		0 ignored issues – show Unused Code introduced 2016-03-03 15:39 UTC by Report Bug Copy Issue Report `$instance = new static();` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
217
218		return call_user_func_array([$instance, $method], $parameters);
219		}
220		}

andela-joyebanji / PotatoORM

Branch — develop (32cfca)

Model::update() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like