VideoRepository::authorized() - Code Metrics - Inspection of "(fix) add github repo link on footer" - andela-jkariuki/checkpoint-four-learn-party - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — staging ( cae1a4...5c66ea )

by John

created 2016-03-21 14:34 UTC

VideoRepository::authorized() A

↳ Parent: VideoRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	1

<?php

namespace LearnParty\Http\Repositories;

use LearnParty\Video;
use LearnParty\Comment;
use LearnParty\Favorite;
use LearnParty\User;
use Auth;

class VideoRepository
{
    /**
     * Get a single video
     *
     * @return void
     */
    public function getVideo($id)
    {
        return Video::findOrFail($id);
    }

    /**
     * Update the number of views by one everytime a video is viewed
     *
     * @param  Integer $id video Id
     * @return voi
     */
    public function updateViews($id)
    {
        Video::find($id)->increment('views');
    }

    /**
     * Return all comments as well as the respective users
     *
     * @param  integer $videoId Video Id
     * @return Object           Comments collection
     */
    public function getAllComments($videoId)
    {
        return Comment::where('video_id', $videoId)->get();
        $comments = $comments->each(function ($comment, $key) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            $comment['user'] = User::find($comment->user_id);
        });
    }

    /**
     * Parse the Youtube Url.
     *
     * @param  string  $url Youtube Url
     * @return string       Embed link
     */
    public function makeYoutubeUrl($url)
    {
        return substr(parse_url($url)['query'], 2, 11);
    }

    /**
     * Return true if a user has liked a video and
     * false if the user has not liked the vide.
     *
     * @param  Collection $video Video collection
     * @return boolean           True or false
     */
    public function getLikeStatus($video)
    {
        if (Auth::user()) {
            $favorites = $video->favorites;
            foreach ($favorites as $key => $favorite) {
                if ($favorite->user_id === Auth::user()->id) {
                    return true;
                }
            }
        }
        return false;
    }

    /**
     * Favorite a video.
     *
     * @param  Request $request User request
     * @return array            New favorite message
     */
    public function favoriteVideo($request)
    {
        Favorite::create($request);
        return [
            'status' => 200,
            'message' => 'favorited'
        ];
    }

    /**
     * Unfavorite a video.
     *
     * @param  Request $request User request
     * @return array            New unfavorite message
     */
    public function unfavoriteVideo($request)
    {
        $favorited = Favorite::where('user_id', Auth::user()->id)
              ->where('video_id', $request['video_id'])
              ->delete();

        if ($favorited) {
            return [
                'status' => 200,
                'message' => 'unfavorited'
            ];
        }

        return [
            'status' => 400,
            'message' => 'error. Something went wrong. Please try again'
        ];
    }

    /**
     * If the person trying to edit or delete a video is not the
     * owner, redirect to the homepage
     *
     * @param  Object $video Video collection
     * @return boolean        true if valid, otherwise false
     */
    public function authorized($video)
    {
        if (Auth::user()->id == $video->user_id) {
            return true;
        }

        return false;
    }

    /**
     * Get the most popular videos in the followin categories
     * Liked
     * commented on
     * Favorited
     *
     * @return array  top popular videos
     */
    public function getTopPopularVideos($number = 3)
    {
        $topViewed = Video::orderBy('views', 'DESC')->get()->take($number);

        $topFavorited = Video::all()->each(function ($video, $key) {

            $video->favorites = $video->favorites->count();
        })->sortByDesc('favorites')->take($number);

        $topCommentedOn = Video::all()->each(function ($video, $key) {

            $video->comments = $video->comments->count();
        })->sortByDesc('comments')->take($number);

        $topUsers = User::all()->each(function ($user, $key) {

            $user->videos = $user->videos->count();
        })->sortByDesc('videos')->take(5);

        return [
            'topViewed' => $topViewed,
            'topFavorited' => $topFavorited,
            'topCommentedOn' => $topCommentedOn,
            'topUsers' => $topUsers,
        ];
    }
}


1			<?php
2
3			namespace LearnParty\Http\Repositories;
4
5			use LearnParty\Video;
6			use LearnParty\Comment;
7			use LearnParty\Favorite;
8			use LearnParty\User;
9			use Auth;
10
11			class VideoRepository
12			{
13			/**
14			* Get a single video
15			*
16			* @return void
17			*/
18			public function getVideo($id)
19			{
20			return Video::findOrFail($id);
21			}
22
23			/**
24			* Update the number of views by one everytime a video is viewed
25			*
26			* @param Integer $id video Id
27			* @return voi
28			*/
29			public function updateViews($id)
30			{
31			Video::find($id)->increment('views');
32			}
33
34			/**
35			* Return all comments as well as the respective users
36			*
37			* @param integer $videoId Video Id
38			* @return Object Comments collection
39			*/
40			public function getAllComments($videoId)
41			{
42			return Comment::where('video_id', $videoId)->get();
43			$comments = $comments->each(function ($comment, $key) {
			0 ignored issues – show Unused Code introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report `$comments = $comments->e...$comment->user_id); });` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history... Unused Code introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report `$comments` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
44			$comment['user'] = User::find($comment->user_id);
45			});
46			}
47
48			/**
49			* Parse the Youtube Url.
50			*
51			* @param string $url Youtube Url
52			* @return string Embed link
53			*/
54			public function makeYoutubeUrl($url)
55			{
56			return substr(parse_url($url)['query'], 2, 11);
57			}
58
59			/**
60			* Return true if a user has liked a video and
61			* false if the user has not liked the vide.
62			*
63			* @param Collection $video Video collection
64			* @return boolean True or false
65			*/
66			public function getLikeStatus($video)
67			{
68			if (Auth::user()) {
69			$favorites = $video->favorites;
70			foreach ($favorites as $key => $favorite) {
71			if ($favorite->user_id === Auth::user()->id) {
72			return true;
73			}
74			}
75			}
76			return false;
77			}
78
79			/**
80			* Favorite a video.
81			*
82			* @param Request $request User request
83			* @return array New favorite message
84			*/
85			public function favoriteVideo($request)
86			{
87			Favorite::create($request);
88			return [
89			'status' => 200,
90			'message' => 'favorited'
91			];
92			}
93
94			/**
95			* Unfavorite a video.
96			*
97			* @param Request $request User request
98			* @return array New unfavorite message
99			*/
100			public function unfavoriteVideo($request)
101			{
102			$favorited = Favorite::where('user_id', Auth::user()->id)
103			->where('video_id', $request['video_id'])
104			->delete();
105
106			if ($favorited) {
107			return [
108			'status' => 200,
109			'message' => 'unfavorited'
110			];
111			}
112
113			return [
114			'status' => 400,
115			'message' => 'error. Something went wrong. Please try again'
116			];
117			}
118
119			/**
120			* If the person trying to edit or delete a video is not the
121			* owner, redirect to the homepage
122			*
123			* @param Object $video Video collection
124			* @return boolean true if valid, otherwise false
125			*/
126			public function authorized($video)
127			{
128			if (Auth::user()->id == $video->user_id) {
129			return true;
130			}
131
132			return false;
133			}
134
135			/**
136			* Get the most popular videos in the followin categories
137			* Liked
138			* commented on
139			* Favorited
140			*
141			* @return array top popular videos
142			*/
143			public function getTopPopularVideos($number = 3)
144			{
145			$topViewed = Video::orderBy('views', 'DESC')->get()->take($number);
146
147			$topFavorited = Video::all()->each(function ($video, $key) {
			0 ignored issues – show Unused Code introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
148			$video->favorites = $video->favorites->count();
149			})->sortByDesc('favorites')->take($number);
150
151			$topCommentedOn = Video::all()->each(function ($video, $key) {
			0 ignored issues – show Unused Code introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
152			$video->comments = $video->comments->count();
153			})->sortByDesc('comments')->take($number);
154
155			$topUsers = User::all()->each(function ($user, $key) {
			0 ignored issues – show Unused Code introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
156			$user->videos = $user->videos->count();
157			})->sortByDesc('videos')->take(5);
158
159			return [
160			'topViewed' => $topViewed,
161			'topFavorited' => $topFavorited,
162			'topCommentedOn' => $topCommentedOn,
163			'topUsers' => $topUsers,
164			];
165			}
166			}
167

andela-jkariuki / checkpoint-four-learn-party

Push — staging ( cae1a4...5c66ea )

VideoRepository::authorized() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like