VideoController::show() - Code Metrics - andela-jkariuki/checkpoint-four-learn-party - Measure and Improve Code Quality continuously with Scrutinizer

VideoController::show() A
last analyzed 2016-05-25 18:33 UTC

↳ Parent: VideoController

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	2	Features	2

Metric	Value
c	7
b	2
f	2
dl	0
loc	16
rs	9.4285
cc	1
eloc	9
nc	1
nop	1

<?php

namespace LearnParty\Http\Controllers;

use Illuminate\Http\Request;
use LearnParty\Http\Requests;
use LearnParty\Video;
use LearnParty\Comment;
use LearnParty\User;

class VideoController extends Controller
{
    /**
     * Show a single video, comments, favorites, views and categories
     *
     * @param  Integer $id Video Id
     * @return View
     */
    public function show($id)
    {
        $video = $this->videoRepository->getVideo($id);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $user = $video->user;
        $categories = $video->categories;
        $favorites = $video->favorites;

        $likesVideo = $this->videoRepository->getLikeStatus($video);

        $comments = $this->videoRepository->getAllComments($id);

        $this->videoRepository->updateViews($id);

        return view('video.video', compact('video', 'categories', 'comments', 'user', 'favorites', 'likesVideo'));
    }
}


1			<?php
2
3			namespace LearnParty\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use LearnParty\Http\Requests;
7			use LearnParty\Video;
8			use LearnParty\Comment;
9			use LearnParty\User;
10
11			class VideoController extends Controller
12			{
13			/**
14			* Show a single video, comments, favorites, views and categories
15			*
16			* @param Integer $id Video Id
17			* @return View
18			*/
19			public function show($id)
20			{
21			$video = $this->videoRepository->getVideo($id);
			0 ignored issues – show Bug introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$video` is correct as `$this->videoRepository->getVideo($id)` (which targets `LearnParty\Http\Reposito...oRepository::getVideo()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22
23			$user = $video->user;
24			$categories = $video->categories;
25			$favorites = $video->favorites;
26
27			$likesVideo = $this->videoRepository->getLikeStatus($video);
28
29			$comments = $this->videoRepository->getAllComments($id);
30
31			$this->videoRepository->updateViews($id);
32
33			return view('video.video', compact('video', 'categories', 'comments', 'user', 'favorites', 'likesVideo'));
34			}
35			}
36

andela-jkariuki / checkpoint-four-learn-party

VideoController::show() A last analyzed 2016-05-25 18:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

VideoController::show() A
last analyzed 2016-05-25 18:33 UTC