FavoritesController::update() - Code Metrics - andela-jkariuki/checkpoint-four-learn-party - Measure and Improve Code Quality continuously with Scrutinizer

FavoritesController::update() A
last analyzed 2016-05-25 18:33 UTC

↳ Parent: FavoritesController

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	13
rs	9.4285
cc	2
eloc	8
nc	2
nop	1

<?php

namespace LearnParty\Http\Controllers;

use Illuminate\Http\Request;
use LearnParty\Http\Requests;
use LearnParty\Favorite;
use LearnParty\Video;
use Auth;

class FavoritesController extends Controller
{
    /**
     * Add a new favorite if it does not exist and
     * remove it if does exist
     *
     * @param  Request $request User request
     * @return array           favorite or unfavorite message
     */
    public function update(Request $request)
    {
        $request['user_id'] = Auth::user()->id;
        $favorite = Favorite::where('user_id', Auth::user()->id)
                       ->where('video_id', $request->input('video_id'))
                       ->get();

        if ($favorite->count() === 0) {
            return $this->videoRepository->favoriteVideo($request->all());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $this->videoRepository->unFavoriteVideo($request->all());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace LearnParty\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use LearnParty\Http\Requests;
7			use LearnParty\Favorite;
8			use LearnParty\Video;
9			use Auth;
10
11			class FavoritesController extends Controller
12			{
13			/**
14			* Add a new favorite if it does not exist and
15			* remove it if does exist
16			*
17			* @param Request $request User request
18			* @return array favorite or unfavorite message
19			*/
20			public function update(Request $request)
21			{
22			$request['user_id'] = Auth::user()->id;
23			$favorite = Favorite::where('user_id', Auth::user()->id)
24			->where('video_id', $request->input('video_id'))
25			->get();
26
27			if ($favorite->count() === 0) {
28			return $this->videoRepository->favoriteVideo($request->all());
			0 ignored issues – show Documentation introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report `$request->all()` is of type `array`, but the function expects a `object<LearnParty\Http\Repositories\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			}
30
31			return $this->videoRepository->unFavoriteVideo($request->all());
			0 ignored issues – show Documentation introduced 2016-03-20 14:16 UTC by Report Bug Copy Issue Report `$request->all()` is of type `array`, but the function expects a `object<LearnParty\Http\Repositories\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			}
33			}
34

andela-jkariuki / checkpoint-four-learn-party

FavoritesController::update() A last analyzed 2016-05-25 18:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FavoritesController::update() A
last analyzed 2016-05-25 18:33 UTC