for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace LearnParty\Http\Controllers;
use Illuminate\Http\Request;
use LearnParty\Http\Requests;
use Auth;
class CommentController extends Controller
{
/**
* Add a new comment to a video
*
* @param Request $request
* @return array success or failure message
*/
public function create(Request $request)
$this->validate($request, [
'comment' => 'required|max:500',
]);
$newComment = Auth::user()->comments()->create($request->all());
$newComment
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
return [
'status' => 200,
'message' => 'New comment succesfully added.'
];
}
andela-jkariuki /
checkpoint-four-learn-party
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.