Issues in RoutesTest.php (master) - Issues in master - andela-iadeniyi/emojinaija - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

test/RoutesTest.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Ibonly\NaijaEmoji\Test;

use Dotenv\Dotenv;
use GuzzleHttp\Client;
use Ibonly\NaijaEmoji\Emoji;
use PHPUnit_Framework_TestCase;
use Ibonly\NaijaEmoji\AuthController;
use GuzzleHttp\Exception\ClientException;

class RoutesTest extends PHPUnit_Framework_TestCase
{
    protected $url;
    protected $token;
    protected $client;

    public function __construct ()
    {
        $this->emoji = new Emoji();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $auth = new AuthController();

        $this->token = $auth->getTestToken();
        $this->url = $auth->getAuthUrl();
    }

    public function setUp ()
    {
        $this->client = new Client();
    }

    public function getTestId ()
    {
        return $this->emoji->where(['name' => 'TestName'])->getData('id');
    }

    /**
     * testInvalidEndpoint
     */
    public function testInvalidEndpoint()
    {
        $this->setExpectedException("GuzzleHttp\Exception\ClientException");

        $request = $this->client->request('GET', $this->url.'/emogis');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /**
     * Test if the ouput of getAll is an object
     */
    public function testGetAllEmoji ()

    {
        $request = $this->client->request('GET', $this->url.'/emojis');

        $this->assertInternalType("object", $request->getBody());
        $this->assertEquals(200, $request->getStatusCode());
    }

    /**
     * Test get a single emoji endpoint
     */
    public function testGetSingleEmoji ()

    {
        $request = $this->client->request('GET', $this->url.'/emojis/3');

        $this->assertInternalType("object", $request->getBody());
        $this->assertEquals(200, $request->getStatusCode());
    }

    /**
     * Test Post endpoint
     */
    public function testPOSTEmoji()
    {
        $data = array(
            'name' => 'TestEmojiName',
            'char' => '🎃',
            'keywords' => "apple, friut, mac",
            'category' => 'fruit'
        );
        $request = $this->client->request('POST', $this->url.'/emojis',[ 'headers' => ['Authorization'=> $this->token],'form_params' => $data ]);

        $this->assertInternalType('object' , $request);
        $this->assertEquals('200', $request->getStatusCode());
    }

    /**
     * Test if Authorization Header is set
     */
    public function testPostIfAuthorizationNotSet ()
    {
        $data = array(
            'name' => 'TestEmojiName',
            'char' => '🎃',
            'keywords' => "apple, friut, mac",
            'category' => 'fruit'
        );

        $this->setExpectedException("GuzzleHttp\Exception\ClientException");

        $request = $this->client->request('POST', $this->url.'/emojis', ['form_params' => $data]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    }

    /**
     * Test PUT/PATCH emoji
     */
    public function testPutPatchEmoji ()
    {
        $data = array(
            'name' => 'TestName'
        );
        $request = $this->client->request('PUT', $this->url.'/emojis/'.$this->getTestId(),[ 'headers' => ['Authorization'=> $this->token],'form_params' => $data ]);

        $this->assertInternalType('object' , $request);
        $this->assertEquals('200', $request->getStatusCode());
    }

    /**
     * Test DELETE an emoji
     */
    public function testDeleteEmoji()
    {

        $this->assertInternalType('integer', $this->getTestId());
        // $data = array(

        //     'id' => '1'

        // );
        // $this->request = $this->client->get('/emojis');

        // $request = $this->client->delete('/emojis/2', $this->request->getUrl(), json_encode($data));

        // $response = $request->send();

        // $this->assertEquals(406, $response->getStatusCode());

    }
}


1		<?php
2
3		namespace Ibonly\NaijaEmoji\Test;
4
5		use Dotenv\Dotenv;
6		use GuzzleHttp\Client;
7		use Ibonly\NaijaEmoji\Emoji;
8		use PHPUnit_Framework_TestCase;
9		use Ibonly\NaijaEmoji\AuthController;
10		use GuzzleHttp\Exception\ClientException;
11
12		class RoutesTest extends PHPUnit_Framework_TestCase
13		{
14		protected $url;
15		protected $token;
16		protected $client;
17
18		public function __construct ()
19		{
20		$this->emoji = new Emoji();
		0 ignored issues – show Bug introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `emoji` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21		$auth = new AuthController();
22
23		$this->token = $auth->getTestToken();
24		$this->url = $auth->getAuthUrl();
25		}
26
27		public function setUp ()
28		{
29		$this->client = new Client();
30		}
31
32		public function getTestId ()
33		{
34		return $this->emoji->where(['name' => 'TestName'])->getData('id');
35		}
36
37		/**
38		* testInvalidEndpoint
39		*/
40		public function testInvalidEndpoint()
41		{
42		$this->setExpectedException("GuzzleHttp\Exception\ClientException");
43
44		$request = $this->client->request('GET', $this->url.'/emogis');
		0 ignored issues – show Unused Code introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$request` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
45		}
46
47		/**
48		* Test if the ouput of getAll is an object
49		*/
50	View Code Duplication	public function testGetAllEmoji ()
		0 ignored issues – show Duplication introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$request = $this->client->request('GET', $this->url.'/emojis');
53
54		$this->assertInternalType("object", $request->getBody());
55		$this->assertEquals(200, $request->getStatusCode());
56		}
57
58		/**
59		* Test get a single emoji endpoint
60		*/
61	View Code Duplication	public function testGetSingleEmoji ()
		0 ignored issues – show Duplication introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$request = $this->client->request('GET', $this->url.'/emojis/3');
64
65		$this->assertInternalType("object", $request->getBody());
66		$this->assertEquals(200, $request->getStatusCode());
67		}
68
69		/**
70		* Test Post endpoint
71		*/
72		public function testPOSTEmoji()
73		{
74		$data = array(
75		'name' => 'TestEmojiName',
76		'char' => '🎃',
77		'keywords' => "apple, friut, mac",
78		'category' => 'fruit'
79		);
80		$request = $this->client->request('POST', $this->url.'/emojis',[ 'headers' => ['Authorization'=> $this->token],'form_params' => $data ]);
81
82		$this->assertInternalType('object' , $request);
83		$this->assertEquals('200', $request->getStatusCode());
84		}
85
86		/**
87		* Test if Authorization Header is set
88		*/
89		public function testPostIfAuthorizationNotSet ()
90		{
91		$data = array(
92		'name' => 'TestEmojiName',
93		'char' => '🎃',
94		'keywords' => "apple, friut, mac",
95		'category' => 'fruit'
96		);
97
98		$this->setExpectedException("GuzzleHttp\Exception\ClientException");
99
100		$request = $this->client->request('POST', $this->url.'/emojis', ['form_params' => $data]);
		0 ignored issues – show Unused Code introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$request` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
101
102		}
103
104		/**
105		* Test PUT/PATCH emoji
106		*/
107		public function testPutPatchEmoji ()
108		{
109		$data = array(
110		'name' => 'TestName'
111		);
112		$request = $this->client->request('PUT', $this->url.'/emojis/'.$this->getTestId(),[ 'headers' => ['Authorization'=> $this->token],'form_params' => $data ]);
113
114		$this->assertInternalType('object' , $request);
115		$this->assertEquals('200', $request->getStatusCode());
116		}
117
118		/**
119		* Test DELETE an emoji
120		*/
121		public function testDeleteEmoji()
122		{
123
124		$this->assertInternalType('integer', $this->getTestId());
125		// $data = array(
		0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
126		// 'id' => '1'
		0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
127		// );
128		// $this->request = $this->client->get('/emojis');
		0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `57%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
129		// $request = $this->client->delete('/emojis/2', $this->request->getUrl(), json_encode($data));
		0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
130		// $response = $request->send();
		0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
131		// $this->assertEquals(406, $response->getStatusCode());
		0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this `74%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
132		}
133		}
134

andela-iadeniyi / emojinaija

Issues (32)

Security Analysis no request data

test/RoutesTest.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like