Issues in UserController.php (master) - Issues in master - andela-iadeniyi/emojinaija - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

api/Controllers/UserController.php (5 issues)

Labels

Bug 5

Severity

Major 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * UserController Managers user activity login, register and logout
 *
 * @package Ibonly\NaijaEmoji\UserController
 * @author  Ibraheem ADENIYI <[email protected]>
 * @license MIT <https://opensource.org/licenses/MIT>
 */

namespace Ibonly\NaijaEmoji;

use Slim\Slim;
use Ibonly\NaijaEmoji\User;
use Ibonly\NaijaEmoji\UserInterface;
use Ibonly\NaijaEmoji\AuthController;
use Ibonly\PotatoORM\DataNotFoundException;
use Ibonly\NaijaEmoji\InvalidTokenException;
use Ibonly\NaijaEmoji\ProvideTokenException;
use Ibonly\NaijaEmoji\PasswordExistException;
use Ibonly\PotatoORM\DataAlreadyExistException;

class UserController implements UserInterface
{
    protected $user;
    protected $auth;

    public function __construct ()
    {
        $this->user = new User();
        $this->auth = new AuthController();
    }

    /**
     * createUser Create a new user
     *
     * @param  $app
     *
     * @return json
     */
    public function createUser (Slim $app)
    {
        $username = $app->request->params('username');
        $this->user->id = NULL;

        $this->user->username = $username;

        $this->user->password = $this->auth->passwordEncrypt($app->request->params('password'));

        $this->user->date_created = date('Y-m-d H:i:s');

        try
        {
            $save = $this->user->save();
            if( $save )
                $app->halt(201, json_encode(['message' => 'Registration Successful. Please Login to generate your token']));
        } catch ( DataAlreadyExistException $e ) {
            $app->halt(404, json_encode(['message' => 'User details already exist']));
        }
    }

    /**
     * login Log user in and generate token
     *
     * @param  $app
     *
     * @return json
     */
    public function login (Slim $app)
    {
        $app->response->headers->set('Content-Type', 'application/json');
        $username = $app->request->params('username');
        $password = $app->request->params('password');
        try
        {
            //check if username is available
            $login = $this->user->where(['username' => $username])->toJson();
            if( ! empty ($login) )
                $hashPassword = "";
                $output = json_decode($login);
                foreach( $output as $key )
                {
                    $output = $key->id;
                    $hashPassword = $key->password;
                }
                //confirm the password
                return $this->decryptPassword($username, $password, $hashPassword);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        } catch ( DataNotFoundException $e ) {
            $app->halt(404, json_encode(['message' => 'Not Found']));
        } catch ( PasswordException $e ) {
            return $e->errorMessage();
        }
    }

    /**
     * decryptPassword and return token
     *
     * @param  $user
     * @param  $password
     * @param  $hashPassword
     */
    public function decryptPassword ($username, $password, $hashPassword)
    {
        if( $this->auth->passwordDecrypt($password, $hashPassword) )
            return(json_encode([
                'Username' => $username,
                'Authorization' => $this->auth->authorizationEncode($username)
            ]));
    }
    /**
     * logout Log user out and destroy token
     *
     * @param  $app
     *
     * @return json
     */
    public function logout (Slim $app)
    {
        $app->response->headers->set('Content-Type', 'application/json');
        $tokenData = $app->request->headers->get('Authorization');
        try
        {
            if ( ! isset( $tokenData ) )
                throw new ProvideTokenException();

            $checkUser = $this->user->where(['username' => $tokenData->user])->toJson();
            if ( ! empty ($checkUser) )
                $this->auth->authorizationEncode(NULL);#
                $app->halt(200, json_encode(['message' => 'Logged out Successfully']));
        } catch ( DataNotFoundException $e) {
            $app->halt(404, json_encode(['message' => 'Not Found']));
        } catch ( InvalidTokenException $e ) {
            $app->halt(405, json_encode(['Message' => 'Invalid Token']));
        } catch ( ProvideTokenException $e ) {
            $app->halt(406, json_encode(['Message' => 'Enter a valid Token']));
        }
    }
}

1			<?php
2
3			/**
4			* UserController Managers user activity login, register and logout
5			*
6			* @package Ibonly\NaijaEmoji\UserController
7			* @author Ibraheem ADENIYI <[email protected]>
8			* @license MIT <https://opensource.org/licenses/MIT>
9			*/
10
11			namespace Ibonly\NaijaEmoji;
12
13			use Slim\Slim;
14			use Ibonly\NaijaEmoji\User;
15			use Ibonly\NaijaEmoji\UserInterface;
16			use Ibonly\NaijaEmoji\AuthController;
17			use Ibonly\PotatoORM\DataNotFoundException;
18			use Ibonly\NaijaEmoji\InvalidTokenException;
19			use Ibonly\NaijaEmoji\ProvideTokenException;
20			use Ibonly\NaijaEmoji\PasswordExistException;
21			use Ibonly\PotatoORM\DataAlreadyExistException;
22
23			class UserController implements UserInterface
24			{
25			protected $user;
26			protected $auth;
27
28			public function __construct ()
29			{
30			$this->user = new User();
31			$this->auth = new AuthController();
32			}
33
34			/**
35			* createUser Create a new user
36			*
37			* @param $app
38			*
39			* @return json
40			*/
41			public function createUser (Slim $app)
42			{
43			$username = $app->request->params('username');
44			$this->user->id = NULL;
			0 ignored issues – show Bug introduced 2015-11-26 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `id` does not seem to exist in `Ibonly\NaijaEmoji\User`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
45			$this->user->username = $username;
			0 ignored issues – show Bug introduced 2015-11-26 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `username` does not seem to exist in `Ibonly\NaijaEmoji\User`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
46			$this->user->password = $this->auth->passwordEncrypt($app->request->params('password'));
			0 ignored issues – show Bug introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `password` does not seem to exist in `Ibonly\NaijaEmoji\User`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
47			$this->user->date_created = date('Y-m-d H:i:s');
			0 ignored issues – show Bug introduced 2015-11-26 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `date_created` does not seem to exist in `Ibonly\NaijaEmoji\User`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
48			try
49			{
50			$save = $this->user->save();
51			if( $save )
52			$app->halt(201, json_encode(['message' => 'Registration Successful. Please Login to generate your token']));
53			} catch ( DataAlreadyExistException $e ) {
54			$app->halt(404, json_encode(['message' => 'User details already exist']));
55			}
56			}
57
58			/**
59			* login Log user in and generate token
60			*
61			* @param $app
62			*
63			* @return json
64			*/
65			public function login (Slim $app)
66			{
67			$app->response->headers->set('Content-Type', 'application/json');
68			$username = $app->request->params('username');
69			$password = $app->request->params('password');
70			try
71			{
72			//check if username is available
73			$login = $this->user->where(['username' => $username])->toJson();
74			if( ! empty ($login) )
75			$hashPassword = "";
76			$output = json_decode($login);
77			foreach( $output as $key )
78			{
79			$output = $key->id;
80			$hashPassword = $key->password;
81			}
82			//confirm the password
83			return $this->decryptPassword($username, $password, $hashPassword);
			0 ignored issues – show Bug introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$hashPassword` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
84			} catch ( DataNotFoundException $e ) {
85			$app->halt(404, json_encode(['message' => 'Not Found']));
86			} catch ( PasswordException $e ) {
87			return $e->errorMessage();
88			}
89			}
90
91			/**
92			* decryptPassword and return token
93			*
94			* @param $user
95			* @param $password
96			* @param $hashPassword
97			*/
98			public function decryptPassword ($username, $password, $hashPassword)
99			{
100			if( $this->auth->passwordDecrypt($password, $hashPassword) )
101			return(json_encode([
102			'Username' => $username,
103			'Authorization' => $this->auth->authorizationEncode($username)
104			]));
105			}
106			/**
107			* logout Log user out and destroy token
108			*
109			* @param $app
110			*
111			* @return json
112			*/
113			public function logout (Slim $app)
114			{
115			$app->response->headers->set('Content-Type', 'application/json');
116			$tokenData = $app->request->headers->get('Authorization');
117			try
118			{
119			if ( ! isset( $tokenData ) )
120			throw new ProvideTokenException();
121
122			$checkUser = $this->user->where(['username' => $tokenData->user])->toJson();
123			if ( ! empty ($checkUser) )
124			$this->auth->authorizationEncode(NULL);#
125			$app->halt(200, json_encode(['message' => 'Logged out Successfully']));
126			} catch ( DataNotFoundException $e) {
127			$app->halt(404, json_encode(['message' => 'Not Found']));
128			} catch ( InvalidTokenException $e ) {
129			$app->halt(405, json_encode(['Message' => 'Invalid Token']));
130			} catch ( ProvideTokenException $e ) {
131			$app->halt(406, json_encode(['Message' => 'Enter a valid Token']));
132			}
133			}
134			}

andela-iadeniyi / emojinaija

Issues (32)

Security Analysis no request data

api/Controllers/UserController.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like