Issues in AuthController.php (master) - Issues in master - andela-iadeniyi/emojinaija - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

api/Controllers/AuthController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * AuthController manages the authentication i.e generation of token
 *
 * @package Ibonly\NaijaEmoji\AuthController
 * @author  Ibraheem ADENIYI <[email protected]>
 * @license MIT <https://opensource.org/licenses/MIT>
 */

namespace Ibonly\NaijaEmoji;

use Exception;
use Slim\Slim;
use Dotenv\Dotenv;
use Firebase\JWT\JWT;
use Ibonly\NaijaEmoji\User;
use Ibonly\NaijaEmoji\AuthInterface;
use Ibonly\NaijaEmoji\InvalidTokenException;

class AuthController implements AuthInterface
{
    protected $key;
    protected $userID;
    protected $auth_url;
    protected $issued_by;

    public function __construct ()
    {
        $this->loadEnv();
        $this->key        = getenv('ISSUE_KEY');
        $this->issued_by  = getenv('ISSUED_BY');
        $this->auth_url   = getenv('AUTH_URL');
        $this->test_token = getenv('TEST_TOKEN');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * getKey Get the ISSUE_KEY value
     *
     * @return string
     */
    public function getKey ()
    {
        return $this->key;
    }

    /**
     * getIssuedBy Get the ISSUED_BY value
     *
     * @return string
     */
    public function getIssuedBy ()
    {
        return $this->issued_by;
    }

    /**
     * getAuthUrl Get the AUTH_URL value
     *
     * @return string
     */
    public function getAuthUrl ()
    {
        return $this->auth_url;
    }

    /**
     * getAuthUrl Get the TEST_TOKEN value
     *
     * @return string
     */
    public function getTestToken ()
    {
        return $this->test_token;
    }

    /**
     * authorizationEncode Generate token using $userID
     *
     * @param  $userID
     *
     * @return string
     */
    public function authorizationEncode ($userID)
    {
        if ( ! is_null($userID) )
            $token = array(
                "iss" => $this->getIssuedBy(),
                "aud" => $this->getAuthUrl(),
                "user" => $userID,
                "exp" => time() + 3600000
            );
            return JWT::encode($token, $this->getKey());
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * authorizationDecode Decode token
     *
     * @param  $token
     *
     * @return json
     */
    public function authorizationDecode ($token)
    {
        try
        {
            return JWT::decode($token, $this->getKey(), array('HS256'));
        } catch ( Exception $e) {
            throw new InvalidTokenException();
        }
    }

    /**
     * Encrypt user password
     *
     * @param  $password
     *
     * @return string
     */
    public function passwordEncrypt ($password)
    {
        $options = [
            'cost' => 11,
            'salt' => mcrypt_create_iv(22, MCRYPT_DEV_URANDOM),
        ];
        return password_hash($password, PASSWORD_BCRYPT, $options);
    }

    /**
     * Decrypt user password
     *
     * @param  $password
     *
     * @return bool
     */
    public function passwordDecrypt ($password, $hashPassword)
    {
        if ( password_verify($password, $hashPassword) )
        {
            return true;
        }
        throw new PasswordException();
    }

    /**
     * Load .env data
     */
    protected function loadEnv ()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ( ! getenv("APP_ENV"))
        {
            $dotenv = new Dotenv($_SERVER['DOCUMENT_ROOT']);
            $dotenv->load();
        }
    }
}


1			<?php
2
3			/**
4			* AuthController manages the authentication i.e generation of token
5			*
6			* @package Ibonly\NaijaEmoji\AuthController
7			* @author Ibraheem ADENIYI <[email protected]>
8			* @license MIT <https://opensource.org/licenses/MIT>
9			*/
10
11			namespace Ibonly\NaijaEmoji;
12
13			use Exception;
14			use Slim\Slim;
15			use Dotenv\Dotenv;
16			use Firebase\JWT\JWT;
17			use Ibonly\NaijaEmoji\User;
18			use Ibonly\NaijaEmoji\AuthInterface;
19			use Ibonly\NaijaEmoji\InvalidTokenException;
20
21			class AuthController implements AuthInterface
22			{
23			protected $key;
24			protected $userID;
25			protected $auth_url;
26			protected $issued_by;
27
28			public function __construct ()
29			{
30			$this->loadEnv();
31			$this->key = getenv('ISSUE_KEY');
32			$this->issued_by = getenv('ISSUED_BY');
33			$this->auth_url = getenv('AUTH_URL');
34			$this->test_token = getenv('TEST_TOKEN');
			0 ignored issues – show Bug introduced 2015-12-03 11:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `test_token` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
35			}
36
37			/**
38			* getKey Get the ISSUE_KEY value
39			*
40			* @return string
41			*/
42			public function getKey ()
43			{
44			return $this->key;
45			}
46
47			/**
48			* getIssuedBy Get the ISSUED_BY value
49			*
50			* @return string
51			*/
52			public function getIssuedBy ()
53			{
54			return $this->issued_by;
55			}
56
57			/**
58			* getAuthUrl Get the AUTH_URL value
59			*
60			* @return string
61			*/
62			public function getAuthUrl ()
63			{
64			return $this->auth_url;
65			}
66
67			/**
68			* getAuthUrl Get the TEST_TOKEN value
69			*
70			* @return string
71			*/
72			public function getTestToken ()
73			{
74			return $this->test_token;
75			}
76
77			/**
78			* authorizationEncode Generate token using $userID
79			*
80			* @param $userID
81			*
82			* @return string
83			*/
84			public function authorizationEncode ($userID)
85			{
86			if ( ! is_null($userID) )
87			$token = array(
88			"iss" => $this->getIssuedBy(),
89			"aud" => $this->getAuthUrl(),
90			"user" => $userID,
91			"exp" => time() + 3600000
92			);
93			return JWT::encode($token, $this->getKey());
			0 ignored issues – show Bug introduced 2015-11-26 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$token` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
94			}
95
96			/**
97			* authorizationDecode Decode token
98			*
99			* @param $token
100			*
101			* @return json
102			*/
103			public function authorizationDecode ($token)
104			{
105			try
106			{
107			return JWT::decode($token, $this->getKey(), array('HS256'));
108			} catch ( Exception $e) {
109			throw new InvalidTokenException();
110			}
111			}
112
113			/**
114			* Encrypt user password
115			*
116			* @param $password
117			*
118			* @return string
119			*/
120			public function passwordEncrypt ($password)
121			{
122			$options = [
123			'cost' => 11,
124			'salt' => mcrypt_create_iv(22, MCRYPT_DEV_URANDOM),
125			];
126			return password_hash($password, PASSWORD_BCRYPT, $options);
127			}
128
129			/**
130			* Decrypt user password
131			*
132			* @param $password
133			*
134			* @return bool
135			*/
136			public function passwordDecrypt ($password, $hashPassword)
137			{
138			if ( password_verify($password, $hashPassword) )
139			{
140			return true;
141			}
142			throw new PasswordException();
143			}
144
145			/**
146			* Load .env data
147			*/
148			protected function loadEnv ()
			0 ignored issues – show Coding Style introduced 2015-11-26 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `loadEnv` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
149			{
150			if ( ! getenv("APP_ENV"))
151			{
152			$dotenv = new Dotenv($_SERVER['DOCUMENT_ROOT']);
153			$dotenv->load();
154			}
155			}
156			}
157

andela-iadeniyi / emojinaija

Issues (32)

Security Analysis no request data

api/Controllers/AuthController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like