Issues in Model.php - New Issues - Inspection of "Merge pull request #14 from andela-iadeniyi/1.0.0" - andela-iadeniyi/Potato-ORM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 245fbf...00e192 )

by Adeniyi

created 2015-11-25 08:24 UTC

src/Helper/Model.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * PotatoORM manages the persistence of database CRUD operations.
 *
 * @package Ibonly\PotatoORM\Model
 * @author  Ibraheem ADENIYI <[email protected]>
 * @license MIT <https://opensource.org/licenses/MIT>
 */

namespace Ibonly\PotatoORM;

use PDO;
use Exception;
use PDOException;
use Ibonly\PotatoORM\GetData;
use Ibonly\PotatoORM\DatabaseQuery;
use Ibonly\PotatoORM\ModelInterface;
use Ibonly\PotatoORM\UserNotFoundException;
use Ibonly\PotatoORM\EmptyDatabaseException;
use Ibonly\PotatoORM\SaveUserExistException;
use Ibonly\PotatoORM\ColumnNotExistExeption;
use Ibonly\PotatoORM\InvalidConnectionException;

class Model extends DatabaseQuery implements ModelInterface
{
    //Inject the inflector trait
    use Inflector;

    /**
     * stripclassName()
     *
     * @return string
     */
    public static function stripclassName()
    {
        $className = strtolower(get_called_class());
        $nameOfClass = explode("\\", $className);
        return end($nameOfClass);
    }

    /**
     * getClassName()
     *
     * @return string
     */
    public static function getClassName()
    {
        return self::pluralize(self::stripclassName());
    }

    /**
     * getTableName()
     *
     * @return string
     */
    public static function getTableName($connection)
    {
        return DatabaseQuery::checkTableName(self::getClassName(), $connection);
    }

    /**
     * getALL()
     * Get all record from the database
     *
     * @return object
     */
    public function getALL($dbConnection = NULL)
    {
        $connection = DatabaseQuery::checkConnection($dbConnection);

        $sqlQuery = DatabaseQuery::selectAllQuery(self::getTableName($connection));
        $query = $connection->prepare($sqlQuery);
        $query->execute();
        if ( $query->rowCount() )
        {
            return new GetData($query->fetchAll($connection::FETCH_ASSOC));
        }
        throw new EmptyDatabaseException();
    }

    /**
     * where($data, $condition)
     * Get data from database where $data = $condition
     *
     * @return object
     */
    public function where($data, $condition = NULL, $dbConnection = NULL)
    {
        $databaseQuery = new DatabaseQuery();
        $connection = $databaseQuery->checkConnection($dbConnection);

        $sqlQuery = $databaseQuery->selectQuery(self::getTableName($connection), $data, $condition, $connection);
        $query = $connection->prepare($sqlQuery);
        $query->execute();
        if ( $query->rowCount() )
        {
            return new GetData($query->fetchAll($connection::FETCH_ASSOC));
        }
        throw new UserNotFoundException();
    }

    /**
     * find($value)
     * Find data from database where id = $value
     *
     * @return array
     */
    public static function find($value, $dbConnection = NULL)
    {
        $connection = DatabaseQuery::checkConnection($dbConnection);

        $sqlQuery = DatabaseQuery::selectQuery(self::getTableName($connection), ['id' => $value], NULL, $connection);
        $query = $connection->prepare($sqlQuery);
        $query->execute();
        if ( $query->rowCount() )
        {
            $found = new static;
            $found->id = $value;
            $found->data = $query->fetchAll($connection::FETCH_ASSOC);
            return $found;
        }
        throw new UserNotFoundException();
    }

    /**
     * save()
     * Insert data into database
     *
     * @return bool
     */
    public function save($dbConnection = NULL)

    {
        $connection = DatabaseQuery::checkConnection($dbConnection);

        $query = $this->insertQuery(self::getTableName($connection));
        $statement = $connection->prepare($query);

        if( $statement->execute() )
        {
            return true;
        }
        throw new  SaveUserExistException();

    }

    /**
     * update()
     * Update details in database after ::find(2)
     *
     * @return bool
     */
    public function update($dbConnection = NULL)

    {
        $connection = DatabaseQuery::checkConnection($dbConnection);

        $updateQuery = $this->updateQuery(self::getTableName($connection));
        $statement = $connection->prepare($updateQuery);
        if( $statement->execute() )
        {
            return true;
        }
        throw new  SaveUserExistException();
    }

    /**
     * destroy($value)
     * Delete data from database
     *
     * @return bool
     */
    public function destroy($value, $dbConnection = NULL)
    {
        $connection = DatabaseQuery::checkConnection($dbConnection);

        $query = $connection->prepare('DELETE FROM ' . self::getTableName($connection) . ' WHERE id = '.$value);
        $query->execute();
        $check = $query->rowCount();
        if ($check)
        {
            return true;
        }
        throw new UserNotFoundException;
    }
}

1		<?php
2		/**
3		* PotatoORM manages the persistence of database CRUD operations.
4		*
5		* @package Ibonly\PotatoORM\Model
6		* @author Ibraheem ADENIYI <[email protected]>
7		* @license MIT <https://opensource.org/licenses/MIT>
8		*/
9
10		namespace Ibonly\PotatoORM;
11
12		use PDO;
13		use Exception;
14		use PDOException;
15		use Ibonly\PotatoORM\GetData;
16		use Ibonly\PotatoORM\DatabaseQuery;
17		use Ibonly\PotatoORM\ModelInterface;
18		use Ibonly\PotatoORM\UserNotFoundException;
19		use Ibonly\PotatoORM\EmptyDatabaseException;
20		use Ibonly\PotatoORM\SaveUserExistException;
21		use Ibonly\PotatoORM\ColumnNotExistExeption;
22		use Ibonly\PotatoORM\InvalidConnectionException;
23
24		class Model extends DatabaseQuery implements ModelInterface
25		{
26		//Inject the inflector trait
27		use Inflector;
28
29		/**
30		* stripclassName()
31		*
32		* @return string
33		*/
34		public static function stripclassName()
35		{
36		$className = strtolower(get_called_class());
37		$nameOfClass = explode("\\", $className);
38		return end($nameOfClass);
39		}
40
41		/**
42		* getClassName()
43		*
44		* @return string
45		*/
46		public static function getClassName()
47		{
48		return self::pluralize(self::stripclassName());
49		}
50
51		/**
52		* getTableName()
53		*
54		* @return string
55		*/
56		public static function getTableName($connection)
57		{
58		return DatabaseQuery::checkTableName(self::getClassName(), $connection);
59		}
60
61		/**
62		* getALL()
63		* Get all record from the database
64		*
65		* @return object
66		*/
67		public function getALL($dbConnection = NULL)
68		{
69		$connection = DatabaseQuery::checkConnection($dbConnection);
70
71		$sqlQuery = DatabaseQuery::selectAllQuery(self::getTableName($connection));
72		$query = $connection->prepare($sqlQuery);
73		$query->execute();
74		if ( $query->rowCount() )
75		{
76		return new GetData($query->fetchAll($connection::FETCH_ASSOC));
77		}
78		throw new EmptyDatabaseException();
79		}
80
81		/**
82		* where($data, $condition)
83		* Get data from database where $data = $condition
84		*
85		* @return object
86		*/
87		public function where($data, $condition = NULL, $dbConnection = NULL)
88		{
89		$databaseQuery = new DatabaseQuery();
90		$connection = $databaseQuery->checkConnection($dbConnection);
91
92		$sqlQuery = $databaseQuery->selectQuery(self::getTableName($connection), $data, $condition, $connection);
93		$query = $connection->prepare($sqlQuery);
94		$query->execute();
95		if ( $query->rowCount() )
96		{
97		return new GetData($query->fetchAll($connection::FETCH_ASSOC));
98		}
99		throw new UserNotFoundException();
100		}
101
102		/**
103		* find($value)
104		* Find data from database where id = $value
105		*
106		* @return array
107		*/
108		public static function find($value, $dbConnection = NULL)
109		{
110		$connection = DatabaseQuery::checkConnection($dbConnection);
111
112		$sqlQuery = DatabaseQuery::selectQuery(self::getTableName($connection), ['id' => $value], NULL, $connection);
113		$query = $connection->prepare($sqlQuery);
114		$query->execute();
115		if ( $query->rowCount() )
116		{
117		$found = new static;
118		$found->id = $value;
119		$found->data = $query->fetchAll($connection::FETCH_ASSOC);
120		return $found;
121		}
122		throw new UserNotFoundException();
123		}
124
125		/**
126		* save()
127		* Insert data into database
128		*
129		* @return bool
130		*/
131	View Code Duplication	public function save($dbConnection = NULL)
		0 ignored issues – show Duplication introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
132		{
133		$connection = DatabaseQuery::checkConnection($dbConnection);
134
135		$query = $this->insertQuery(self::getTableName($connection));
136		$statement = $connection->prepare($query);
		0 ignored issues – show Bug introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `prepare` cannot be called on `$connection` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
137		if( $statement->execute() )
138		{
139		return true;
140		}
141		throw new SaveUserExistException();
142
143		}
144
145		/**
146		* update()
147		* Update details in database after ::find(2)
148		*
149		* @return bool
150		*/
151	View Code Duplication	public function update($dbConnection = NULL)
		0 ignored issues – show Duplication introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		{
153		$connection = DatabaseQuery::checkConnection($dbConnection);
154
155		$updateQuery = $this->updateQuery(self::getTableName($connection));
156		$statement = $connection->prepare($updateQuery);
157		if( $statement->execute() )
158		{
159		return true;
160		}
161		throw new SaveUserExistException();
162		}
163
164		/**
165		* destroy($value)
166		* Delete data from database
167		*
168		* @return bool
169		*/
170		public function destroy($value, $dbConnection = NULL)
171		{
172		$connection = DatabaseQuery::checkConnection($dbConnection);
173
174		$query = $connection->prepare('DELETE FROM ' . self::getTableName($connection) . ' WHERE id = '.$value);
175		$query->execute();
176		$check = $query->rowCount();
177		if ($check)
178		{
179		return true;
180		}
181		throw new UserNotFoundException;
182		}
183		}

andela-iadeniyi / Potato-ORM

Push — master ( 245fbf...00e192 )

src/Helper/Model.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like