DatabaseQuery - Code Metrics - Inspection of "Merge pull request #29 from andela-iadeniyi/1.0.0" - andela-iadeniyi/Potato-ORM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 672085...644962 )

by Adeniyi

created 2016-05-03 12:37 UTC

DatabaseQuery B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	385
Duplicated Lines	25.71 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes	20
Bugs	0	Features	2

Metric	Value
wmc	51
c	20
b	0
f	2
lcom	2
cbo	7
dl	99
loc	385
rs	8.3206

24 Methods

Rating	Name	Duplication	Size	Complexity
A	__set()	0	4	1
A	__get()	0	4	1
A	getProperties()	0	4	1
A	connect()	0	4	1
A	stripclassName()	0	7	1
A	tableName()	0	4	2
A	getClassName()	0	4	2
A	getTableName()	0	4	1
A	sanitize()	0	6	1
A	checkConnection()	0	4	2
A	checkTableExist()	9	9	2
A	checkTableName()	11	11	2
A	checkColumn()	0	12	2
A	buildColumn()	15	15	3
A	buildValues()	15	15	3
A	buildClause()	18	18	3
A	fields()	0	10	3
A	selectAllQuery()	0	4	1
B	whereAndClause()	0	23	4
A	whereLikeClause()	19	19	3
C	selectQuery()	0	27	8
A	insertQuery()	0	7	1
A	updateQuery()	0	7	1
A	query()	12	12	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like DatabaseQuery often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use DatabaseQuery, and based on these observations, apply Extract Interface, too.

<?php
/**
 * This class handles building sql query statement and check
 * that the table exist in the database.
 *
 * @package Ibonly\PotatoORM\DatabaseQuery
 * @author  Ibraheem ADENIYI <[email protected]>
 * @license MIT <https://opensource.org/licenses/MIT>
 */

namespace Ibonly\PotatoORM;

use PDOException;
use Ibonly\PotatoORM\DataNotFoundException;
use Ibonly\PotatoORM\DatabaseQueryInterface;
use Ibonly\PotatoORM\ColumnNotExistExeption;
use Ibonly\PotatoORM\InvalidConnectionException;
use Ibonly\PotatoORM\TableDoesNotExistException;

class DatabaseQuery implements DatabaseQueryInterface
{
    //Inject the inflector trait, file upload trait
    use Inflector, Upload;

    protected $properties = [];
    protected $output;

    public function __set($property, $value)
    {
        $this->properties[$property] = $value;
    }

    public function __get($property)
    {
        return $this->properties[$property];
    }

    public function getProperties()
    {
        return $this->properties;
    }

    /**
     * connect Setup database connection
     */
    protected static function connect()
    {
        return new DBConfig();
    }

    /**
     * stripclassName()
     *
     * @return string
     */
    public static function stripclassName()
    {
        $className = strtolower(get_called_class());
        $nameOfClass = explode("\\", $className);

        return end($nameOfClass);
    }

    /**
     * Get the table name if defined in the model
     * 
     * @return string
     */
    public function tableName()
    {
        return (isset($this->table)) ? $this->table : null;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
    /**
     * getClassName()
     *
     * @return string
     */
    public function getClassName()
    {
        return ($this->tableName() === null) ? self::pluralize(self::stripclassName()) : $this->tableName();
    }

    /**
     * getTableName()
     *
     * @return string
     */
    protected function getTableName($connection)
    {
        return DatabaseQuery::checkTableName($this->getClassName(), $connection);
    }


    /**
     * sanitize(argument) Removes unwanted characters
     *
     * @param  $value
     *
     * @return  string
     */
    protected static function sanitize($value)
    {
        $value = trim($value);
        $value = htmlentities($value);
        return $value;
    }

    /**
     * checkConnection
     *
     * @param  $con
     *
     * @return string
     */
    protected static function checkConnection($con)
    {
        return ($con === null) ? self::connect() : $con;
    }

    /**
     * checkTableExist Check if table already in the database
     *
     * @param  $tablename
     * @param  $con
     *
     * @return bool
     */
    public function checkTableExist($table, $con=NULL)

    {
        $connection = $this->checkConnection($con);
        $query = $connection->query("SELECT 1 FROM {$table} LIMIT 1");

        if($query !== false)
        {
            return true;
        }
    }

    /**
     * checkTableName Return the table name
     *
     * @param  $tablename
     * @param  $con
     *
     * @return string
     */
    protected static function checkTableName($tableName, $con=NULL)

    {
        $connection = self::checkConnection($con);

        $query = $connection->query("SELECT 1 FROM {$tableName} LIMIT 1");

        if($query !== false)
        {
            return $tableName;
        }
        throw new TableDoesNotExistException();
    }

    /**
     * checkColumn Check if column exist in table
     *
     * @param  $tableName
     * @param  $columnName
     * @param  $con
     *
     * @return string
     */
    protected static function checkColumn($tableName, $columnName, $con=NULL)
    {
        $connection = self::checkConnection($con);

            $result = $connection->prepare("SELECT {$columnName} FROM {$tableName}");

            $result->execute();
            if (! $result->columnCount())
            {
                throw new ColumnNotExistExeption();
            }
            return $columnName;
    }

    /**
     * buildColumn  Build the column name
     *
     * @param  $data
     *
     * @return string
     */
    protected static function buildColumn($data)

    {
        $counter = 0;
        $insertQuery = "";
        $arraySize = count($data);

        foreach ($data as $key => $value)
        {
            $counter++;
            $insertQuery .= self::sanitize($key);
            if($arraySize > $counter)
                $insertQuery .= ", ";
        }
        return $insertQuery;
    }

    /**
     * buildValues  Build the column values
     *
     * @param  $data
     *
     * @return string
     */
    protected static function buildValues($data)

    {
        $counter = 0;
        $insertQuery = "";
        $arraySize = count($data);

        foreach ($data as $key => $value)
        {
            $counter++;
            $insertQuery .= "'".self::sanitize($value) ."'";
            if($arraySize > $counter)
                $insertQuery .= ", ";
        }
        return $insertQuery;
    }

    /**
     * buildClause  Build the clause value
     *
     * @param  $data
     *
     * @return string
     */
    protected static function buildClause($tableName, $data)

    {
        $counter = 0;
        $updateQuery = "";
        $arraySize = count($data);

        foreach ($data as $key => $value)
        {
            $counter++;
            $columnName = self::checkColumn($tableName, self::sanitize($key));
            $updateQuery .= $columnName ." = '".self::sanitize($value)."'";
            if ($arraySize > $counter)
            {
                $updateQuery .= ", ";
            }
        }
        return $updateQuery;
    }

    /**
     * Get the fields to be fillables defined in the model
     * 
     * @return string
     */
    protected function fields()
    {
        if (isset($this->fillables)) {
            $this->output = (sizeof($this->fillables) > 0) ? implode($this->fillables, ',') : '*';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $this->output = '*';
        }

        return $this->output;
    }

    /**
     * selectAllQuery
     *
     * @return string
     */
    public function selectAllQuery($tableName)
    {
        return "SELECT ".$this->fields()." FROM {$tableName}";
    }

    /**
     * whereAndClause
     *
     * @return string
     */
    public static function whereAndClause($tableName, $data, $condition)
    {
        $where = "";
        $counter = 0;
        $arraySize = count($data);

        if ($data !== null) {
            foreach ($data as $key => $value)
            {
                $counter++;
                $columnName = self::checkColumn($tableName, self::sanitize($key));
                $where .= $tableName.'.'.$columnName ." = '".self::sanitize($value)."'";
                if ($arraySize > $counter)
                {
                    $where .= " " . $condition . " ";
                }
            }
        } else {
            $where = "";
        }

        return $where;
    }
    
    public static function whereLikeClause($tableName, $data, $condition)

    {
        $where = "";
        $counter = 0;
        $arraySize = count($data);

        foreach ( $data as $key => $value )
        {
            $counter++;
            $columnName = self::checkColumn($tableName, self::sanitize($key));
            $where .= $columnName ." LIKE '%".self::sanitize($value)."%'";
            if ( $arraySize > $counter )
            {
                $where .= " " . $condition . " ";
            }
        }

        return $where;
    }

    /**
     * selectQuery
     *
     * @return string
     */
    public static function selectQuery($tableName, $fields, $data, $condition, $connection)
    {
        $query = "";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $columnName = "";
        
        try
        {
            $arraySize = count($data);
            if( $arraySize > 1 && $condition == NULL)
            {
                $query = "Please Supply the condition";
            }
            else
            {
                if ($condition === 'AND' || $condition === 'OR' || $condition === NULL) {
                    $columnName = self::whereAndClause($tableName, $data, $condition);
                } elseif ($condition === 'LIKE') {
                    $columnName = self::whereLikeClause($tableName, $data, $condition);
                } 
                $query =  "SELECT $fields FROM $tableName WHERE $columnName";
            }
        } catch (PDOException $e) {
            $query = $e->getMessage();
        }

        return $query;
    }

    /**
     * insertQuery
     *
     * @return string
     */
    public function insertQuery($tableName)
    {
        $columnNames = self::buildColumn($this->properties);
        $values = self::buildValues($this->properties);

        return "INSERT INTO $tableName ({$columnNames}) VALUES ({$values})";
    }

    /**
     * updateQuery
     *
     * @return string
     */
    public function updateQuery($tableName, $id)
    {
        $values = self::buildClause($tableName, $this->properties);
        $updateQuery = "UPDATE $tableName SET {$values} WHERE id = $id";

        return $updateQuery;
    }

    /**
     * query($query, $dbCOnnection)
     * Raw sql query
     *
     * @return object
     */
    public function query($query, $con = NULL)

    {
        $connection = self::checkConnection($con);

        $query = $connection->prepare($query);

        $query->execute();
        if ($query->rowCount())
        {
            return new GetData($query->fetchAll($connection::FETCH_ASSOC));
        }
        throw new DataNotFoundException();
    }
}

1		<?php
2		/**
3		* This class handles building sql query statement and check
4		* that the table exist in the database.
5		*
6		* @package Ibonly\PotatoORM\DatabaseQuery
7		* @author Ibraheem ADENIYI <[email protected]>
8		* @license MIT <https://opensource.org/licenses/MIT>
9		*/
10
11		namespace Ibonly\PotatoORM;
12
13		use PDOException;
14		use Ibonly\PotatoORM\DataNotFoundException;
15		use Ibonly\PotatoORM\DatabaseQueryInterface;
16		use Ibonly\PotatoORM\ColumnNotExistExeption;
17		use Ibonly\PotatoORM\InvalidConnectionException;
18		use Ibonly\PotatoORM\TableDoesNotExistException;
19
20		class DatabaseQuery implements DatabaseQueryInterface
21		{
22		//Inject the inflector trait, file upload trait
23		use Inflector, Upload;
24
25		protected $properties = [];
26		protected $output;
27
28		public function __set($property, $value)
29		{
30		$this->properties[$property] = $value;
31		}
32
33		public function __get($property)
34		{
35		return $this->properties[$property];
36		}
37
38		public function getProperties()
39		{
40		return $this->properties;
41		}
42
43		/**
44		* connect Setup database connection
45		*/
46		protected static function connect()
47		{
48		return new DBConfig();
49		}
50
51		/**
52		* stripclassName()
53		*
54		* @return string
55		*/
56		public static function stripclassName()
57		{
58		$className = strtolower(get_called_class());
59		$nameOfClass = explode("\\", $className);
60
61		return end($nameOfClass);
62		}
63
64		/**
65		* Get the table name if defined in the model
66		*
67		* @return string
68		*/
69		public function tableName()
70		{
71		return (isset($this->table)) ? $this->table : null;
		0 ignored issues – show Documentation introduced 2016-05-03 12:33 UTC by Report Bug Copy Issue Report The property `table` does not exist on `object<Ibonly\PotatoORM\DatabaseQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
72		}
73		/**
74		* getClassName()
75		*
76		* @return string
77		*/
78		public function getClassName()
79		{
80		return ($this->tableName() === null) ? self::pluralize(self::stripclassName()) : $this->tableName();
81		}
82
83		/**
84		* getTableName()
85		*
86		* @return string
87		*/
88		protected function getTableName($connection)
89		{
90		return DatabaseQuery::checkTableName($this->getClassName(), $connection);
91		}
92
93
94		/**
95		* sanitize(argument) Removes unwanted characters
96		*
97		* @param $value
98		*
99		* @return string
100		*/
101		protected static function sanitize($value)
102		{
103		$value = trim($value);
104		$value = htmlentities($value);
105		return $value;
106		}
107
108		/**
109		* checkConnection
110		*
111		* @param $con
112		*
113		* @return string
114		*/
115		protected static function checkConnection($con)
116		{
117		return ($con === null) ? self::connect() : $con;
118		}
119
120		/**
121		* checkTableExist Check if table already in the database
122		*
123		* @param $tablename
124		* @param $con
125		*
126		* @return bool
127		*/
128	View Code Duplication	public function checkTableExist($table, $con=NULL)
		0 ignored issues – show Duplication introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		{
130		$connection = $this->checkConnection($con);
131		$query = $connection->query("SELECT 1 FROM {$table} LIMIT 1");
		0 ignored issues – show Bug introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report The method `query` cannot be called on `$connection` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
132		if($query !== false)
133		{
134		return true;
135		}
136		}
137
138		/**
139		* checkTableName Return the table name
140		*
141		* @param $tablename
142		* @param $con
143		*
144		* @return string
145		*/
146	View Code Duplication	protected static function checkTableName($tableName, $con=NULL)
		0 ignored issues – show Duplication introduced 2016-04-13 14:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		{
148		$connection = self::checkConnection($con);
149
150		$query = $connection->query("SELECT 1 FROM {$tableName} LIMIT 1");
		0 ignored issues – show Bug introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report The method `query` cannot be called on `$connection` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
151		if($query !== false)
152		{
153		return $tableName;
154		}
155		throw new TableDoesNotExistException();
156		}
157
158		/**
159		* checkColumn Check if column exist in table
160		*
161		* @param $tableName
162		* @param $columnName
163		* @param $con
164		*
165		* @return string
166		*/
167		protected static function checkColumn($tableName, $columnName, $con=NULL)
168		{
169		$connection = self::checkConnection($con);
170
171		$result = $connection->prepare("SELECT {$columnName} FROM {$tableName}");
		0 ignored issues – show Bug introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report The method `prepare` cannot be called on `$connection` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
172		$result->execute();
173		if (! $result->columnCount())
174		{
175		throw new ColumnNotExistExeption();
176		}
177		return $columnName;
178		}
179
180		/**
181		* buildColumn Build the column name
182		*
183		* @param $data
184		*
185		* @return string
186		*/
187	View Code Duplication	protected static function buildColumn($data)
		0 ignored issues – show Duplication introduced 2016-05-03 12:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
188		{
189		$counter = 0;
190		$insertQuery = "";
191		$arraySize = count($data);
192
193		foreach ($data as $key => $value)
194		{
195		$counter++;
196		$insertQuery .= self::sanitize($key);
197		if($arraySize > $counter)
198		$insertQuery .= ", ";
199		}
200		return $insertQuery;
201		}
202
203		/**
204		* buildValues Build the column values
205		*
206		* @param $data
207		*
208		* @return string
209		*/
210	View Code Duplication	protected static function buildValues($data)
		0 ignored issues – show Duplication introduced 2016-05-03 12:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
211		{
212		$counter = 0;
213		$insertQuery = "";
214		$arraySize = count($data);
215
216		foreach ($data as $key => $value)
217		{
218		$counter++;
219		$insertQuery .= "'".self::sanitize($value) ."'";
220		if($arraySize > $counter)
221		$insertQuery .= ", ";
222		}
223		return $insertQuery;
224		}
225
226		/**
227		* buildClause Build the clause value
228		*
229		* @param $data
230		*
231		* @return string
232		*/
233	View Code Duplication	protected static function buildClause($tableName, $data)
		0 ignored issues – show Duplication introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
234		{
235		$counter = 0;
236		$updateQuery = "";
237		$arraySize = count($data);
238
239		foreach ($data as $key => $value)
240		{
241		$counter++;
242		$columnName = self::checkColumn($tableName, self::sanitize($key));
243		$updateQuery .= $columnName ." = '".self::sanitize($value)."'";
244		if ($arraySize > $counter)
245		{
246		$updateQuery .= ", ";
247		}
248		}
249		return $updateQuery;
250		}
251
252		/**
253		* Get the fields to be fillables defined in the model
254		*
255		* @return string
256		*/
257		protected function fields()
258		{
259		if (isset($this->fillables)) {
260		$this->output = (sizeof($this->fillables) > 0) ? implode($this->fillables, ',') : '*';
		0 ignored issues – show Documentation introduced 2016-05-03 12:33 UTC by Report Bug Copy Issue Report The property `fillables` does not exist on `object<Ibonly\PotatoORM\DatabaseQuery>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
261		} else {
262		$this->output = '*';
263		}
264
265		return $this->output;
266		}
267
268		/**
269		* selectAllQuery
270		*
271		* @return string
272		*/
273		public function selectAllQuery($tableName)
274		{
275		return "SELECT ".$this->fields()." FROM {$tableName}";
276		}
277
278		/**
279		* whereAndClause
280		*
281		* @return string
282		*/
283		public static function whereAndClause($tableName, $data, $condition)
284		{
285		$where = "";
286		$counter = 0;
287		$arraySize = count($data);
288
289		if ($data !== null) {
290		foreach ($data as $key => $value)
291		{
292		$counter++;
293		$columnName = self::checkColumn($tableName, self::sanitize($key));
294		$where .= $tableName.'.'.$columnName ." = '".self::sanitize($value)."'";
295		if ($arraySize > $counter)
296		{
297		$where .= " " . $condition . " ";
298		}
299		}
300		} else {
301		$where = "";
302		}
303
304		return $where;
305		}
306
307	View Code Duplication	public static function whereLikeClause($tableName, $data, $condition)
		0 ignored issues – show Duplication introduced 2016-05-03 12:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
308		{
309		$where = "";
310		$counter = 0;
311		$arraySize = count($data);
312
313		foreach ( $data as $key => $value )
314		{
315		$counter++;
316		$columnName = self::checkColumn($tableName, self::sanitize($key));
317		$where .= $columnName ." LIKE '%".self::sanitize($value)."%'";
318		if ( $arraySize > $counter )
319		{
320		$where .= " " . $condition . " ";
321		}
322		}
323
324		return $where;
325		}
326
327		/**
328		* selectQuery
329		*
330		* @return string
331		*/
332		public static function selectQuery($tableName, $fields, $data, $condition, $connection)
333		{
334		$query = "";
		0 ignored issues – show Unused Code introduced 2015-11-22 09:13 UTC by Report Bug Copy Issue Report `$query` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
335		$columnName = "";
336
337		try
338		{
339		$arraySize = count($data);
340		if( $arraySize > 1 && $condition == NULL)
341		{
342		$query = "Please Supply the condition";
343		}
344		else
345		{
346		if ($condition === 'AND' \|\| $condition === 'OR' \|\| $condition === NULL) {
347		$columnName = self::whereAndClause($tableName, $data, $condition);
348		} elseif ($condition === 'LIKE') {
349		$columnName = self::whereLikeClause($tableName, $data, $condition);
350		}
351		$query = "SELECT $fields FROM $tableName WHERE $columnName";
352		}
353		} catch (PDOException $e) {
354		$query = $e->getMessage();
355		}
356
357		return $query;
358		}
359
360		/**
361		* insertQuery
362		*
363		* @return string
364		*/
365		public function insertQuery($tableName)
366		{
367		$columnNames = self::buildColumn($this->properties);
368		$values = self::buildValues($this->properties);
369
370		return "INSERT INTO $tableName ({$columnNames}) VALUES ({$values})";
371		}
372
373		/**
374		* updateQuery
375		*
376		* @return string
377		*/
378		public function updateQuery($tableName, $id)
379		{
380		$values = self::buildClause($tableName, $this->properties);
381		$updateQuery = "UPDATE $tableName SET {$values} WHERE id = $id";
382
383		return $updateQuery;
384		}
385
386		/**
387		* query($query, $dbCOnnection)
388		* Raw sql query
389		*
390		* @return object
391		*/
392	View Code Duplication	public function query($query, $con = NULL)
		0 ignored issues – show Duplication introduced 2016-04-13 14:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
393		{
394		$connection = self::checkConnection($con);
395
396		$query = $connection->prepare($query);
		0 ignored issues – show Bug introduced 2016-04-13 14:57 UTC by Report Bug Copy Issue Report The method `prepare` cannot be called on `$connection` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
397		$query->execute();
398		if ($query->rowCount())
399		{
400		return new GetData($query->fetchAll($connection::FETCH_ASSOC));
401		}
402		throw new DataNotFoundException();
403		}
404		}

andela-iadeniyi / Potato-ORM