DatabaseTest::testGetAllAsStatic() - Code Metrics - Inspection of "Checkpoint 2 - Potato ORM" - andela-celisha-wigwe/PotatoORM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Elisha-Wigwe Chijioke

created 2016-03-24 12:04 UTC

DatabaseTest::testGetAllAsStatic() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	6
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

use Elchroy\PotatoORM\PotatoModel;
use Mockery as m;

class DatabaseTest extends PHPUnit_Framework_TestCase
{
    private $connection;
    private $query;
    private $connector;
    private $db;

    public function setUp()
    {
        $this->connector = m::mock('Elchroy\PotatoORM\PotatoConnector');
        $this->connector->shouldReceive('setConnection')->andReturn($this->connection);
        $this->query = m::mock('Elchroy\PotatoORM\PotatoQuery', [$this->connector]);
    }

    public function testGetAllAsStatic()
    {
        $this->query->connection = $this->db;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->query->shouldReceive('getFrom');
        $dogs = Dog::getAll($this->query);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testFindIdAsStatic()
    {
        $this->query->connection = $this->db;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->query->shouldReceive('getOne')->with('dog', 3);
        $dog = Dog::find(3, $this->query);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testDeleteIdAsStatic()
    {
        $this->query->connection = $this->db;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->query->shouldReceive('deleteFrom')->with('dog', 1);
        $this->query->shouldReceive('getFrom');
        $dog = Dog::destroy(1, $this->query);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testDataBasecolumn()
    {
    }
}

class Dog extends PotatoModel
{
}


1			<?php
2
3			use Elchroy\PotatoORM\PotatoModel;
4			use Mockery as m;
5
6			class DatabaseTest extends PHPUnit_Framework_TestCase
7			{
8			private $connection;
9			private $query;
10			private $connector;
11			private $db;
12
13			public function setUp()
14			{
15			$this->connector = m::mock('Elchroy\PotatoORM\PotatoConnector');
16			$this->connector->shouldReceive('setConnection')->andReturn($this->connection);
17			$this->query = m::mock('Elchroy\PotatoORM\PotatoQuery', [$this->connector]);
18			}
19
20			public function testGetAllAsStatic()
21			{
22			$this->query->connection = $this->db;
			0 ignored issues – show Bug introduced 2016-03-23 16:31 UTC by Report Bug Copy Issue Report Accessing `connection` on the interface `Mockery\MockInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
23			$this->query->shouldReceive('getFrom');
24			$dogs = Dog::getAll($this->query);
			0 ignored issues – show Unused Code introduced 2016-03-23 16:31 UTC by Report Bug Copy Issue Report `$dogs` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
25			}
26
27			public function testFindIdAsStatic()
28			{
29			$this->query->connection = $this->db;
			0 ignored issues – show Bug introduced 2016-03-23 16:31 UTC by Report Bug Copy Issue Report Accessing `connection` on the interface `Mockery\MockInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
30			$this->query->shouldReceive('getOne')->with('dog', 3);
31			$dog = Dog::find(3, $this->query);
			0 ignored issues – show Unused Code introduced 2016-03-23 16:31 UTC by Report Bug Copy Issue Report `$dog` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
32			}
33
34			public function testDeleteIdAsStatic()
35			{
36			$this->query->connection = $this->db;
			0 ignored issues – show Bug introduced 2016-03-23 16:31 UTC by Report Bug Copy Issue Report Accessing `connection` on the interface `Mockery\MockInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37			$this->query->shouldReceive('deleteFrom')->with('dog', 1);
38			$this->query->shouldReceive('getFrom');
39			$dog = Dog::destroy(1, $this->query);
			0 ignored issues – show Unused Code introduced 2016-03-23 16:31 UTC by Report Bug Copy Issue Report `$dog` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
40			}
41
42			public function testDataBasecolumn()
43			{
44			}
45			}
46
47			class Dog extends PotatoModel
48			{
49			}
50

andela-celisha-wigwe / PotatoORM

Pull Request — master (#11)

DatabaseTest::testGetAllAsStatic() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like