DataBaseConnection::__construct() - Code Metrics - Inspection of "Update composer.json" - andela-araimi/potato-orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1b3be6...409e1d )

by Adeola

created 2016-03-31 08:15 UTC

DataBaseConnection::__construct() A

↳ Parent: DataBaseConnection

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes	17
Bugs	8	Features	2

Metric	Value
c	17
b	8
f	2
dl	0
loc	17
ccs	11
cts	11
cp	1
rs	9.4285
cc	1
eloc	10
nc	1
nop	1
crap	1

<?php

/**
 * This class is involve in connection to the database.
 *
 * @author   Raimi Ademola <[email protected]>
 * @copyright: 2016 Andela
 */
namespace Demo;

use Dotenv\Dotenv;
use PDO;

class DataBaseConnection extends PDO
{
    public $servername;
    public $username;
    public $password;
    public $driver;
    public $dbname;

    /**
     * This is a constructor; a default method  that will be called automatically during class instantiation.
     */
    public function __construct($path = null)
    {
        $this->loadEnv($path);

        $this->servername = getenv('DB_HOST');
        $this->username = getenv('DB_USERNAME');
        $this->password = getenv('DB_PASSWORD');
        $this->driver = getenv('DB_DRIVER');
        $this->dbname = getenv('DB_NAME');

        $options = [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            PDO::ATTR_PERSISTENT => true,
            PDO::ATTR_ERRMODE    => PDO::ERRMODE_EXCEPTION,
        ];

        //parent::__construct($this->getDataBaseDriver(), $this->username, $this->password, $options);

    }

    /**
     * This method determines the driver to be used for appropriate database server.
     *
     *
     * @return string dsn
     */
    public function getDataBaseDriver()
    {
        $dns = $this->driver.':host='.$this->servername.';dbname='.$this->dbname;

        return $dns;
    }

    /**
     * Load Dotenv to grant getenv() access to environment variables in .env file.
     */
    public function loadEnv($path = null)
    {
        $envPath = $path == null ? __DIR__.'/../../' : $path;
        $dotenv = new Dotenv($envPath);
        $dotenv->load();
    }
}


1		<?php
2
3		/**
4		* This class is involve in connection to the database.
5		*
6		* @author Raimi Ademola <[email protected]>
7		* @copyright: 2016 Andela
8		*/
9		namespace Demo;
10
11		use Dotenv\Dotenv;
12		use PDO;
13
14		class DataBaseConnection extends PDO
15		{
16		public $servername;
17		public $username;
18		public $password;
19		public $driver;
20		public $dbname;
21
22		/**
23		* This is a constructor; a default method that will be called automatically during class instantiation.
24		*/
25	57	public function __construct($path = null)
26		{
27	57	$this->loadEnv($path);
28
29	57	$this->servername = getenv('DB_HOST');
30	57	$this->username = getenv('DB_USERNAME');
31	57	$this->password = getenv('DB_PASSWORD');
32	57	$this->driver = getenv('DB_DRIVER');
33	57	$this->dbname = getenv('DB_NAME');
34
35		$options = [
		0 ignored issues – show Unused Code introduced 2016-03-24 14:50 UTC by Report Bug Copy Issue Report `$options` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36	57	PDO::ATTR_PERSISTENT => true,
37	38	PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
38	38	];
39
40		//parent::__construct($this->getDataBaseDriver(), $this->username, $this->password, $options);
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-24 14:50 UTC by Report Bug Copy Issue Report `71%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41	57	}
42
43		/**
44		* This method determines the driver to be used for appropriate database server.
45		*
46		*
47		* @return string dsn
48		*/
49	3	public function getDataBaseDriver()
50		{
51	3	$dns = $this->driver.':host='.$this->servername.';dbname='.$this->dbname;
52
53	3	return $dns;
54		}
55
56		/**
57		* Load Dotenv to grant getenv() access to environment variables in .env file.
58		*/
59	57	public function loadEnv($path = null)
60		{
61	57	$envPath = $path == null ? __DIR__.'/../../' : $path;
62	57	$dotenv = new Dotenv($envPath);
63	57	$dotenv->load();
64	57	}
65		}
66

andela-araimi / potato-orm

Push — master ( 1b3be6...409e1d )

DataBaseConnection::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like