DataBaseModel::findById() - Code Metrics - Inspection of "refactor" - andela-araimi/potato-orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( acc15b...6c3a63 )

by Adeola

created 2016-03-22 16:34 UTC

DataBaseModel::findById() A

↳ Parent: DataBaseModel

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	11
Bugs	3	Features	0

Metric	Value
c	11
b	3
f	0
dl	0
loc	18
ccs	7
cts	7
cp	1
rs	9.4285
cc	3
eloc	9
nc	3
nop	1
crap	3

<?php

/**
 * Class DataBaseModel:
 * This is an abstract class which stands as a model
 * to another class e.g User class which can inherit from
 * all its methods. This class stands as a middle man
 * between the User class and the DataBaseQuery class.
 *
 * @author: Raimi Ademola <[email protected]>
 * @copyright: 2016 Andela
 */
namespace Demo;

use Doctrine\Common\Inflector\Inflector;

abstract class DataBaseModel implements DataBaseModelInterface
{
    protected $tableName;
    protected $dbConn;
    protected $dataBaseQuery;
    protected $properties;
    protected $arrayField;

    /**
     * This is a constructor; a default method  that will be called automatically during class instantiation.
     */
    public function __construct($dbConn)
    {
        $this->tableName = self::getClassName();
        $this->dataBaseQuery = new DataBaseQuery($dbConn);
        $this->arrayField['id'] = 0;
    }

    /**
     * The magic setter method.
     *
     * @param $properties
     * @param $values
     *
     * @return array associative array properties
     */
    public function __set($properties, $values)
    {
        $this->arrayField[$properties] = $values;
    }

    /**
     * The magic getter method.
     *
     * @param $properties
     *
     * @return array key
     */
    public function __get($properties)
    {
        return $this->arrayField[$properties];
    }

    /**
     * This method gets all the record from a particular table
     * by accessing the read method from the DataBaseQuery class.
     *
     * @throws NoDataFoundException
     *
     * @return associative array
     */
    public static function getAll($dbConn)
    {
        $sqlData = DataBaseQuery::read($id = false, self::getClassName(), $dbConn);

        return $sqlData;
    }
            
    /**
     * This method either create or update record in a database table
     * by calling either the read method or create method in the
     * DataBaseQuery class.
     *
     * @throws NoRecordUpdateException
     * @throws EmptyArrayException
     * @throws NoRecordCreatedException
     *
     * @return bool true or false;
     */
    public function save($dbConn)
    {
        if ($this->arrayField['id']) {
            $sqlData = DataBaseQuery::read($this->arrayField['id'], self::getClassName(), $dbConn);

            if ($this->checkIfRecordIsEmpty($sqlData)) {
                $boolCommit = $this->dataBaseQuery->update(['id' => $this->arrayField['id']], $this->arrayField, self::getClassName(), $dbConn);
    
                if ($boolCommit) {
                    return true;
                }

                throw new NoRecordUpdatedException('oops, your record did not update succesfully');
            }

            throw new EmptyArrayException("data passed didn't match any record");
        } else {

            $boolCommit = $this->dataBaseQuery->create($this->arrayField, self::getClassName(), $dbConn);

            if ($boolCommit) {

                return true;
            }

            throw new NoRecordCreatedException('oops,your record did not create succesfully');
        }
   
    }

    /**
     * This method find a record by id.
     *
     * @param $id
     *
     * @throws ArgumentNumberIncorrectException
     * @throws ArgumentNotFoundException
     *
     * @return object
     */
    public static function findById($id)
    {
        $numArgs = func_num_args();

        if ($numArgs > 1) {
            throw new ArgumentNumberIncorrectException('Please input just one Argument');
        }

        if ($id == '') {
            throw new ArgumentNotFoundException('No Argument found, please input an argument');
        }

        $staticFindInstance = new static();


        $staticFindInstance->id = $id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $staticFindInstance;
    }

    /**
     * This method find a record by id and returns
     * all the data present in the id.
     *
     *
     * @return associative array
     */
    public function getById()
    {
        if ($this->arrayField['id']) {
            $sqlData = DataBaseQuery::read($this->arrayField['id'], self::getClassName(), $dbConn);

        
            return $sqlData;
        }
    }

    /**
     * This method delete a row from the table by the row id.
     *
     * @param $id
     *
     * @throws ArgumentNumberIncorrectException;
     * @throws ArgumentNotFoundException;
     *
     * @return bool true
     */
    public static function destroy($id, $dbConn)
    {
        $numArgs = func_num_args();
        if ($numArgs > 2) {
            throw new ArgumentNumberIncorrectException('Please input just one Argument');
        }

        if ($numArgs == ' ') {
            throw new ArgumentNotFoundException('No Argument found, please input an argument');
        }

        DataBaseQuery::delete($id, self::getClassName(), $dbConn);

        return true;
    }

    public static function getClassName()
    {
        $tableName = explode('\\', get_called_class());
        
        return Inflector::pluralize(strtolower(end($tableName)));
    }

    /**
     * This method check if the argument passed to this function is an array.
     *
     * @param $arrayOfRecord
     *
     * @return bool true
     */
    public function checkIfRecordIsEmpty($arrayOfRecord)
    {
        if (count($arrayOfRecord) > 0) {
            return true;
        }

        return false;
    }
}


1		<?php
2
3		/**
4		* Class DataBaseModel:
5		* This is an abstract class which stands as a model
6		* to another class e.g User class which can inherit from
7		* all its methods. This class stands as a middle man
8		* between the User class and the DataBaseQuery class.
9		*
10		* @author: Raimi Ademola <[email protected]>
11		* @copyright: 2016 Andela
12		*/
13		namespace Demo;
14
15		use Doctrine\Common\Inflector\Inflector;
16
17		abstract class DataBaseModel implements DataBaseModelInterface
18		{
19		protected $tableName;
20		protected $dbConn;
21		protected $dataBaseQuery;
22		protected $properties;
23		protected $arrayField;
24
25		/**
26		* This is a constructor; a default method that will be called automatically during class instantiation.
27		*/
28	42	public function __construct($dbConn)
29		{
30	42	$this->tableName = self::getClassName();
31	3	$this->dataBaseQuery = new DataBaseQuery($dbConn);
32		$this->arrayField['id'] = 0;
33	42	}
34
35	42	/**
36	42	* The magic setter method.
37	42	*
38		* @param $properties
39		* @param $values
40		*
41		* @return array associative array properties
42		*/
43		public function __set($properties, $values)
44		{
45		$this->arrayField[$properties] = $values;
46		}
47	42
48		/**
49	42	* The magic getter method.
50	42	*
51		* @param $properties
52		*
53		* @return array key
54		*/
55		public function __get($properties)
56		{
57		return $this->arrayField[$properties];
58		}
59
60		/**
61		* This method gets all the record from a particular table
62		* by accessing the read method from the DataBaseQuery class.
63		*
64		* @throws NoDataFoundException
65		*
66		* @return associative array
67		*/
68		public static function getAll($dbConn)
69		{
70		$sqlData = DataBaseQuery::read($id = false, self::getClassName(), $dbConn);
71
72	6	return $sqlData;
73		}
74	6
75		/**
76	3	* This method either create or update record in a database table
77		* by calling either the read method or create method in the
78		* DataBaseQuery class.
79		*
80		* @throws NoRecordUpdateException
81		* @throws EmptyArrayException
82		* @throws NoRecordCreatedException
83		*
84		* @return bool true or false;
85		*/
86		public function save($dbConn)
87		{
88		if ($this->arrayField['id']) {
89		$sqlData = DataBaseQuery::read($this->arrayField['id'], self::getClassName(), $dbConn);
90	2
91		if ($this->checkIfRecordIsEmpty($sqlData)) {
92		$boolCommit = $this->dataBaseQuery->update(['id' => $this->arrayField['id']], $this->arrayField, self::getClassName(), $dbConn);
93
94		if ($boolCommit) {
95		return true;
96		}
97
98		throw new NoRecordUpdatedException('oops, your record did not update succesfully');
99	2	}
100
101		throw new EmptyArrayException("data passed didn't match any record");
102		} else {
103
104		$boolCommit = $this->dataBaseQuery->create($this->arrayField, self::getClassName(), $dbConn);
105
106		if ($boolCommit) {
		0 ignored issues – show Bug Best Practice introduced 2016-03-14 20:45 UTC by Report Bug Copy Issue Report The expression `$boolCommit` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
107		return true;
108		}
109
110		throw new NoRecordCreatedException('oops,your record did not create succesfully');
111		}
112
113		}
114
115		/**
116		* This method find a record by id.
117		*
118		* @param $id
119		*
120		* @throws ArgumentNumberIncorrectException
121		* @throws ArgumentNotFoundException
122		*
123		* @return object
124		*/
125		public static function findById($id)
126		{
127		$numArgs = func_num_args();
128
129	9	if ($numArgs > 1) {
130		throw new ArgumentNumberIncorrectException('Please input just one Argument');
131	9	}
132
133	9	if ($id == '') {
134	3	throw new ArgumentNotFoundException('No Argument found, please input an argument');
135		}
136
137	6	$staticFindInstance = new static();
		0 ignored issues – show Bug introduced 2016-03-22 16:37 UTC by Report Bug Copy Issue Report The call to `DataBaseModel::__construct()` misses a required argument `$dbConn`. This check looks for function calls that miss required arguments. Loading history...
138	3
139		$staticFindInstance->id = $id;
		0 ignored issues – show Documentation introduced 2016-03-14 20:45 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Demo\DataBaseModel>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
140
141	3	return $staticFindInstance;
142		}
143
144		/**
145		* This method find a record by id and returns
146		* all the data present in the id.
147		*
148		*
149		* @return associative array
150		*/
151		public function getById()
152		{
153		if ($this->arrayField['id']) {
154		$sqlData = DataBaseQuery::read($this->arrayField['id'], self::getClassName(), $dbConn);
		0 ignored issues – show Bug introduced 2016-03-22 15:31 UTC by Report Bug Copy Issue Report The variable `$dbConn` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
155
156		return $sqlData;
157		}
158		}
159
160		/**
161		* This method delete a row from the table by the row id.
162		*
163		* @param $id
164		*
165		* @throws ArgumentNumberIncorrectException;
166		* @throws ArgumentNotFoundException;
167		*
168		* @return bool true
169		*/
170		public static function destroy($id, $dbConn)
171		{
172		$numArgs = func_num_args();
173		if ($numArgs > 2) {
174	9	throw new ArgumentNumberIncorrectException('Please input just one Argument');
175		}
176	9
177	9	if ($numArgs == ' ') {
178	3	throw new ArgumentNotFoundException('No Argument found, please input an argument');
179		}
180
181	6	DataBaseQuery::delete($id, self::getClassName(), $dbConn);
182	3
183		return true;
184		}
185	3
186		public static function getClassName()
187	3	{
188		$tableName = explode('\\', get_called_class());
189
190	42	return Inflector::pluralize(strtolower(end($tableName)));
191		}
192	42
193		/**
194	42	* This method check if the argument passed to this function is an array.
195		*
196		* @param $arrayOfRecord
197		*
198		* @return bool true
199		*/
200		public function checkIfRecordIsEmpty($arrayOfRecord)
201		{
202		if (count($arrayOfRecord) > 0) {
203		return true;
204	6	}
205
206	6	return false;
207	3	}
208		}
209

andela-araimi / potato-orm

Push — master ( acc15b...6c3a63 )

DataBaseModel::findById() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like