anavel / crud

src/Http/routes.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
         'prefix' => 'crud',
         'namespace' => 'Anavel\Crud\Http\Controllers'
     ],
-    function () {
+    function() {
         Route::get('/', [
             'as'   => 'anavel-crud.home',
             'uses' => 'HomeController@index'

src/helpers.php

Spacing +4 added lines, -4 removed lines

@@ -2,7 +2,7 @@ 
 
 use EasySlugger\Slugger;
 
-if (! function_exists('slugify')) {
+if (!function_exists('slugify')) {
     /**
      * Generate slug
      *
@@ -15,7 +15,7 @@ 
     }
 }
 
-if (! function_exists('uniqueSlugify')) {
+if (!function_exists('uniqueSlugify')) {
     /**
      * Generate unique slug
      *
@@ -28,7 +28,7 @@ 
     }
 }
 
-if (! function_exists('transcrud')) {
+if (!function_exists('transcrud')) {
     /**
      * Translate string but remove file key if translation not found
      *
@@ -37,7 +37,7 @@ 
      */
     function transcrud($text)
     {
-        $translation = trans('anavel-crud::models.' . $text);
+        $translation = trans('anavel-crud::models.'.$text);
 
         return str_replace('anavel-crud::models.', '', $translation);
     }

src/Abstractor/Eloquent/Relation/MiniCrud.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 
 use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
 use Anavel\Crud\Contracts\Abstractor\Field;
-use App;
 use Illuminate\Http\Request;
 
 class Translation extends Relation

Spacing +6 added lines, -6 removed lines

@@ -122,7 +122,7 @@ 
 
                 $config = [
                     'name' => $columnName,
-                    'presentation' => $this->name . ' ' . ucfirst(transcrud($columnName)),
+                    'presentation' => $this->name.' '.ucfirst(transcrud($columnName)),
                     'form_type' => $formType,
                     'no_validate' => true,
                     'validation' => null,
@@ -143,7 +143,7 @@ 
                     $field = $this->fieldFactory
                         ->setColumn($column)
                         ->setConfig([
-                            'name' => $columnName . '__delete',
+                            'name' => $columnName.'__delete',
                             'presentation' => null,
                             'form_type' => 'checkbox',
                             'no_validate' => true,
@@ -151,7 +151,7 @@ 
                             'functions' => null
                         ])
                         ->get();
-                    $fields[$columnName . '__delete'] = $field;
+                    $fields[$columnName.'__delete'] = $field;
                 }
             }
         }
@@ -195,12 +195,12 @@ 
                     $fieldName = $field->getName();
 
                     if (get_class($field->getFormField()) === \FormManager\Fields\File::class) {
-                        $handleResult = $this->handleField($request, $relationModel, $fieldsBase, $this->name . ".$relationIndex", $fieldName);
-                        if (! empty($handleResult['skip'])) {
+                        $handleResult = $this->handleField($request, $relationModel, $fieldsBase, $this->name.".$relationIndex", $fieldName);
+                        if (!empty($handleResult['skip'])) {
                             $skip = $handleResult['skip'];
                             unset($relationArray[$relationIndex][$skip]);
                         }
-                        if (! empty($handleResult['requestValue'])) {
+                        if (!empty($handleResult['requestValue'])) {
                             $relationArray[$relationIndex][$fieldName] = $handleResult['requestValue'];
                         }
                     }

src/Abstractor/Eloquent/Model.php

Doc Comments +4 added lines, -1 removed lines

@@ -85,6 +85,9 @@ 
         return transcrud($this->name);
     }
 
+    /**
+     * @return string
+     */
     public function getModel()
     {
         return $this->model;
@@ -334,7 +337,7 @@ 
     }
 
     /**
-     * @param array $requestForm
+     * @param array $request
      * @return mixed
      */
     public function persist(Request $request)

Unused Use Statements -2 removed lines

@@ -16,8 +16,6 @@
 use Anavel\Crud\Abstractor\Exceptions\AbstractorException;
 use Illuminate\Http\Request;
 use Illuminate\Support\Collection;
-use League\Flysystem\Adapter\Local;
-use League\Flysystem\Filesystem;
 
 class Model implements ModelAbstractorContract
 {

Spacing +25 added lines, -25 removed lines

@@ -128,32 +128,32 @@ 
         }
 
         $customDisplayedColumns = $this->getConfigValue($action, 'display');
-        $customHiddenColumns = $this->getConfigValue($action, 'hide') ? : [];
+        $customHiddenColumns = $this->getConfigValue($action, 'hide') ?: [];
 
         $relations = $this->getRelations();
 
         $columns = array();
-        if (! empty($customDisplayedColumns) && is_array($customDisplayedColumns)) {
+        if (!empty($customDisplayedColumns) && is_array($customDisplayedColumns)) {
             foreach ($customDisplayedColumns as $customColumn) {
                 if (strpos($customColumn, '.')) {
                     $customColumnRelation = explode('.', $customColumn);
 
-                    if (! $relations->has($customColumnRelation[0])) {
-                        throw new AbstractorException("Relation " . $customColumnRelation[0] . " not configured on " . $this->getModel());
+                    if (!$relations->has($customColumnRelation[0])) {
+                        throw new AbstractorException("Relation ".$customColumnRelation[0]." not configured on ".$this->getModel());
                     }
 
                     $relation = $relations->get($customColumnRelation[0]);
 
                     $relationColumns = $relation->getModelAbstractor()->getColumns($action);
 
-                    if (! array_key_exists($customColumnRelation[1], $relationColumns)) {
-                        throw new AbstractorException("Column " . $customColumnRelation[1] . " does not exist on relation ".$customColumnRelation[0]. " of model " . $this->getModel());
+                    if (!array_key_exists($customColumnRelation[1], $relationColumns)) {
+                        throw new AbstractorException("Column ".$customColumnRelation[1]." does not exist on relation ".$customColumnRelation[0]." of model ".$this->getModel());
                     }
 
                     $columns[$customColumn] = $relationColumns[$customColumnRelation[1]];
                 } else {
-                    if (! array_key_exists($customColumn, $tableColumns)) {
-                        throw new AbstractorException("Column " . $customColumn . " does not exist on " . $this->getModel());
+                    if (!array_key_exists($customColumn, $tableColumns)) {
+                        throw new AbstractorException("Column ".$customColumn." does not exist on ".$this->getModel());
                     }
 
                     $columns[$customColumn] = $tableColumns[$customColumn];
@@ -185,7 +185,7 @@ 
 
         $relations = collect();
 
-        if (! empty($configRelations)) {
+        if (!empty($configRelations)) {
             foreach ($configRelations as $relationName => $configRelation) {
                 if (is_int($relationName)) {
                     $relationName = $configRelation;
@@ -193,7 +193,7 @@ 
 
                 $config = [];
                 if ($configRelation !== $relationName) {
-                    if (! is_array($configRelation)) {
+                    if (!is_array($configRelation)) {
                         $config['type'] = $configRelation;
                     } else {
                         $config = $configRelation;
@@ -208,7 +208,7 @@ 
                 $secondaryRelations = $relation->getSecondaryRelations();
 
 
-                if (! $secondaryRelations->isEmpty()) {
+                if (!$secondaryRelations->isEmpty()) {
                     $relations->put(
                         $relationName,
                         collect(['relation' => $relation, 'secondaryRelations' => $secondaryRelations])
@@ -232,7 +232,7 @@ 
     {
         $columns = $this->getColumns('list');
 
-        $fieldsPresentation = $this->getConfigValue('fields_presentation') ? : [];
+        $fieldsPresentation = $this->getConfigValue('fields_presentation') ?: [];
 
         $fields = array();
         foreach ($columns as $name => $column) {
@@ -267,7 +267,7 @@ 
     {
         $columns = $this->getColumns('detail');
 
-        $fieldsPresentation = $this->getConfigValue('fields_presentation') ? : [];
+        $fieldsPresentation = $this->getConfigValue('fields_presentation') ?: [];
 
         $fields = array();
         foreach ($columns as $name => $column) {
@@ -307,7 +307,7 @@ 
 
         $fields = array();
         foreach ($columns as $name => $column) {
-            if (! in_array($name, $this->getReadOnlyColumns())) {
+            if (!in_array($name, $this->getReadOnlyColumns())) {
                 $presentation = null;
                 if (array_key_exists($name, $this->fieldsPresentation)) {
                     $presentation = $this->fieldsPresentation[$name];
@@ -328,24 +328,24 @@ 
                     ->setConfig($config)
                     ->get();
 
-                if (! empty($this->instance) && ! empty($this->instance->getAttribute($name))) {
+                if (!empty($this->instance) && !empty($this->instance->getAttribute($name))) {
                     $field->setValue($this->instance->getAttribute($name));
                 }
 
                 $fields[$arrayKey][$name] = $field;
 
-                if (! empty($config['form_type']) && $config['form_type'] === 'file') {
+                if (!empty($config['form_type']) && $config['form_type'] === 'file') {
                     $field = $this->fieldFactory
                         ->setColumn($column)
                         ->setConfig([
-                            'name'         => $name . '__delete',
+                            'name'         => $name.'__delete',
                             'presentation' => null,
                             'form_type'    => 'checkbox',
                             'no_validate'  => true,
                             'functions'    => null
                         ])
                         ->get();
-                    $fields[$arrayKey][$name . '__delete'] = $field;
+                    $fields[$arrayKey][$name.'__delete'] = $field;
                 }
             }
         }
@@ -382,7 +382,7 @@ 
     {
         /** @var \ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager $modelManager */
         $modelManager = App::make('ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager');
-        if (! empty($this->instance)) {
+        if (!empty($this->instance)) {
             $item = $this->instance;
         } else {
             $item = $modelManager->getModelInstance($this->getModel());
@@ -394,7 +394,7 @@ 
             return;
         }
 
-        if (! empty($fields['main'])) {
+        if (!empty($fields['main'])) {
             $skip = null;
             foreach ($fields['main'] as $key => $field) {
                 /** @var FieldContract $field */
@@ -419,20 +419,20 @@ 
 
                 if (get_class($field->getFormField()) === \FormManager\Fields\File::class) {
                     $handleResult = $this->handleField($request, $item, $fields['main'], 'main', $fieldName);
-                    if (! empty($handleResult['skip'])) {
+                    if (!empty($handleResult['skip'])) {
                         $skip = $handleResult['skip'];
                     }
-                    if (! empty($handleResult['requestValue'])) {
+                    if (!empty($handleResult['requestValue'])) {
                         $requestValue = $handleResult['requestValue'];
                     }
                 }
 
 
-                if (! $field->saveIfEmpty() && empty($requestValue)) {
+                if (!$field->saveIfEmpty() && empty($requestValue)) {
                     continue;
                 }
 
-                if (! empty($requestValue) || (empty($requestValue) && ! empty($item->getAttribute($fieldName)))) {
+                if (!empty($requestValue) || (empty($requestValue) && !empty($item->getAttribute($fieldName)))) {
                     $item->setAttribute(
                         $fieldName,
                         $field->applyFunctions($requestValue)
@@ -446,7 +446,7 @@ 
         $this->setInstance($item);
 
 
-        if (! empty($relations = $this->getRelations())) {
+        if (!empty($relations = $this->getRelations())) {
             foreach ($relations as $relationKey => $relation) {
                 if ($relation instanceof Collection) {
                     $input = $request->input($relationKey);

src/Abstractor/Eloquent/Traits/ModelFields.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     /**
      * @param array $config
      * @param string $columnName
-     * @return array
+     * @return \Doctrine\DBAL\Schema\Column
      */
     public function setConfig(array $config, $columnName)
     {

Spacing +5 added lines, -5 removed lines

@@ -17,11 +17,11 @@
      */
     public function readConfig($action)
     {
-        $this->fieldsPresentation = $this->getConfigValue('fields_presentation') ? : [];
-        $this->formTypes = $this->getConfigValue($action, 'form_types') ? : [];
-        $this->validationRules = $this->getConfigValue($action, 'validation') ? : [];
-        $this->functions = $this->getConfigValue($action, 'functions') ? : [];
-        $this->defaults = $this->getConfigValue($action, 'defaults') ? : [];
+        $this->fieldsPresentation = $this->getConfigValue('fields_presentation') ?: [];
+        $this->formTypes = $this->getConfigValue($action, 'form_types') ?: [];
+        $this->validationRules = $this->getConfigValue($action, 'validation') ?: [];
+        $this->functions = $this->getConfigValue($action, 'functions') ?: [];
+        $this->defaults = $this->getConfigValue($action, 'defaults') ?: [];
     }
 
     /**

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 namespace Anavel\Crud\Abstractor\Eloquent\Traits;
 
 
-use Anavel\Crud\Contracts\Abstractor\Field;
-
 trait ModelFields
 {
     protected $fieldsPresentation = [];

src/Contracts/Abstractor/Relation.php

Doc Comments -1 removed lines

@@ -55,7 +55,6 @@
     public function getSecondaryRelations();
 
     /**
-     * @param Model $relatedModel
      * @return Relation
      */
     public function setRelatedModel(\Illuminate\Database\Eloquent\Model $model);

src/Abstractor/Eloquent/Traits/HandleFiles.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
 
 trait HandleFiles
 {
+    /**
+     * @param string $groupName
+     */
     protected function handleField(Request $request, $item, array $fields, $currentKey,  $groupName, $fieldName)
     {
         $modelFolder = $this->slug . DIRECTORY_SEPARATOR;

Spacing +12 added lines, -12 removed lines

@@ -11,18 +11,18 @@ 
 {
     protected function handleField(Request $request, $item, array $fields, $groupName, $fieldName)
     {
-        $modelFolder = $this->slug . DIRECTORY_SEPARATOR;
-        $basePath = base_path(DIRECTORY_SEPARATOR . 'public' . DIRECTORY_SEPARATOR .config('anavel-crud.uploads_path'));
-        $modelPath = $basePath . $modelFolder;
+        $modelFolder = $this->slug.DIRECTORY_SEPARATOR;
+        $basePath = base_path(DIRECTORY_SEPARATOR.'public'.DIRECTORY_SEPARATOR.config('anavel-crud.uploads_path'));
+        $modelPath = $basePath.$modelFolder;
         $skip = null;
         $requestValue = null;
-        if (! empty($fields["{$fieldName}__delete"])) {
+        if (!empty($fields["{$fieldName}__delete"])) {
             //We never want to save this field, it doesn't exist in the DB
             $skip = "{$fieldName}__delete";
 
 
             //If user wants to delete the existing file
-            if (! empty($request->input("{$groupName}.{$fieldName}__delete"))) {
+            if (!empty($request->input("{$groupName}.{$fieldName}__delete"))) {
                 $adapter = new Local($basePath);
                 $filesystem = new Filesystem($adapter);
                 if ($filesystem->has($item->$fieldName)) {
@@ -39,22 +39,22 @@ 
                 ];
             }
         }
-        if ($request->hasFile($groupName .'.'.$fieldName)) {
-            $fileName = uniqid() . '_' .$request->file($groupName .'.'.$fieldName)->getClientOriginalName();
+        if ($request->hasFile($groupName.'.'.$fieldName)) {
+            $fileName = uniqid().'_'.$request->file($groupName.'.'.$fieldName)->getClientOriginalName();
 
 
-            $request->file($groupName .'.'.$fieldName)->move(
+            $request->file($groupName.'.'.$fieldName)->move(
                 $modelPath,
                 $fileName
             );
 
-            $requestValue = $modelFolder . $fileName;
-        } elseif (! empty($request->file($groupName .'.'.$fieldName)) && ! $request->file($groupName .'.'.$fieldName)->isValid()) {
-            throw new \Exception($request->file($groupName .'.'.$fieldName)->getErrorMessage());
+            $requestValue = $modelFolder.$fileName;
+        } elseif (!empty($request->file($groupName.'.'.$fieldName)) && !$request->file($groupName.'.'.$fieldName)->isValid()) {
+            throw new \Exception($request->file($groupName.'.'.$fieldName)->getErrorMessage());
         }
 
         //Avoid losing the existing filename if the user doesn't change it:
-        if (empty($requestValue) && (! empty($item->$fieldName))) {
+        if (empty($requestValue) && (!empty($item->$fieldName))) {
             $requestValue = $item->$fieldName;
         }
 

src/Abstractor/Eloquent/Relation/SelectMultipleManyToMany.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public function persist(array $relationArray = null, Request $request)
     {
-        if (! empty($relationArray)) {
+        if (!empty($relationArray)) {
             $this->eloquentRelation->sync($relationArray[$this->eloquentRelation->getRelated()->getKeyName()]);
         }
     }

src/Http/Controllers/ModelController.php

Doc Comments +3 added lines

@@ -25,6 +25,9 @@
         $this->formGenerator = $formGenerator;
     }
     
+    /**
+     * @param string $methodName
+     */
     private function authorizeMethod(Model $modelAbstractor, $methodName)
     {
         if (array_key_exists('authorize', $config = $modelAbstractor->getConfig()) && $config['authorize'] === true) {

Spacing +9 added lines, -9 removed lines

@@ -38,8 +38,8 @@ 
      */
     private function customController(Model $modelAbstractor)
     {
-        if (! $this instanceof CustomController) { //Avoid infinite recursion
-            if (array_key_exists('controller', $config = $modelAbstractor->getConfig()) && (! empty($config['controller']))) {
+        if (!$this instanceof CustomController) { //Avoid infinite recursion
+            if (array_key_exists('controller', $config = $modelAbstractor->getConfig()) && (!empty($config['controller']))) {
                 /** @var CustomController $controller */
                 $controller = App::make($config['controller']);
                 $controller->setAbstractor($modelAbstractor);
@@ -62,7 +62,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminIndex');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->index($request, $model);
         }
 
@@ -102,7 +102,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminCreate');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->create($model);
         }
 
@@ -128,7 +128,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminStore');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->store($request, $model);
         }
 
@@ -162,7 +162,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminShow');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->show($model, $id);
         }
 
@@ -189,7 +189,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminEdit');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->edit($model, $id);
         }
 
@@ -219,7 +219,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminUpdate');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->update($request, $model, $id);
         }
 
@@ -254,7 +254,7 @@ 
 
         $this->authorizeMethod($modelAbstractor, 'adminDestroy');
 
-        if (! empty($customController = $this->customController($modelAbstractor))) {
+        if (!empty($customController = $this->customController($modelAbstractor))) {
             return $customController->destroy($request, $model, $id);
         }