ModelController::create() - Code Metrics - Inspection of "Minor improvements" - anavel/crud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8d04f1...688970 )

by Lito

created 2017-09-28 22:33 UTC

ModelController::create() A

↳ Parent: ModelController

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
nc	2
nop	1
dl	0
loc	18
ccs	0
cts	11
cp	0
crap	6
rs	9.4285
c	1
b	0
f	0

<?php

namespace Anavel\Crud\Http\Controllers;

use ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager;
use ANavallaSuiza\Laravel\Database\Repository\Eloquent\Repository;
use Anavel\Crud\Contracts\Abstractor\Model;
use Anavel\Crud\Contracts\Abstractor\ModelFactory as ModelAbstractorFactory;
use Anavel\Crud\Contracts\Controllers\CustomController;
use Anavel\Crud\Contracts\Form\Generator as FormGenerator;
use Anavel\Crud\Repository\Criteria\OrderByCriteria;
use Anavel\Crud\Repository\Criteria\SearchCriteria;
use Anavel\Crud\Repository\Criteria\WithCriteria;
use Anavel\Foundation\Http\Controllers\Controller;
use Anavel\Crud\Services\Export\Csv;
use App;
use Illuminate\Http\Request;

class ModelController extends Controller
{
    protected $modelFactory;
    protected $modelManager;
    protected $formGenerator;

    public function __construct(ModelAbstractorFactory $modelFactory, ModelManager $modelManager, FormGenerator $formGenerator)
    {
        $this->modelFactory = $modelFactory;
        $this->modelManager = $modelManager;
        $this->formGenerator = $formGenerator;
    }

    private function authorizeMethod(Model $modelAbstractor, $methodName)
    {
        $config = $modelAbstractor->getConfig();

        if (array_key_exists('authorize', $config) && $config['authorize'] === true) {
            $this->authorize($methodName, $modelAbstractor->getInstance());
        }
    }

    /**
     * @param Model $modelAbstractor
     *
     * @return null|CustomController
     */
    private function customController(Model $modelAbstractor)
    {
        if ($this instanceof CustomController) { //Avoid infinite recursion
            return;
        }

        $config = $modelAbstractor->getConfig();

        if (!array_key_exists('controller', $config) || empty($config['controller'])) {
            return;
        }

        /** @var CustomController $controller */
        $controller = App::make($config['controller']);
        $controller->setAbstractor($modelAbstractor);

        return $controller;
    }

    /**
     * Prepare contents to be used
     *
     * @param Request $request
     * @param Model $modelAbstractor
     * @param Repository  $repository
     *
     * @return void
     */
    public function getIndexRequirements(Request $request, Model $modelAbstractor, Repository $repository)
    {
        foreach ($modelAbstractor->getListFields()['main'] as $field) {
            if (strpos($field->getName(), '.')) {
                $repository->pushCriteria(new WithCriteria(preg_replace('/\.[^\.]+$/', '', $field->getName())));
            }
        }

        if ($search = $request->input('search')) {
            $searchByColumns = [];

            foreach ($modelAbstractor->getListFields()['main'] as $field) {
                $searchByColumns[] = $field->getName();
            }

            $repository->pushCriteria(new SearchCriteria($searchByColumns, $search));
        }

        $sort = $request->input('sort') ?: 'id';
        $direction = $request->input('direction') ?: 'desc';

        $repository->pushCriteria(new OrderByCriteria($sort, ($direction === 'desc') ? true : false));
    }

    /**
     * Display a listing of the resource.
     *
     * @param Request $request
     * @param string  $model
     *
     * @return Response
     */
    public function index(Request $request, $model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminIndex');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->index($request, $model);
        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());

        $this->getIndexRequirements($request, $modelAbstractor, $repository);

        return view('anavel-crud::pages.index', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'items'      => $repository->paginate(config('anavel-crud.list_max_results')),
        ]);
    }

    /**
     * Display a listing of the resource.
     *
     * @param Request $request
     * @param string  $model
     *
     * @return Response
     */
    public function exportCsv(Request $request, $model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'exportCsv');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->exportCsv($request, $model);

        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());

        $this->getIndexRequirements($request, $modelAbstractor, $repository);

        $csv = (string)(new Csv)->fromArray($repository->all()->toArray());

        return response()->make($csv, 200, [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'Content-Encoding' => 'UTF-8',
            'Content-Type' => 'application/octet-stream',
            'Content-disposition' => 'attachment; filename='.$model.'.csv',
        ]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @param string $model
     *
     * @return Response
     */
    public function create($model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminCreate');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->create($model);
        }

        $form = $modelAbstractor->getForm(route('anavel-crud.model.store', $modelAbstractor->getSlug()));

        return view('anavel-crud::pages.create', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'form'       => $form,
            'relations'  => $modelAbstractor->getRelations(),
        ]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     * @param string  $model
     *
     * @return Response
     */
    public function store(Request $request, $model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminCreate');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->store($request, $model);
        }

        // Sets the validation rules
        $modelAbstractor->getForm(route('anavel-crud.model.store', $modelAbstractor->getSlug()));

        $this->validate($request, $modelAbstractor->getValidationRules());

        $modelAbstractor->persist($request);

        session()->flash('anavel-alert', [
            'type'  => 'success',
            'icon'  => 'fa-check',
            'title' => trans('anavel-crud::messages.alert_success_model_store_title'),
            'text'  => trans('anavel-crud::messages.alert_success_model_store_text'),
        ]);

        return redirect()->route('anavel-crud.model.index', $model);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Display the specified resource.
     *
     * @param string $model
     * @param int    $id
     *
     * @return Response
     */
    public function show($model, $id)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminShow');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->show($model, $id);
        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());
        $item = $repository->findByOrFail($repository->getModel()->getKeyName(), $id);

        return view('anavel-crud::pages.show', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'item'       => $item,
        ]);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param string $model
     * @param int    $id
     *
     * @return Response
     */
    public function edit($model, $id)
    {
        /** @var Model $modelAbstractor */
        $modelAbstractor = $this->modelFactory->getBySlug($model, $id);

        $this->authorizeMethod($modelAbstractor, 'adminUpdate');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->edit($model, $id);
        }

        $form = $modelAbstractor->getForm(route('anavel-crud.model.update', [$modelAbstractor->getSlug(), $id]));
        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());
        $item = $repository->findByOrFail($repository->getModel()->getKeyName(), $id);

        return view('anavel-crud::pages.edit', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'form'       => $form,
            'item'       => $item,
            'relations'  => $modelAbstractor->getRelations(),
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param Request $request
     * @param string  $model
     * @param int     $id
     *
     * @return Response
     */
    public function update(Request $request, $model, $id)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model, $id);

        $this->authorizeMethod($modelAbstractor, 'adminUpdate');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->update($request, $model, $id);
        }

        // Sets the validation rules
        $modelAbstractor->getForm(route('anavel-crud.model.update', [$modelAbstractor->getSlug(), $id]));

        $this->validate($request, $modelAbstractor->getValidationRules());

        $modelAbstractor->persist($request);

        session()->flash('anavel-alert', [
            'type'  => 'success',
            'icon'  => 'fa-check',
            'title' => trans('anavel-crud::messages.alert_success_model_update_title'),
            'text'  => trans('anavel-crud::messages.alert_success_model_update_text'),
        ]);

        return redirect()->route('anavel-crud.model.edit', [$model, $id]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param Request $request
     * @param string  $model
     * @param int     $id
     *
     * @return Response
     */
    public function destroy(Request $request, $model, $id)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminDestroy');

        if ($customController = $this->customController($modelAbstractor)) {
            return $customController->destroy($request, $model, $id);
        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());
        $item = $repository->findByOrFail($repository->getModel()->getKeyName(), $id);

        $item->delete();

        session()->flash('anavel-alert', [
            'type'  => 'success',
            'icon'  => 'fa-check',
            'title' => trans('anavel-crud::messages.alert_success_model_destroy_title'),
            'text'  => trans('anavel-crud::messages.alert_success_model_destroy_text'),
        ]);

        return redirect()->route('anavel-crud.model.index', $model);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Anavel\Crud\Http\Controllers;
4
5			use ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager;
6			use ANavallaSuiza\Laravel\Database\Repository\Eloquent\Repository;
7			use Anavel\Crud\Contracts\Abstractor\Model;
8			use Anavel\Crud\Contracts\Abstractor\ModelFactory as ModelAbstractorFactory;
9			use Anavel\Crud\Contracts\Controllers\CustomController;
10			use Anavel\Crud\Contracts\Form\Generator as FormGenerator;
11			use Anavel\Crud\Repository\Criteria\OrderByCriteria;
12			use Anavel\Crud\Repository\Criteria\SearchCriteria;
13			use Anavel\Crud\Repository\Criteria\WithCriteria;
14			use Anavel\Foundation\Http\Controllers\Controller;
15			use Anavel\Crud\Services\Export\Csv;
16			use App;
17			use Illuminate\Http\Request;
18
19			class ModelController extends Controller
20			{
21			protected $modelFactory;
22			protected $modelManager;
23			protected $formGenerator;
24
25			public function __construct(ModelAbstractorFactory $modelFactory, ModelManager $modelManager, FormGenerator $formGenerator)
26			{
27			$this->modelFactory = $modelFactory;
28			$this->modelManager = $modelManager;
29			$this->formGenerator = $formGenerator;
30			}
31
32			private function authorizeMethod(Model $modelAbstractor, $methodName)
33			{
34			$config = $modelAbstractor->getConfig();
35
36			if (array_key_exists('authorize', $config) && $config['authorize'] === true) {
37			$this->authorize($methodName, $modelAbstractor->getInstance());
38			}
39			}
40

anavel / crud

Push — master ( 8d04f1...688970 )

ModelController::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like