MiniCrud::getResults() - Code Metrics - Inspection of "Process checkboxes in model and minicrud" - anavel/crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7dac91...3d08cb )

unknown

created 2016-02-22 10:41 UTC

MiniCrud::getResults() A

↳ Parent: MiniCrud

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
ccs	3
cts	4
cp	0.75
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	2.0625

<?php
namespace Anavel\Crud\Abstractor\Eloquent\Relation;

use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
use Anavel\Crud\Abstractor\Eloquent\Traits\HandleFiles;
use Anavel\Crud\Contracts\Abstractor\Field;
use Anavel\Crud\Contracts\Abstractor\Relation as RelationContract;
use App;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;

class MiniCrud extends Relation
{
    use CheckRelationCompatibility;
    use HandleFiles;

    /** @var \ANavallaSuiza\Laravel\Database\Contracts\Dbal\AbstractionLayer $dbal */
    protected $dbal;

    /** @var  Collection */
    protected $results;

    protected $compatibleEloquentRelations = array(
        'Illuminate\Database\Eloquent\Relations\HasMany'
    );

    /**
     * @return Collection
     */
    protected function getResults()
    {
        if (empty($this->results)) {
            return $this->results = $this->eloquentRelation->getResults();
        }
        return $this->results;
    }

    public function setup()
    {
        $this->checkRelationCompatibility();
    }

    /**
     * @return array
     */
    public function getEditFields($arrayKey = null)
    {
        $fields = [];
        if (empty($arrayKey)) {
            $arrayKey = $this->name;
        }

        $fieldsBase = $this->getEditFieldsBase();


        /** @var Collection $results */
        $results = $this->getResults();

        $results->put('emptyResult', '');
        if (!empty($fieldsBase)) {
            foreach ($results as $key => $result) {
                $tempFields = [];
                $index = $key === 'emptyResult' ? 0 : $result->id;

                foreach ($fieldsBase as $columnName => $fieldBase) {
                    $field = clone $fieldBase;
                    if ($this->skipField($columnName, $key)) {
                        continue;
                    }

                    if ($key !== 'emptyResult') {
                        $field->setValue($result->getAttribute($columnName));
                    }
                    $tempFields[$columnName] = $field;

                }

                $relationModel = $this->eloquentRelation->getRelated()->newInstance();
                if (!empty($result)) {
                    $relationModel = $result;
                }

                $this->modelAbstractor->setInstance($relationModel);
                $secondaryRelations = $this->getSecondaryRelations();
                if (!empty($secondaryRelations)) {
                    foreach ($secondaryRelations as $secondaryRelationKey => $secondaryRelation) {

                        foreach ($secondaryRelation->getEditFields($secondaryRelationKey) as $editGroupName => $editGroup) {
                            if ($secondaryRelation->getType() === 'Anavel\Crud\Abstractor\Eloquent\Relation\Select') {
                                $tempFields[key($editGroup)] = $editGroup[key($editGroup)];
                            } else {
                                $tempFields[$editGroupName] = $editGroup;
                            }
                        };
                    }
                }


                $fields[$arrayKey][$index] = $tempFields;
            }
        }

        return $fields;
    }

    public function getEditFieldsBase()
    {
        $fields = [];
        $columns = $this->modelAbstractor->getColumns('edit');
        $this->readConfig('edit');

        if (!empty($columns)) {
            $readOnly = [Model::CREATED_AT, Model::UPDATED_AT];
            foreach ($columns as $columnName => $column) {
                if (in_array($columnName, $readOnly, true)) {
                    continue;
                }

                $formType = null;
                if ($columnName === $this->eloquentRelation->getParent()->getKeyName()) {
                    $formType = 'hidden';
                }

                $config = [
                    'name' => $columnName,
                    'presentation' => $this->name . ' ' . ucfirst(transcrud($columnName)),
                    'form_type' => $formType,
                    'no_validate' => true,
                    'validation' => null,
                    'functions' => null
                ];

                $config = $this->setConfig($config, $columnName);

                /** @var Field $field */
                $field = $this->fieldFactory
                    ->setColumn($column)
                    ->setConfig($config)
                    ->get();

                $fields[$columnName] = $field;

                if (!empty($config['form_type']) && $config['form_type'] === 'file') {

                    $field = $this->fieldFactory
                        ->setColumn($column)
                        ->setConfig([
                            'name' => $columnName . '__delete',
                            'presentation' => null,
                            'form_type' => 'checkbox',
                            'no_validate' => true,
                            'validation' => null,
                            'functions' => null
                        ])
                        ->get();
                    $fields[$columnName . '__delete'] = $field;
                }
            }
        }

        return $fields;
    }

    /**
     * @param array|null $relationArray
     * @return mixed
     */
    public function persist(array $relationArray = null, Request $request)
    {
        if (!empty($relationArray)) {
            $keyName = $this->eloquentRelation->getParent()->getKeyName();
            $currentRelations = $this->getResults()->keyBy($keyName);

            $this->readConfig('edit');
            $fieldsBase = $this->getEditFieldsBase();

            foreach ($relationArray as $relationIndex => &$relation) {
                if (!empty($relation[$keyName])
                    && ($currentRelations->has($relation[$keyName]))
                ) {
                    $relationModel = $currentRelations->get($relation[$keyName]);
                } else {
                    $relationModel = $this->eloquentRelation->getRelated()->newInstance();
                }

                $this->modelAbstractor->setInstance($relationModel);
                $secondaryRelations = $this->getSecondaryRelations();


                $this->setKeys($relationModel);

                $shouldBeSkipped = true;
                $delayedRelations = collect();


                foreach ($fieldsBase as $fieldBaseKey => $field) {
                    $fieldName = $field->getName();

                    if (get_class($field->getFormField()) === \FormManager\Fields\File::class) {
                        $handleResult = $this->handleField($request, $relationModel, $relation, $this->name . ".$relationIndex", $fieldName);
                        if (! empty($handleResult['skipNext'])) {
                            unset($relationArray[$relationIndex][$handleResult['skipNext']]);
                        }
                        if (! empty($handleResult['requestValue'])) {
                            $relationArray[$relationIndex][$fieldName] = $handleResult['requestValue'];
                        }
                    }

                    if (get_class($field->getFormField()) === \FormManager\Fields\Checkbox::class) {
                        if (empty($relationArray[$relationIndex][$fieldName])) {
                            // Unchecked checkboxes are not sent, so we force setting them to false
                            $relationArray[$relationIndex][$fieldName] = false;
                        }
                    }
                }


                foreach ($relation as $fieldKey => $fieldValue) {
                    if ($secondaryRelations->has($fieldKey)) {
                        $delayedRelations->put($fieldKey, $fieldValue);
                        continue;
                    }

                    if ($shouldBeSkipped) {
                        $shouldBeSkipped = ($shouldBeSkipped === ($fieldValue === ''));
                    }

                    $relationModel->setAttribute($fieldKey, $fieldValue);
                }

                if (!$shouldBeSkipped) {
                    $relationModel->save();

                    if (!$delayedRelations->isEmpty()) {
                        foreach ($delayedRelations as $relationKey => $delayedRelation) {
                            /** @var RelationContract $secondaryRelation */
                            $secondaryRelation = $secondaryRelations->get($relationKey);

                            $secondaryRelation->persist($delayedRelation, $request);
                        }
                    }
                }
            }
        }
    }

    protected function setKeys(Model $relationModel)
    {
        $relationModel->setAttribute($this->eloquentRelation->getForeignKey(), $this->relatedModel->id);
    }

    protected function skipField($columnName, $key)

    {
        if ($columnName === $this->eloquentRelation->getPlainForeignKey()) {
            return true;
        }

        if ($key === 'emptyResult' && ($columnName === $this->eloquentRelation->getParent()->getKeyName())) {
            return true;
        }

        return false;
    }

    /**
     * @return string
     */
    public function getDisplayType()
    {
        return self::DISPLAY_TYPE_TAB;
    }

    /**
     * @param array $fields
     * @return array
     */
    public function addSecondaryRelationFields(array $fields)
    {
        $tempFields = [];
        foreach ($this->getSecondaryRelations() as $relationKey => $relation) {

            foreach ($relation->getEditFields($relationKey) as $editGroupName => $editGroup) {
                if ($relation->getType() === 'Anavel\Crud\Abstractor\Eloquent\Relation\Select') {
                    $tempFields[key($editGroup)] = $editGroup[key($editGroup)];
                } else {
                    $tempFields[$editGroupName] = $editGroup;
                }
            };
        }
        foreach ($fields[$this->name] as $groupKey => $mainFields) {
            $combinedFields = array_merge($mainFields, $tempFields);
            $fields[$this->name][$groupKey] = $combinedFields;
        }

        return $fields;
    }
}



1			<?php
2			namespace Anavel\Crud\Abstractor\Eloquent\Relation;
3
4			use Anavel\Crud\Abstractor\Eloquent\Relation\Traits\CheckRelationCompatibility;
5			use Anavel\Crud\Abstractor\Eloquent\Traits\HandleFiles;
6			use Anavel\Crud\Contracts\Abstractor\Field;
7			use Anavel\Crud\Contracts\Abstractor\Relation as RelationContract;
8			use App;
9			use Illuminate\Database\Eloquent\Model;
10			use Illuminate\Http\Request;
11			use Illuminate\Support\Collection;
12
13			class MiniCrud extends Relation
14			{
15			use CheckRelationCompatibility;
16			use HandleFiles;
17
18			/** @var \ANavallaSuiza\Laravel\Database\Contracts\Dbal\AbstractionLayer $dbal */
19			protected $dbal;
20
21			/** @var Collection */
22			protected $results;
23
24			protected $compatibleEloquentRelations = array(
25			'Illuminate\Database\Eloquent\Relations\HasMany'
26			);
27
28			/**
29			* @return Collection
30			*/
31	4		protected function getResults()
32			{
33	4		if (empty($this->results)) {
34	4		return $this->results = $this->eloquentRelation->getResults();
35			}
36			return $this->results;
37			}
38
39	8		public function setup()
40			{
41	8		$this->checkRelationCompatibility();
42	6		}
43
44			/**
45			* @return array
46			*/
47	2		public function getEditFields($arrayKey = null)
48			{
49	2		$fields = [];
50	2		if (empty($arrayKey)) {
51	2		$arrayKey = $this->name;
52	2		}
53
54	2		$fieldsBase = $this->getEditFieldsBase();
55
56
57			/** @var Collection $results */
58	2		$results = $this->getResults();
59
60	2		$results->put('emptyResult', '');
61	2		if (!empty($fieldsBase)) {
62	2		foreach ($results as $key => $result) {
63	2		$tempFields = [];
64	2		$index = $key === 'emptyResult' ? 0 : $result->id;
65
66	2		foreach ($fieldsBase as $columnName => $fieldBase) {
67	2		$field = clone $fieldBase;
68	2		if ($this->skipField($columnName, $key)) {
69			continue;
70			}
71
72	2		if ($key !== 'emptyResult') {
73	2		$field->setValue($result->getAttribute($columnName));
74	2		}
75	2		$tempFields[$columnName] = $field;
76
77	2		}
78
79	2		$relationModel = $this->eloquentRelation->getRelated()->newInstance();
80	2		if (!empty($result)) {
81	2		$relationModel = $result;
82	2		}
83
84	2		$this->modelAbstractor->setInstance($relationModel);
85	2		$secondaryRelations = $this->getSecondaryRelations();
86	2		if (!empty($secondaryRelations)) {
87	2	View Code Duplication	foreach ($secondaryRelations as $secondaryRelationKey => $secondaryRelation) {
			0 ignored issues – show Duplication introduced 2016-02-15 12:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88	2		foreach ($secondaryRelation->getEditFields($secondaryRelationKey) as $editGroupName => $editGroup) {
89			if ($secondaryRelation->getType() === 'Anavel\Crud\Abstractor\Eloquent\Relation\Select') {
90			$tempFields[key($editGroup)] = $editGroup[key($editGroup)];
91			} else {
92			$tempFields[$editGroupName] = $editGroup;
93			}
94	2		};
95	2		}
96	2		}
97
98
99	2		$fields[$arrayKey][$index] = $tempFields;
100	2		}
101	2		}
102
103	2		return $fields;
104			}
105
106	4		public function getEditFieldsBase()
107			{
108	4		$fields = [];
109	4		$columns = $this->modelAbstractor->getColumns('edit');
110	4		$this->readConfig('edit');
111
112	4		if (!empty($columns)) {
113	4		$readOnly = [Model::CREATED_AT, Model::UPDATED_AT];
114	4		foreach ($columns as $columnName => $column) {
115	4		if (in_array($columnName, $readOnly, true)) {
116			continue;
117			}
118
119	4		$formType = null;
120	4		if ($columnName === $this->eloquentRelation->getParent()->getKeyName()) {
121			$formType = 'hidden';
122			}
123
124			$config = [
125	4		'name' => $columnName,
126	4		'presentation' => $this->name . ' ' . ucfirst(transcrud($columnName)),
127	4		'form_type' => $formType,
128	4		'no_validate' => true,
129	4		'validation' => null,
130			'functions' => null
131	4		];
132
133	4		$config = $this->setConfig($config, $columnName);
134
135			/** @var Field $field */
136	4		$field = $this->fieldFactory
137	4		->setColumn($column)
138	4		->setConfig($config)
139	4		->get();
140
141	4		$fields[$columnName] = $field;
142
143	4	View Code Duplication	if (!empty($config['form_type']) && $config['form_type'] === 'file') {
			0 ignored issues – show Duplication introduced 2016-02-21 19:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
144			$field = $this->fieldFactory
145			->setColumn($column)
146			->setConfig([
147			'name' => $columnName . '__delete',
148			'presentation' => null,
149			'form_type' => 'checkbox',
150			'no_validate' => true,
151			'validation' => null,
152			'functions' => null
153			])
154			->get();
155			$fields[$columnName . '__delete'] = $field;
156			}
157	4		}
158	4		}
159
160	4		return $fields;
161			}
162
163			/**
164			* @param array\|null $relationArray
165			* @return mixed
166			*/
167	2		public function persist(array $relationArray = null, Request $request)
168			{
169	2		if (!empty($relationArray)) {
170	2		$keyName = $this->eloquentRelation->getParent()->getKeyName();
171	2		$currentRelations = $this->getResults()->keyBy($keyName);
172
173	2		$this->readConfig('edit');
174	2		$fieldsBase = $this->getEditFieldsBase();
175
176	2		foreach ($relationArray as $relationIndex => &$relation) {
177	2		if (!empty($relation[$keyName])
178	2		&& ($currentRelations->has($relation[$keyName]))
179	2		) {
180			$relationModel = $currentRelations->get($relation[$keyName]);
181			} else {
182	2		$relationModel = $this->eloquentRelation->getRelated()->newInstance();
183			}
184
185	2		$this->modelAbstractor->setInstance($relationModel);
186	2		$secondaryRelations = $this->getSecondaryRelations();
187
188
189	2		$this->setKeys($relationModel);
190
191	2		$shouldBeSkipped = true;
192	2		$delayedRelations = collect();
193
194
195	2		foreach ($fieldsBase as $fieldBaseKey => $field) {
196	2		$fieldName = $field->getName();
197
198	2		if (get_class($field->getFormField()) === \FormManager\Fields\File::class) {
199			$handleResult = $this->handleField($request, $relationModel, $relation, $this->name . ".$relationIndex", $fieldName);
200			if (! empty($handleResult['skipNext'])) {
201			unset($relationArray[$relationIndex][$handleResult['skipNext']]);
202			}
203			if (! empty($handleResult['requestValue'])) {
204			$relationArray[$relationIndex][$fieldName] = $handleResult['requestValue'];
205			}
206			}
207
208	2		if (get_class($field->getFormField()) === \FormManager\Fields\Checkbox::class) {
209			if (empty($relationArray[$relationIndex][$fieldName])) {
210			// Unchecked checkboxes are not sent, so we force setting them to false
211			$relationArray[$relationIndex][$fieldName] = false;
212			}
213			}
214	2		}
215
216
217	2		foreach ($relation as $fieldKey => $fieldValue) {
218	2		if ($secondaryRelations->has($fieldKey)) {
219	1		$delayedRelations->put($fieldKey, $fieldValue);
220	1		continue;
221			}
222
223	2		if ($shouldBeSkipped) {
224	2		$shouldBeSkipped = ($shouldBeSkipped === ($fieldValue === ''));
225	2		}
226
227	2		$relationModel->setAttribute($fieldKey, $fieldValue);
228	2		}
229
230	2		if (!$shouldBeSkipped) {
231	2		$relationModel->save();
232
233	2		if (!$delayedRelations->isEmpty()) {
234	1		foreach ($delayedRelations as $relationKey => $delayedRelation) {
235			/** @var RelationContract $secondaryRelation */
236	1		$secondaryRelation = $secondaryRelations->get($relationKey);
237
238	1		$secondaryRelation->persist($delayedRelation, $request);
239	1		}
240	1		}
241	2		}
242	2		}
243	2		}
244	2		}
245
246	1		protected function setKeys(Model $relationModel)
247			{
248	1		$relationModel->setAttribute($this->eloquentRelation->getForeignKey(), $this->relatedModel->id);
249	1		}
250
251	1	View Code Duplication	protected function skipField($columnName, $key)
			0 ignored issues – show Duplication introduced 2016-02-05 10:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
252			{
253	1		if ($columnName === $this->eloquentRelation->getPlainForeignKey()) {
254			return true;
255			}
256
257	1		if ($key === 'emptyResult' && ($columnName === $this->eloquentRelation->getParent()->getKeyName())) {
258			return true;
259			}
260
261	1		return false;
262			}
263
264			/**
265			* @return string
266			*/
267			public function getDisplayType()
268			{
269			return self::DISPLAY_TYPE_TAB;
270			}
271
272			/**
273			* @param array $fields
274			* @return array
275			*/
276			public function addSecondaryRelationFields(array $fields)
277			{
278			$tempFields = [];
279		View Code Duplication	foreach ($this->getSecondaryRelations() as $relationKey => $relation) {
			0 ignored issues – show Duplication introduced 2016-02-15 12:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
280			foreach ($relation->getEditFields($relationKey) as $editGroupName => $editGroup) {
281			if ($relation->getType() === 'Anavel\Crud\Abstractor\Eloquent\Relation\Select') {
282			$tempFields[key($editGroup)] = $editGroup[key($editGroup)];
283			} else {
284			$tempFields[$editGroupName] = $editGroup;
285			}
286			};
287			}
288			foreach ($fields[$this->name] as $groupKey => $mainFields) {
289			$combinedFields = array_merge($mainFields, $tempFields);
290			$fields[$this->name][$groupKey] = $combinedFields;
291			}
292
293			return $fields;
294			}
295			}
296
297

anavel / crud

Push — master ( 7dac91...3d08cb )

MiniCrud::getResults() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like