ModelController::destroy() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - anavel/crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d27d79...fd5cc8 )

unknown

created 2016-03-30 14:54 UTC

ModelController::destroy() B

↳ Parent: ModelController

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	24
ccs	0
cts	0
cp	0
rs	8.9713
cc	2
eloc	14
nc	2
nop	3
crap	6

<?php
namespace Anavel\Crud\Http\Controllers;

use Anavel\Crud\Contracts\Abstractor\Model;
use Anavel\Foundation\Http\Controllers\Controller;
use Anavel\Crud\Contracts\Abstractor\ModelFactory as ModelAbstractorFactory;
use ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager;
use Anavel\Crud\Contracts\Controllers\CustomController;
use Anavel\Crud\Contracts\Form\Generator as FormGenerator;
use Anavel\Crud\Repository\Criteria\OrderByCriteria;
use Anavel\Crud\Repository\Criteria\SearchCriteria;
use Illuminate\Http\Request;
use App;

class ModelController extends Controller
{
    protected $modelFactory;
    protected $modelManager;
    protected $formGenerator;

    public function __construct(ModelAbstractorFactory $modelFactory, ModelManager $modelManager, FormGenerator $formGenerator)
    {
        $this->modelFactory = $modelFactory;
        $this->modelManager = $modelManager;
        $this->formGenerator = $formGenerator;
    }
    
    private function authorizeMethod(Model $modelAbstractor, $methodName)
    {
        if (array_key_exists('authorize', $config = $modelAbstractor->getConfig()) && $config['authorize'] === true) {
            $this->authorize($methodName, $modelAbstractor->getInstance());

        }
    }

    /**
     * @param Model $modelAbstractor
     * @return null|CustomController
     */
    private function customController(Model $modelAbstractor)
    {
        if (! $this instanceof CustomController) { //Avoid infinite recursion
            if (array_key_exists('controller', $config = $modelAbstractor->getConfig()) && (! empty($config['controller']))) {
                /** @var CustomController $controller */
                $controller = App::make($config['controller']);
                $controller->setAbstractor($modelAbstractor);
                return $controller;
            }
        }
        return null;
    }

    /**
     * Display a listing of the resource.
     *
     * @param Request $request
     * @param  string  $model
     * @return Response
     */
    public function index(Request $request, $model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminIndex');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->index($request, $model);
        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());

        if ($request->has('search')) {
            $searchByColumns = array();

            foreach ($modelAbstractor->getListFields() as $field) {
                $searchByColumns[] = $field->getName();
            }

            $repository->pushCriteria(new SearchCriteria($searchByColumns, $request->get('search')));
        }

        if ($request->has('sort')) {
            $repository->pushCriteria(new OrderByCriteria($request->get('sort'), $request->get('direction') === 'desc' ? true : false));
        }

        $items = $repository->paginate(config('anavel-crud.list_max_results'));

        return view('anavel-crud::pages.index', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'items' => $items
        ]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @param  string  $model
     * @return Response
     */
    public function create($model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminCreate');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->create($model);
        }

        $form = $modelAbstractor->getForm(route('anavel-crud.model.store', $modelAbstractor->getSlug()));

        return view('anavel-crud::pages.create', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'form' => $form,
            'relations' => $modelAbstractor->getRelations()
        ]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     * @param  string  $model
     * @return Response
     */
    public function store(Request $request, $model)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminStore');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->store($request, $model);
        }

        // Sets the validation rules
        $modelAbstractor->getForm(route('anavel-crud.model.store', $modelAbstractor->getSlug()));

        $this->validate($request, $modelAbstractor->getValidationRules());

        $modelAbstractor->persist($request);

        session()->flash('anavel-alert', [
            'type'  => 'success',
            'icon'  => 'fa-check',
            'title' => trans('anavel-crud::messages.alert_success_model_store_title'),
            'text'  => trans('anavel-crud::messages.alert_success_model_store_text')
        ]);

        return redirect()->route('anavel-crud.model.index', $model);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Display the specified resource.
     *
     * @param  string  $model
     * @param  int  $id
     * @return Response
     */
    public function show($model, $id)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminShow');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->show($model, $id);
        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());
        $item = $repository->findByOrFail($repository->getModel()->getKeyName(), $id);

        return view('anavel-crud::pages.show', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'item' => $item
        ]);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  string  $model
     * @param  int  $id
     * @return Response
     */
    public function edit($model, $id)
    {
        /** @var Model $modelAbstractor */
        $modelAbstractor = $this->modelFactory->getBySlug($model, $id);

        $this->authorizeMethod($modelAbstractor, 'adminEdit');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->edit($model, $id);
        }

        $form = $modelAbstractor->getForm(route('anavel-crud.model.update', [$modelAbstractor->getSlug(), $id]));
        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());
        $item = $repository->findByOrFail($repository->getModel()->getKeyName(), $id);

        return view('anavel-crud::pages.edit', [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'abstractor' => $modelAbstractor,
            'form' => $form,
            'item' => $item,
            'relations' => $modelAbstractor->getRelations()
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param Request $request
     * @param  string  $model
     * @param  int  $id
     * @return Response
     */
    public function update(Request $request, $model, $id)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model, $id);

        $this->authorizeMethod($modelAbstractor, 'adminUpdate');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->update($request, $model, $id);
        }

        // Sets the validation rules
        $modelAbstractor->getForm(route('anavel-crud.model.update', [$modelAbstractor->getSlug(), $id]));

        $this->validate($request, $modelAbstractor->getValidationRules());

        $modelAbstractor->persist($request);

        session()->flash('anavel-alert', [
            'type'  => 'success',
            'icon'  => 'fa-check',
            'title' => trans('anavel-crud::messages.alert_success_model_update_title'),
            'text'  => trans('anavel-crud::messages.alert_success_model_update_text')
        ]);

        return redirect()->route('anavel-crud.model.edit', [$model, $id]);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param Request $request
     * @param  string  $model
     * @param  int  $id
     * @return Response
     */
    public function destroy(Request $request, $model, $id)
    {
        $modelAbstractor = $this->modelFactory->getBySlug($model);

        $this->authorizeMethod($modelAbstractor, 'adminDestroy');

        if (! empty($customController = $this->customController($modelAbstractor))) {
            return $customController->destroy($request, $model, $id);
        }

        $repository = $this->modelManager->getRepository($modelAbstractor->getModel());
        $item = $repository->findByOrFail($repository->getModel()->getKeyName(), $id);

        $item->delete();

        session()->flash('anavel-alert', [
            'type'  => 'success',
            'icon'  => 'fa-check',
            'title' => trans('anavel-crud::messages.alert_success_model_destroy_title'),
            'text'  => trans('anavel-crud::messages.alert_success_model_destroy_text')
        ]);

        return redirect()->route('anavel-crud.model.index', $model);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			namespace Anavel\Crud\Http\Controllers;
3
4			use Anavel\Crud\Contracts\Abstractor\Model;
5			use Anavel\Foundation\Http\Controllers\Controller;
6			use Anavel\Crud\Contracts\Abstractor\ModelFactory as ModelAbstractorFactory;
7			use ANavallaSuiza\Laravel\Database\Contracts\Manager\ModelManager;
8			use Anavel\Crud\Contracts\Controllers\CustomController;
9			use Anavel\Crud\Contracts\Form\Generator as FormGenerator;
10			use Anavel\Crud\Repository\Criteria\OrderByCriteria;
11			use Anavel\Crud\Repository\Criteria\SearchCriteria;
12			use Illuminate\Http\Request;
13			use App;
14
15			class ModelController extends Controller
16			{
17			protected $modelFactory;
18			protected $modelManager;
19			protected $formGenerator;
20
21			public function __construct(ModelAbstractorFactory $modelFactory, ModelManager $modelManager, FormGenerator $formGenerator)
22			{
23			$this->modelFactory = $modelFactory;
24			$this->modelManager = $modelManager;
25			$this->formGenerator = $formGenerator;
26			}
27
28			private function authorizeMethod(Model $modelAbstractor, $methodName)
29			{
30			if (array_key_exists('authorize', $config = $modelAbstractor->getConfig()) && $config['authorize'] === true) {
31			$this->authorize($methodName, $modelAbstractor->getInstance());
			0 ignored issues – show Bug introduced 2016-03-30 15:01 UTC by Report Bug Copy Issue Report The method `authorize()` does not exist on `Anavel\Crud\Http\Controllers\ModelController`. Did you maybe mean `authorizeMethod()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
32			}
33			}
34
35			/**
36			* @param Model $modelAbstractor
37			* @return null\|CustomController
38			*/
39			private function customController(Model $modelAbstractor)

anavel / crud

Push — master ( d27d79...fd5cc8 )

ModelController::destroy() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like