Analogue\ORM\System\MapperFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	6
Bugs	2	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	make()	0	23	1

<?php

namespace Analogue\ORM\System;

use Analogue\ORM\EntityMap;
use Illuminate\Contracts\Events\Dispatcher;
use Analogue\ORM\Drivers\Manager as DriverManager;

/**
 * Build a mapper instance from an EntityMap object, doing the
 * required parsing of relationships. Abstracting to this class
 * will make it easy to later cache the EntityMap for better performances.
 */
class MapperFactory
{
    /**
     * Manager instance
     *
     * @var \Analogue\ORM\System\Manager
     */
    protected $manager;

    /**
     * DriverManager instance
     *
     * @var \Analogue\ORM\Drivers\Manager
     */
    protected $drivers;

    /**
     * Event dispatcher instance
     *
     * @var \Illuminate\Contracts\Events\Dispatcher
     */
    protected $dispatcher;

    /**
     * MapperFactory constructor.
     * @param DriverManager $drivers
     * @param Dispatcher    $dispatcher
     * @param Manager       $manager
     */
    public function __construct(DriverManager $drivers, Dispatcher $dispatcher, Manager $manager)
    {
        $this->drivers = $drivers;

        $this->dispatcher = $dispatcher;

        $this->manager = $manager;
    }

    /**
     * Return a new Mapper instance
     *
     * @param  string    $entityClass
     * @param  EntityMap $entityMap
     * @return Mapper
     */
    public function make($entityClass, EntityMap $entityMap)

The parameter $entityClass is not used and could be removed.

    {
        $driver = $entityMap->getDriver();
        
        $connection = $entityMap->getConnection();

        $adapter = $this->drivers->getAdapter($driver, $connection);
        
        $entityMap->setDateFormat($adapter->getDateFormat());

        $mapper = new Mapper($entityMap, $adapter, $this->dispatcher, $this->manager);

It seems like $adapter defined by $this->drivers->getAdapter($driver, $connection) on line 65 can be null; however, Analogue\ORM\System\Mapper::__construct() does not accept null, maybe add an additional type check?

        // Fire Initializing Event
        $mapper->fireEvent('initializing', $mapper);

$mapper is of type object<Analogue\ORM\System\Mapper>, but the function expects a object<Analogue\ORM\Entity>.

        
        // Proceed necessary parsing on the EntityMap object
        $entityMap->initialize();

        // Fire Initialized Event
        $mapper->fireEvent('initialized', $mapper);

$mapper is of type object<Analogue\ORM\System\Mapper>, but the function expects a object<Analogue\ORM\Entity>.

        return $mapper;
    }
}