BooleanValidatorTrait::mustBeBoolean() - Code Metrics - Inspection of "Move project to ammit-php/ammit" - ammit-php/ammit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d57f97...544bed )

by Guillaume

created 2018-03-10 13:05 UTC

BooleanValidatorTrait::mustBeBoolean() B

↳ Parent: Project

Complexity

Conditions	5
Paths	2

Size

Total Lines	33
Code Lines	19

Duplication

Lines	20
Ratio	60.61 %

Code Coverage

Tests	13
CRAP Score	5.0592

Importance

Changes

Metric	Value
dl	20
loc	33
rs	8.439
c	0
b	0
f	0
ccs	13
cts	15
cp	0.8667
cc	5
eloc	19
nc	2
nop	4
crap	5.0592

<?php

namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;

use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
use AmmitPhp\Ammit\Domain\BooleanValidation;
use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;

trait BooleanValidatorTrait
{
    /** @var UIValidationEngine */
    protected $validationEngine;

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Boolean ?
     *
     * @return boolean|null Value casted into boolean or null
     */
    public function mustBeBooleanOrEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

    {
        if ($value === '') {
            return null;
        }

        return $this->mustBeBoolean($value, $propertyPath, $parentValidator, $exceptionMessage);
    }

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Boolean ?
     *
     * @return boolean Value casted into boolean or false
     */
    public function mustBeBoolean($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): bool
    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {

                $booleanValidation = new BooleanValidation();
                if ($booleanValidation->isBooleanValid($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                        'Value "%s" is not a boolean.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        // Otherwise "false" would return true
        if (in_array($value, [true, 'true', '1', 1], true)) {

            return true;
        }

        return false;
    }
}


Push — master ( d57f97...544bed )

BooleanValidatorTrait::mustBeBoolean() B

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2
3			namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;
4
5			use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
6			use AmmitPhp\Ammit\Domain\BooleanValidation;
7			use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
8			use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;
9
10			trait BooleanValidatorTrait
11			{
12			/** @var UIValidationEngine */
13			protected $validationEngine;
14
15			/**
16			* Exceptions are caught in order to be processed later
17			* @param mixed $value Boolean ?
18			*
19			* @return boolean\|null Value casted into boolean or null
20			*/
21		View Code Duplication	public function mustBeBooleanOrEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22			{
23			if ($value === '') {
24			return null;
25			}
26
27			return $this->mustBeBoolean($value, $propertyPath, $parentValidator, $exceptionMessage);
28			}
29
30			/**
31			* Exceptions are caught in order to be processed later
32			* @param mixed $value Boolean ?
33			*
34			* @return boolean Value casted into boolean or false
35			*/
36			public function mustBeBoolean($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): bool
37			{
38	1		$this->validationEngine->validateFieldValue(
39	1		$parentValidator ?: $this,
40	1	View Code Duplication	function() use ($value, $propertyPath, $exceptionMessage) {
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41	1		$booleanValidation = new BooleanValidation();
42	1		if ($booleanValidation->isBooleanValid($value)) {
43	1		return;
44			}
45
46	1		if (null === $exceptionMessage) {
47			$exceptionMessage = sprintf(
			0 ignored issues – show Bug introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$exceptionMessage`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
48			'Value "%s" is not a boolean.',
49			$value
50			);
51			}
52
53	1		throw new InvalidArgumentException(
54			$exceptionMessage,
55	1		0,
56			$propertyPath,
57			$value
58			);
59	1		}
60			);
61
62			// Otherwise "false" would return true
63	1		if (in_array($value, [true, 'true', '1', 1], true)) {
			0 ignored issues – show Unused Code introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This `if` statement, and the following `return` statement can be replaced with `return in_array($value, ...'true', '1', 1), true);`. Loading history...
64	1		return true;
65			}
66
67	1		return false;
68			}
69			}
70

ammit-php / ammit

Push — master ( d57f97...544bed )

BooleanValidatorTrait::mustBeBoolean() B

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like